Differential D46015

bsd.port.mk: remove unused base system binutils support
ClosedPublic
Actions

Authored by emaste on Jul 17 2024, 8:49 PM.

Details

Reviewers

mat

Group Reviewers

portmgr

Commits

R11:a01528793ea6: bsd.port.mk: remove unused base system binutils support

Summary

GNU binutils 2.17.50 was removed from the base system (for all archs)
prior to FreeBSD 13.0.  Remove ports support for base system ld.bfd.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jul 17 2024, 8:49 PM

emaste created this revision.

emaste added inline comments.

Mk/bsd.port.mk
1874	could maybe drop the condition as well, always force USE_BINUTILS=yes here

rene added a subscriber: rene.Jul 18 2024, 8:22 PM

rene added inline comments.

Mk/bsd.port.mk
1874	Yes, because the code boils down to: . if !defined(USE_BINUTILS) USE_BINUTILS=yes . endif so USE_BINUTILS=yes always holds now anyway.

simplify

Assuming you tested this, and you probably know better than me what this actually does 😇

This revision is now accepted and ready to land.Jul 19 2024, 5:44 AM

Closed by commit R11:a01528793ea6: bsd.port.mk: remove unused base system binutils support (authored by emaste). · Explain WhyAug 13 2024, 3:34 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: R11:a01528793ea6: bsd.port.mk: remove unused base system binutils support.

emaste mentioned this in D45632: bsd.port.mk: remove unused base system binutils support.Aug 13 2024, 3:35 PM

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

8 lines

Diff 142042

View Options

bsd.port.mk: remove unused base system binutils supportClosedPublicActions