Page MenuHomeFreeBSD

pkgbase: Make src package creation recipes more precise
ClosedPublic

Authored by markj on Aug 19 2024, 3:24 PM.
Tags
None
Referenced Files
F166451550: D46320.diff
Thu, Aug 13, 3:59 PM
Unknown Object (File)
Wed, Aug 12, 3:37 AM
Unknown Object (File)
Tue, Aug 11, 6:53 PM
Unknown Object (File)
Mon, Aug 10, 1:48 PM
Unknown Object (File)
Mon, Aug 10, 10:53 AM
Unknown Object (File)
Mon, Aug 10, 10:53 AM
Unknown Object (File)
Sun, Aug 9, 7:02 PM
Unknown Object (File)
Sun, Aug 9, 7:01 PM
Subscribers

Details

Summary

Just remove the plist created by the respective rule. Otherwise the two
receipes can race with each other.

Fixes: d7d5c9efef03 ("pkgbase: Let source packages be built in parallel")
Reported by: Mark Millard <marklmi@yahoo.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Aug 19 2024, 3:24 PM
This revision is now accepted and ready to land.Aug 19 2024, 3:27 PM

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

Yeah, I'm not sure. -f should ensure that the exit status is 0 if the file doesn't exit.