Page MenuHomeFreeBSD

pkgbase: Make src package creation recipes more precise
ClosedPublic

Authored by markj on Aug 19 2024, 3:24 PM.
Tags
None
Referenced Files
F173489547: D46320.id.diff
Sat, Sep 26, 7:53 AM
F173409238: D46320.id.diff
Fri, Sep 25, 6:54 PM
Unknown Object (File)
Thu, Sep 10, 11:40 PM
Unknown Object (File)
Thu, Sep 10, 2:31 PM
Unknown Object (File)
Wed, Sep 9, 6:17 AM
Unknown Object (File)
Sun, Sep 6, 9:43 PM
Unknown Object (File)
Wed, Sep 2, 8:39 AM
Unknown Object (File)
Sat, Aug 29, 3:06 PM
Subscribers

Details

Summary

Just remove the plist created by the respective rule. Otherwise the two
receipes can race with each other.

Fixes: d7d5c9efef03 ("pkgbase: Let source packages be built in parallel")
Reported by: Mark Millard <marklmi@yahoo.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Aug 19 2024, 3:24 PM
This revision is now accepted and ready to land.Aug 19 2024, 3:27 PM

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

|| : seems unnecessarily clever to me, IMO || true is more obvious
but what error are we trying to ignore here anyway?

Yeah, I'm not sure. -f should ensure that the exit status is 0 if the file doesn't exit.