Feed Advanced Search

Fri, Jan 19

emaste added a comment to D13985: Use PCID to optimize PTI..

This passes smoke test on my Sandy Bridge laptop (X220).

Fri, Jan 19, 10:29 PM
emaste accepted D13986: Remove extra copy of bootinfo.c. It's a bit rotted copy of the one in efi/loader..

Sounds good to me. When bringing back i386 EFI we should start from (and end with) a shared bootinfo.c

Fri, Jan 19, 5:25 PM
emaste added inline comments to D13971: Enable PTI by default for Intel.
Fri, Jan 19, 3:47 PM
emaste committed rS328166: Enable KPTI by default on amd64 for non-AMD CPUs.
Enable KPTI by default on amd64 for non-AMD CPUs
Fri, Jan 19, 3:42 PM
emaste closed D13971: Enable PTI by default for Intel.
Fri, Jan 19, 3:42 PM
emaste updated subscribers of D13985: Use PCID to optimize PTI..
Fri, Jan 19, 3:30 PM

Thu, Jan 18

emaste committed rS328144: lld: Fix incorrect physical address on self-referencing AT command..
lld: Fix incorrect physical address on self-referencing AT command.
Thu, Jan 18, 9:40 PM
emaste committed rS328143: lld: Handle parsing AT(ADDR(.foo-bar))..
lld: Handle parsing AT(ADDR(.foo-bar)).
Thu, Jan 18, 9:39 PM
emaste committed rS328141: lld: Fix for ld.lld does not accept "AT" syntax for declaring LMA region.
lld: Fix for ld.lld does not accept "AT" syntax for declaring LMA region
Thu, Jan 18, 9:38 PM
emaste accepted D13942: stand: Move sections around to fix stand/ build with ld.lld on armv7.

Sounds good to me with the testing that was done.

Thu, Jan 18, 6:52 PM
emaste added a comment to D13971: Enable PTI by default for Intel.

In the commit message we can reference this quote from https://www.amd.com/en/corporate/speculative-execution:

We believe AMD processors are not susceptible due to our use of privilege level protections within paging architecture and no mitigation is required.

Thu, Jan 18, 6:44 PM
emaste added inline comments to D13971: Enable PTI by default for Intel.
Thu, Jan 18, 6:03 PM
emaste updated subscribers of D13971: Enable PTI by default for Intel.
Thu, Jan 18, 4:46 PM
emaste added inline comments to D13931: Implement mitigation for Spectre Version 2 attacks on ARMv7..
Thu, Jan 18, 2:33 PM
emaste added inline comments to D13961: Updated the FAQ book's Chapter 15 about serial communicators.
Thu, Jan 18, 3:56 AM
emaste added a comment to D13874: Don't include long double routines on architectures with small long double..

Should we add a comment and perhaps a reference to lib/msun?

Thu, Jan 18, 2:36 AM

Wed, Jan 17

emaste requested changes to D13961: Updated the FAQ book's Chapter 15 about serial communicators.
Wed, Jan 17, 9:36 PM
emaste added inline comments to D13961: Updated the FAQ book's Chapter 15 about serial communicators.
Wed, Jan 17, 9:32 PM
emaste accepted D13961: Updated the FAQ book's Chapter 15 about serial communicators.

Looks good to me, but needs someone with a doc commit bit to approve.

Wed, Jan 17, 9:31 PM
emaste committed rS328095: kldxref: additional sytle(9) cleanup.
kldxref: additional sytle(9) cleanup
Wed, Jan 17, 8:43 PM
emaste committed rS328094: kldxref: improve style(9).
kldxref: improve style(9)
Wed, Jan 17, 8:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Jan 17, 8:00 PM
emaste added a comment to D13797: PTI for amd64..

Committed in rS328083

Wed, Jan 17, 1:08 PM

Tue, Jan 16

emaste added a comment to D13941: stand: use -z norelro when linking EFI components.

If the root cause is addressed by D13942 we could abandon this change, even though I think it doesn't hurt to have this in.

Tue, Jan 16, 10:41 PM
emaste updated subscribers of D13942: stand: Move sections around to fix stand/ build with ld.lld on armv7.
Tue, Jan 16, 10:37 PM
emaste created D13941: stand: use -z norelro when linking EFI components.
Tue, Jan 16, 9:58 PM
emaste added a comment to D13937: Don't hardcode /usr/bin as the path for mktemp in build tools.

This reverts rS88450, but the commit message there unfortunately states exactly what was done but not why.

Tue, Jan 16, 8:25 PM
emaste updated subscribers of D13937: Don't hardcode /usr/bin as the path for mktemp in build tools.
Tue, Jan 16, 8:23 PM
emaste added a comment to D13938: Include <stdint.h> in libc/inconv.

Does stdint.h define all of the types needed here (i.e., is sys/types.h now redundant)?

Tue, Jan 16, 8:22 PM
emaste added a comment to D13939: Allow building bin/cat on non-FreeBSD systems.

Came from rS305841.

Tue, Jan 16, 8:21 PM
emaste accepted D13926: Require the SHF_ALLOC flag for program sections from kernel object modules..
Tue, Jan 16, 8:16 PM
emaste accepted D13936: Use ln -n instead of -h to allow building the kernel on Linux.
Tue, Jan 16, 7:38 PM
emaste added a comment to D13936: Use ln -n instead of -h to allow building the kernel on Linux.

LGTM. I wonder if we should have a tiny comment that says we use -n for broader portability (since the -h is documented in the man page as the canonical option).

Tue, Jan 16, 7:38 PM
emaste committed rS328052: kldxref: handle modules with md_cval at the end of allocated sections.
kldxref: handle modules with md_cval at the end of allocated sections
Tue, Jan 16, 6:20 PM
emaste closed D13923: Fix kldxref failing for modules with a short mc_cval.
Tue, Jan 16, 6:20 PM
emaste added inline comments to D13923: Fix kldxref failing for modules with a short mc_cval.
Tue, Jan 16, 3:23 PM
emaste added inline comments to D13923: Fix kldxref failing for modules with a short mc_cval.
Tue, Jan 16, 2:48 AM
emaste accepted D13926: Require the SHF_ALLOC flag for program sections from kernel object modules..

I think this is fine. Do you want to handle the case in ‚Äčlink_elf_link_preload too?

Tue, Jan 16, 2:19 AM

Mon, Jan 15

emaste added inline comments to D13923: Fix kldxref failing for modules with a short mc_cval.
Mon, Jan 15, 10:04 PM
emaste added a comment to D13919: mitigate against CVE-2017-5715 by clearing registers upon returning from the guest.

Committed in rS328011 (which incorrectly referenced D13573)

Mon, Jan 15, 8:21 PM
emaste updated subscribers of D13923: Fix kldxref failing for modules with a short mc_cval.
Mon, Jan 15, 7:26 PM

Sun, Jan 14

emaste committed rS327969: Enable VIMAGE in i386 GENERIC (revert r327840).
Enable VIMAGE in i386 GENERIC (revert r327840)
Sun, Jan 14, 4:05 PM

Sat, Jan 13

emaste committed rS327910: Revert r327823, Enable ld.lld as bootstrap linker by default on i386.
Revert r327823, Enable ld.lld as bootstrap linker by default on i386
Sat, Jan 13, 4:01 AM
emaste added a comment to D13884: Report CG checksum mismatches..

FWIW I have disabled SUJ by default in the installer, in rS327890, until the underlying issue with SUJ + CG checksums is addressed.

Sat, Jan 13, 2:33 AM

Fri, Jan 12

emaste committed rS327890: bsdinstall: disable SUJ by default.
bsdinstall: disable SUJ by default
Fri, Jan 12, 8:26 PM
emaste closed D13890: Removed soft-update journaling from default.
Fri, Jan 12, 8:26 PM
emaste added inline comments to D13890: Removed soft-update journaling from default.
Fri, Jan 12, 8:25 PM
emaste accepted D13890: Removed soft-update journaling from default.
Fri, Jan 12, 8:07 PM
emaste committed rS327889: Revert r280909 "unwind-d2 build workaround for arm64".
Revert r280909 "unwind-d2 build workaround for arm64"
Fri, Jan 12, 8:03 PM
emaste added a comment to D7338: Disconnect objdump from the build.

Also graphics/OpenEXR and lang/fsharp on i386.

Fri, Jan 12, 5:31 PM
emaste added a comment to D7338: Disconnect objdump from the build.

For the ports infrastructure security-check thing we should just switch to readelf instead.

Fri, Jan 12, 5:29 PM
emaste added a comment to D13884: Report CG checksum mismatches..

See also PR 225110

Fri, Jan 12, 3:45 PM
emaste committed rS327860: ANSIfy function definitions in sys/vm/.
ANSIfy function definitions in sys/vm/
Fri, Jan 12, 3:50 AM
emaste added inline comments to D13812: Workaround Spectre Variant 2 on arm64..
Fri, Jan 12, 3:31 AM
emaste updated the diff for D7338: Disconnect objdump from the build.

rebase

Fri, Jan 12, 3:19 AM
emaste created D13881: Add deprecation notice to objdump man page.
Fri, Jan 12, 3:16 AM

Thu, Jan 11

emaste committed rS327840: Temporarily disable VIMAGE on i386.
Temporarily disable VIMAGE on i386
Thu, Jan 11, 7:09 PM
emaste added a comment to D13812: Workaround Spectre Variant 2 on arm64..

I would be happy to test on my SoftIron OverDrive 1000. I'll start on that today.

Thu, Jan 11, 6:48 PM
emaste committed rS327824: regen src.conf.5 after r327823, WITH_LLD_BOOTSTRAP for i386.
regen src.conf.5 after r327823, WITH_LLD_BOOTSTRAP for i386
Thu, Jan 11, 2:21 PM
emaste committed rS327823: Enable ld.lld as bootstrap linker by default on i386.
Enable ld.lld as bootstrap linker by default on i386
Thu, Jan 11, 2:03 PM
emaste accepted D13738: patch(1): Don't check for NUL bytes in Plan A.
Thu, Jan 11, 3:08 AM

Wed, Jan 10

emaste added a comment to D13797: PTI for amd64..

This passed a buildworld + buildkernel smoketest on my AMD Threadripper system. I didn't pay very close attention to the time to complete. It's somewhat slower compared to an unpatched kernel.

Wed, Jan 10, 11:40 PM
emaste committed rS327787: Mention switch to ld.lld for amd64 in UPDATING.
Mention switch to ld.lld for amd64 in UPDATING
Wed, Jan 10, 8:49 PM
emaste closed D13827: Enable ld.lld as bootstrap linker by default on amd64.
Wed, Jan 10, 8:36 PM
emaste committed rS327784: regen src.conf.5 after r327783, WITH_LLD_BOOTSTRAP default.
regen src.conf.5 after r327783, WITH_LLD_BOOTSTRAP default
Wed, Jan 10, 8:36 PM
emaste added a comment to D13827: Enable ld.lld as bootstrap linker by default on amd64.

Committed in rS327783

Wed, Jan 10, 8:30 PM
emaste committed rS327783: Enable ld.lld as bootstrap linker by default on amd64.
Enable ld.lld as bootstrap linker by default on amd64
Wed, Jan 10, 8:28 PM
emaste added a comment to D13827: Enable ld.lld as bootstrap linker by default on amd64.

See also D13813 for a few open comments on the man page

Wed, Jan 10, 6:15 PM
emaste committed rS327778: src.conf.5: regen after r325692 and r326888.
src.conf.5: regen after r325692 and r326888
Wed, Jan 10, 6:15 PM
emaste added inline comments to D13813: introduce basic lld man page.
Wed, Jan 10, 6:06 PM
emaste updated subscribers of D13827: Enable ld.lld as bootstrap linker by default on amd64.
Wed, Jan 10, 5:55 PM
emaste created D13827: Enable ld.lld as bootstrap linker by default on amd64.
Wed, Jan 10, 5:52 PM
emaste committed rS327770: lld: introduce basic man page.
lld: introduce basic man page
Wed, Jan 10, 4:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Jan 10, 4:01 PM
emaste added inline comments to D13813: introduce basic lld man page.
Wed, Jan 10, 3:12 PM
emaste updated the diff for D13813: introduce basic lld man page.

First round of cleanup from bjk

Wed, Jan 10, 2:49 PM
emaste added inline comments to D13813: introduce basic lld man page.
Wed, Jan 10, 2:49 PM
emaste added a comment to D13813: introduce basic lld man page.

Thanks for the extensive comments! I'll address the grammatical ones before commit. The "valid values" questions etc. probably require more research and will be in a followup.

Wed, Jan 10, 1:21 PM
emaste updated the diff for D13813: introduce basic lld man page.
  • Connect to Makefile
  • document -z text, -z notext
  • use .Dv for tags
Wed, Jan 10, 1:34 AM

Tue, Jan 9

emaste added a comment to D13812: Workaround Spectre Variant 2 on arm64..

ThunderX is not vulnerable to CVE-2017-5715, CVE-2017-5753, or CVE-2017-5754.

Tue, Jan 9, 6:36 PM
emaste updated the diff for D13813: introduce basic lld man page.
  • add . at end of descriptions
  • wrap
  • expand -o output argument
  • use .Fn for _exit function markup
Tue, Jan 9, 5:30 PM
emaste added a comment to D13813: introduce basic lld man page.

While reviewing I found that ld does not support --output=path. We may find more of these, and will submit all of them upstream at the end of this.

Tue, Jan 9, 5:21 PM
emaste added a comment to D13799: Do not build lint(1) by default on stable-11, add WITH_LINT to enable building it..

It doesn't follow our normal deprecation policy but given that lint (when it builds) is not usable anyhow I think it's acceptable. We need to ensure that it is noted in the release notes though.

Tue, Jan 9, 5:08 PM
emaste added a comment to D13813: introduce basic lld man page.

Rafael I'd be happy for this to go upstream as well after editing.

Tue, Jan 9, 4:52 PM
emaste updated subscribers of D13813: introduce basic lld man page.
Tue, Jan 9, 4:51 PM
emaste created D13813: introduce basic lld man page.
Tue, Jan 9, 4:49 PM
emaste added inline comments to D13797: PTI for amd64..
Tue, Jan 9, 2:25 PM
emaste committed rS327712: MFC r327489: elfcopy: copy raw (untranslated) contents to binary output.
MFC r327489: elfcopy: copy raw (untranslated) contents to binary output
Tue, Jan 9, 12:27 AM
emaste added a comment to D13799: Do not build lint(1) by default on stable-11, add WITH_LINT to enable building it..

https://bugs.freebsd.org/223892

Tue, Jan 9, 12:04 AM

Fri, Jan 5

emaste committed rS327588: MFC r327497, r327498: fix memory disclosure in hpt* ioctls.
MFC r327497, r327498: fix memory disclosure in hpt* ioctls
Fri, Jan 5, 4:05 PM
emaste added a comment to D12746: modify embed_mfs.sh to embed an MFS image into either loader.efi or the kernel.

Err rS327526

Fri, Jan 5, 12:13 AM
emaste added a comment to D12746: modify embed_mfs.sh to embed an MFS image into either loader.efi or the kernel.

Hi @worldofzak_gmail.com, sorry I didn't reference the followup commit here. This should have been fixed by rS326992

Fri, Jan 5, 12:11 AM

Wed, Jan 3

emaste committed rS327529: ath: fix possible memory disclosure in ioctl handler.
ath: fix possible memory disclosure in ioctl handler
Wed, Jan 3, 7:28 PM
emaste committed rS327527: ath: revert accidental change committed with r327526.
ath: revert accidental change committed with r327526
Wed, Jan 3, 7:24 PM
emaste committed rS327526: embed_mfs: correctly test grep return value.
embed_mfs: correctly test grep return value
Wed, Jan 3, 7:22 PM

Tue, Jan 2

emaste committed rS327503: kldxref: correct function names in warning messages.
kldxref: correct function names in warning messages
Tue, Jan 2, 9:32 PM
emaste added a comment to D13738: patch(1): Don't check for NUL bytes in Plan A.

Out of curiosity why are there NUL bytes in the first place?

Tue, Jan 2, 8:24 PM
emaste committed rS327500: ath: fix possible memory disclosures in ioctl handlers.
ath: fix possible memory disclosures in ioctl handlers
Tue, Jan 2, 7:34 PM
emaste committed rS327499: ath: fix memory disclosure from ath_btcoex_ioctl.
ath: fix memory disclosure from ath_btcoex_ioctl
Tue, Jan 2, 7:29 PM
emaste added inline comments to D12899: Prepare to add more information about our triaging of items..
Tue, Jan 2, 6:53 PM