Feed Advanced Search

Today

emaste committed rS323951: Revert r323935 as it broke the build.
Revert r323935 as it broke the build
Sat, Sep 23, 12:36 PM

Yesterday

emaste added a comment to D8753: Introduce libcaspermock.

From in-person working group session, a suggestion to rename libcasper.h to libcasper.h.in and run unifdef on it during install.

Fri, Sep 22, 1:15 PM · capsicum
emaste added a comment to D12421: Compile loader as Little-Endian on PPC64/POWER8.

For future updates please include full context (e.g. git diff -U9999)

Fri, Sep 22, 11:17 AM
emaste committed rS323903: MFC r323611: fastmatch.h: remove duplicate #defines.
MFC r323611: fastmatch.h: remove duplicate #defines
Fri, Sep 22, 6:16 AM

Thu, Sep 21

emaste accepted D8754: Convert ping to use libcaspermock when Casper is disabled..
Thu, Sep 21, 1:43 PM · capsicum
emaste committed rS323862: MFC r323587: octeon sdk: initialize variable to quiet Clang warning.
MFC r323587: octeon sdk: initialize variable to quiet Clang warning
Thu, Sep 21, 12:32 PM

Wed, Sep 20

emaste committed rS323837: MFC r323539: qlnx: exclude if WITHOUT_SOURCELESS_UCODE set.
MFC r323539: qlnx: exclude if WITHOUT_SOURCELESS_UCODE set
Wed, Sep 20, 10:11 PM

Sun, Sep 17

emaste accepted D12400: Update to file 5.32.
Sun, Sep 17, 6:14 PM
emaste added a comment to D12391: libsysdecode: report invalid cap_rights_t.
In D12391#257162, @cem wrote:

I see. I was looking at the C file subr_capability.c and didn't know to look in that header.

Sun, Sep 17, 4:09 PM
emaste committed rS323675: libsysdecode: report invalid cap_rights_t.
libsysdecode: report invalid cap_rights_t
Sun, Sep 17, 2:04 PM
emaste closed D12391: libsysdecode: report invalid cap_rights_t.
Sun, Sep 17, 2:04 PM
emaste added a comment to D12391: libsysdecode: report invalid cap_rights_t.

From sys/sys/caprights.h:

/*
 * The top two bits in the first element of the cr_rights[] array contain
 * total number of elements in the array - 2. This means if those two bits are
 * equal to 0, we have 2 array elements.
 * The top two bits in all remaining array elements should be 0.
 * The next five bits contain array index. Only one bit is used and bit position
 * in this five-bits range defines array index. This means there can be at most
 * five array elements.
 */

and sys/kern/subr_capability.c:

static __inline int
right_to_index(uint64_t right)
{
        static const int bit2idx[] = {
                -1, 0, 1, -1, 2, -1, -1, -1, 3, -1, -1, -1, -1, -1, -1, -1,    
                4, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1  
        };
        int idx;
Sun, Sep 17, 2:00 PM

Sat, Sep 16

emaste created D12391: libsysdecode: report invalid cap_rights_t.
Sat, Sep 16, 1:31 AM

Fri, Sep 15

emaste added a comment to D12380: correct cap_rights_* varargs use.
In D12380#256984, @ed wrote:

The reason that empty calls are disallowed is because that would expand to cap_rights_is_set(, 0ULL); notice the bad comma. The advantage of the existing code is that it carefully avoids using ##__VA_ARGS__, which is only permitted in C (not C++) as of C99.

Fri, Sep 15, 9:42 PM
emaste added a reviewer for D12380: correct cap_rights_* varargs use: ed.
Fri, Sep 15, 8:34 PM
emaste committed rS323623: rename(2): document capability mode errors.
rename(2): document capability mode errors
Fri, Sep 15, 8:12 PM
emaste closed D12339: rename(2): document capability mode errors.
Fri, Sep 15, 8:12 PM
emaste closed D12343: open(2): update ENOTCAPABLE error for ...
Fri, Sep 15, 8:06 PM
emaste committed rS323622: open(2): update ENOTCAPABLE description for .. lookups.
open(2): update ENOTCAPABLE description for .. lookups
Fri, Sep 15, 8:06 PM
emaste accepted D12384: Add missing newline after unknown MIPS-specific dynamic entries..
Fri, Sep 15, 7:31 PM
emaste added a comment to D12380: correct cap_rights_* varargs use.
In D12380#256853, @cem wrote:

Probably the goal of the original version was to avoid the non-standard "foo, ## bar" compiler extension. I am ok with the change, though.

Fri, Sep 15, 4:00 PM
emaste accepted D12381: bsdgrep: disable TRE implementation by default.
Fri, Sep 15, 3:53 PM
emaste created D12380: correct cap_rights_* varargs use.
Fri, Sep 15, 3:02 PM
emaste closed D12375: fastmatch.h: remove duplicate #defines.
Fri, Sep 15, 1:34 PM
emaste committed rS323611: fastmatch.h: remove duplicate #defines.
fastmatch.h: remove duplicate #defines
Fri, Sep 15, 1:34 PM
emaste created D12375: fastmatch.h: remove duplicate #defines.
Fri, Sep 15, 1:35 AM
emaste committed rS323607: Update OptionalObsoleteFiles.inc with NTP docs.
Update OptionalObsoleteFiles.inc with NTP docs
Fri, Sep 15, 12:54 AM

Thu, Sep 14

emaste committed rS323587: octeon sdk: initialize variable to quiet Clang warning.
octeon sdk: initialize variable to quiet Clang warning
Thu, Sep 14, 4:41 PM
emaste added a comment to D12370: loader: biosmem.c cstyle cleanup.

I agree with @imp, for future changes like this you could just go ahead and commit the style / whitespace fix and then submit the review from that.

Thu, Sep 14, 3:37 PM
emaste accepted D12371: Recognize NT_PTLWPINFO and NT_ARM_VFP in FreeBSD ELF cores..
Thu, Sep 14, 3:34 PM
emaste added a comment to D12368: loader: biosmem allocate heap just below 4GB.

The whitespace changes make this a bit hard to read - do you have them as a separate local change that could be committed first?

Thu, Sep 14, 12:48 PM
emaste committed rS323571: MFC r323448: bsdinstall: Ignore error return from newaliases(1).
MFC r323448: bsdinstall: Ignore error return from newaliases(1)
Thu, Sep 14, 1:24 AM
emaste committed rS323570: MFC r321226: bsdinstall: improve checksum mismatch error for snapshots.
MFC r321226: bsdinstall: improve checksum mismatch error for snapshots
Thu, Sep 14, 12:41 AM
emaste committed rS323569: MFC r316802 (cem): bsdinstall(8): Sprinkle a snprintf to fixed size buffer.
MFC r316802 (cem): bsdinstall(8): Sprinkle a snprintf to fixed size buffer
Thu, Sep 14, 12:39 AM
emaste committed rS323568: MFC r323448: bsdinstall: Ignore error return from newaliases(1).
MFC r323448: bsdinstall: Ignore error return from newaliases(1)
Thu, Sep 14, 12:35 AM

Wed, Sep 13

emaste accepted D12284: gcc builds: reenable -Wstrict-overflow.
Wed, Sep 13, 7:58 PM
emaste accepted D9680: Increase EFI MSDOSFS image size to 512Kib.
Wed, Sep 13, 1:21 PM
emaste committed rS323539: qlnx: exclude if WITHOUT_SOURCELESS_UCODE set.
qlnx: exclude if WITHOUT_SOURCELESS_UCODE set
Wed, Sep 13, 12:16 PM
emaste accepted D12317: Deorbit catman. It's useless on modern hardware..
Wed, Sep 13, 12:08 PM
emaste added a comment to D10931: boot1 generate-fat: generate all templates at once.

Indeed, make that D9680.

Wed, Sep 13, 12:22 AM
emaste added a comment to D12343: open(2): update ENOTCAPABLE error for ...
In D12343#255946, @kib wrote:

Perhaps also mention that dotdot is not allowed on non-local fs, unless vfs.lookup_cap_dotdot ise set.

Wed, Sep 13, 12:19 AM
emaste added a comment to D10931: boot1 generate-fat: generate all templates at once.

I'm unsure as to what needs to happen now. Do I need to do anything to my patches yet?

Wed, Sep 13, 12:14 AM

Tue, Sep 12

emaste created D12343: open(2): update ENOTCAPABLE error for ...
Tue, Sep 12, 3:37 PM
emaste added a comment to D12339: rename(2): document capability mode errors.

Hrm, although the ENOTCAPABLE errors should really be augmented with "... and the process is in capability mode."

Tue, Sep 12, 1:12 PM
emaste created D12339: rename(2): document capability mode errors.
Tue, Sep 12, 1:10 PM
emaste committed rS323476: make-memstick.sh: use 'set -e' to abort if any step fails.
make-memstick.sh: use 'set -e' to abort if any step fails
Tue, Sep 12, 12:44 AM

Mon, Sep 11

emaste committed rS323448: Ignore error return from newaliases(1).
Ignore error return from newaliases(1)
Mon, Sep 11, 5:39 PM
emaste added a comment to D9680: Increase EFI MSDOSFS image size to 512Kib.
In D9680#239393, @imp wrote:

Why not 50MB instead of 512kb? That's stupidly small and precludes any and all future use of UEFI programs as well as boot block bloat. bz2 compressed, the size difference is trivial.

Mon, Sep 11, 3:53 PM
emaste committed rS323438: make-memstick.sh: use UFSv2.
make-memstick.sh: use UFSv2
Mon, Sep 11, 2:42 PM
emaste closed D12231: make-memstick.sh: use UFSv2.
Mon, Sep 11, 2:42 PM
emaste committed rS323437: revert unintentional changes from r323436.
revert unintentional changes from r323436
Mon, Sep 11, 2:36 PM
emaste committed rS323436: boot1: remove BOOT1_MAXSIZE default value.
boot1: remove BOOT1_MAXSIZE default value
Mon, Sep 11, 2:33 PM
emaste committed rS323407: boot1 generate-fat: generate all templates at once.
boot1 generate-fat: generate all templates at once
Mon, Sep 11, 12:37 AM
emaste closed D10931: boot1 generate-fat: generate all templates at once.
Mon, Sep 11, 12:37 AM
emaste committed rS323405: newvers.sh: speed up failing git-svn revision search.
newvers.sh: speed up failing git-svn revision search
Mon, Sep 11, 12:14 AM

Sun, Sep 10

emaste committed rS323394: newvers.sh: accept "git-svn-id:" at the start of a line only.
newvers.sh: accept "git-svn-id:" at the start of a line only
Sun, Sep 10, 7:12 PM
emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Sun, Sep 10, 2:20 AM

Sat, Sep 9

emaste added a comment to D10931: boot1 generate-fat: generate all templates at once.
In D10931#255107, @imp wrote:

Once again I ask: where are we with makefs and FAT filesystems? :)

Sat, Sep 9, 10:22 PM
emaste added a comment to D10931: boot1 generate-fat: generate all templates at once.

maybe switch to xz (doesn't save any space over bzip, but is one of the only remaining uses of bzip in buildworld)

Sat, Sep 9, 8:52 PM
emaste added a comment to D12295: Kill gets().

D12298 is what I tried during Vixie's talk

Sat, Sep 9, 8:33 PM
emaste created D12298: libc: remove gets.
Sat, Sep 9, 8:33 PM
emaste updated the diff for D10931: boot1 generate-fat: generate all templates at once.

disallow arch-specific differences in fs images by enforcing known 0x2d offset

Sat, Sep 9, 7:31 PM
emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Sat, Sep 9, 7:18 PM
emaste updated the diff for D10931: boot1 generate-fat: generate all templates at once.

Update usage message as suggested by @ngie

Sat, Sep 9, 7:15 PM
emaste added inline comments to D10931: boot1 generate-fat: generate all templates at once.
Sat, Sep 9, 7:12 PM
emaste added a comment to D12290: Add AT_HWCAP and AT_EHDRFLAGS on all platforms..

Looks good to me.

Sat, Sep 9, 2:39 PM
emaste committed rS323366: MFC r320069: Add ZFS to Linux statfs ftype.
MFC r320069: Add ZFS to Linux statfs ftype
Sat, Sep 9, 2:30 PM
emaste added a comment to D12284: gcc builds: reenable -Wstrict-overflow.

It appears to have been in upstream: ftp://ftp.iana.org/tz/code/zic.c (see oadd).

As for when we might sync with upstream next, I have no idea. Last sync appears to have been in 2010.

Sat, Sep 9, 1:32 PM
emaste added inline comments to D12255: Add support for Armada 3700 EHCI.
Sat, Sep 9, 1:29 PM · arm64
emaste added inline comments to D12250: Introduce UART driver module for Armada 3700.
Sat, Sep 9, 1:26 PM · arm64
emaste added inline comments to D12259: Enable compilation of Marvell NETA controller with arm64 GENERIC.
Sat, Sep 9, 1:20 PM · arm64
emaste committed rS323337: MFC r322374: bsdinstall: record DHCP config after obtaining lease.
MFC r322374: bsdinstall: record DHCP config after obtaining lease
Sat, Sep 9, 1:23 AM
emaste committed rS323336: MFC r322374: bsdinstall: record DHCP config after obtaining lease.
MFC r322374: bsdinstall: record DHCP config after obtaining lease
Sat, Sep 9, 12:33 AM
emaste accepted D12272: Fix information leak in geli(8) integrity mode.
Sat, Sep 9, 12:30 AM

Fri, Sep 8

emaste committed rS323333: MFC r322677: pw usermod: handle empty secondary group lists (-G '').
MFC r322677: pw usermod: handle empty secondary group lists (-G '')
Fri, Sep 8, 9:16 PM
emaste committed rS323332: MFC r322678: pw useradd: Validate the user name before creating the entry.
MFC r322678: pw useradd: Validate the user name before creating the entry
Fri, Sep 8, 9:02 PM
emaste committed rS323331: MFC r323002: zfs: do not advertise unsupported hash algorithms.
MFC r323002: zfs: do not advertise unsupported hash algorithms
Fri, Sep 8, 8:42 PM

Wed, Sep 6

emaste committed rS323205: MFC r323022: arge: correct bzero sizeof (pointed-to object, not pointer).
MFC r323022: arge: correct bzero sizeof (pointed-to object, not pointer)
Wed, Sep 6, 2:08 AM
emaste committed rS323204: MFC r323011: usb: Add external "Intenso Memory" disk quirk.
MFC r323011: usb: Add external "Intenso Memory" disk quirk
Wed, Sep 6, 2:07 AM
emaste committed rS323203: MFC r323010: hv_vss.4: Fix spelling of 'responsibility'.
MFC r323010: hv_vss.4: Fix spelling of 'responsibility'
Wed, Sep 6, 2:05 AM
emaste committed rS323202: MFC r323040: xls_ehci: eliminate string literal warning.
MFC r323040: xls_ehci: eliminate string literal warning
Wed, Sep 6, 2:04 AM
emaste committed rS323201: MFC r323039: octeon_ebt3000_cf: eliminate string literal warning.
MFC r323039: octeon_ebt3000_cf: eliminate string literal warning
Wed, Sep 6, 2:03 AM
emaste accepted D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.
Wed, Sep 6, 1:41 AM

Tue, Sep 5

emaste added a comment to D12221: Skylake server core PMC support for hwpmc(4).

Without comparing entries against documentation this looks reasonable to my eye.

Tue, Sep 5, 8:17 PM
emaste created D12231: make-memstick.sh: use UFSv2.
Tue, Sep 5, 6:35 PM
emaste committed rS323178: make-memstick.sh: use 'set -e' to abort if any step fails.
make-memstick.sh: use 'set -e' to abort if any step fails
Tue, Sep 5, 12:58 PM
emaste closed D12195: make-memstick.sh: use 'set -e' to abort if any step fails.
Tue, Sep 5, 12:58 PM
emaste committed rS323168: MFC r322798: newvers.sh: accommodate `git worktree`.
MFC r322798: newvers.sh: accommodate `git worktree`
Tue, Sep 5, 12:47 AM
emaste committed rS323167: MFC r308789 (glebius):.
MFC r308789 (glebius):
Tue, Sep 5, 12:44 AM

Mon, Sep 4

emaste added inline comments to D12227: Fixup compilation and enable dtrace support for mips64.
Mon, Sep 4, 10:45 PM
emaste committed rS323165: mkisoimages.sh: remove obsolete x$var convention.
mkisoimages.sh: remove obsolete x$var convention
Mon, Sep 4, 10:37 PM

Fri, Sep 1

emaste accepted D12206: Add efimedia attribute for all GPT partitions..

Sounds good to me

Fri, Sep 1, 5:45 PM
emaste added inline comments to D12205: Use IOAPIC PCI rid as the interrupt TLP source id for DMAR interrupt remapping..
Fri, Sep 1, 2:38 PM

Thu, Aug 31

emaste updated the diff for D12195: make-memstick.sh: use 'set -e' to abort if any step fails.

Apply to powerpc as well.

Thu, Aug 31, 11:59 PM
emaste created D12195: make-memstick.sh: use 'set -e' to abort if any step fails.
Thu, Aug 31, 11:20 PM
emaste committed rS323044: MFC r321293: date: avoid crash on invalid time.
MFC r321293: date: avoid crash on invalid time
Thu, Aug 31, 2:37 AM

Wed, Aug 30

emaste committed rS323040: xls_ehci: eliminate 'format string is not a string literal' warning.
xls_ehci: eliminate 'format string is not a string literal' warning
Wed, Aug 30, 10:58 PM
emaste committed rS323039: octeon_ebt3000_cf: eliminate 'format string is not a string literal' warning.
octeon_ebt3000_cf: eliminate 'format string is not a string literal' warning
Wed, Aug 30, 10:54 PM
emaste added a comment to D12171: map mips TARGET_ARCH to triples.

Oops, this was committed in two parts to my local tree and this diff represents only the second change. The file in FreeBSD svn currently has only ${TARGET_ARCH:C/amd64/x86_64/}

Wed, Aug 30, 8:27 PM
emaste committed rP448999: audio/openal-soft: set LLD_UNSAFE.
audio/openal-soft: set LLD_UNSAFE
Wed, Aug 30, 7:40 PM