Feed Advanced Search

Today

emaste added a comment to D13122: aw_nmi: add support for a83t's r_intc.

After @manu's review, you have my approval.

Sun, Nov 19, 1:06 AM
emaste committed rS325989: MFC r325444: ANSIfy sys/kern/md4c.c.
MFC r325444: ANSIfy sys/kern/md4c.c
Sun, Nov 19, 12:32 AM
emaste committed rS325988: ANSIfy sys/libkern.
ANSIfy sys/libkern
Sun, Nov 19, 12:31 AM

Fri, Nov 17

emaste added a comment to D12650: Add EFI RTC support.

I believe that the patch was already tested on arm64, IMO amd64 would be much more interesting.

Fri, Nov 17, 9:24 PM
emaste added a comment to D12650: Add EFI RTC support.

Attempting to set the time on OD1000:

root@od1000:~ # date 1711171600
timeout stopping cpus
panic: invalid fpcurthread
cpuid = 2
time = 1510952400
KDB: stack backtrace:
db_trace_self() at db_trace_self_wrapper+0x28
         pc = 0xffff00000060d8f8  lr = 0xffff000000086eec
         sp = 0xffff0000e64e93e0  fp = 0xffff0000e64e95f0
Fri, Nov 17, 9:22 PM
emaste added a comment to D10486: Bug 218860 - libelf doesn't reload section headers after update with ELF_C_WRITE.
In D10486#273287, @cem wrote:

@emaste , @kaiw , any objection to committing this change?

Fri, Nov 17, 8:15 PM
emaste added a comment to D12650: Add EFI RTC support.

I'm building a new kernel to test this on a SoftIron OverDrive 1000 now.

Fri, Nov 17, 3:58 PM
emaste committed rS325916: MFC r325683: vnic: apply BPF tap before passing packet to hardware.
MFC r325683: vnic: apply BPF tap before passing packet to hardware
Fri, Nov 17, 12:38 AM

Thu, Nov 16

emaste added a comment to D13114: Add sanity check for CK_CLYGRP.

Ok, no objection to this patch.

Thu, Nov 16, 6:38 PM
emaste added a comment to D12765: newfs: warn if newer than kernel.

Because we use the new newfs with the old kernel in the release process

Thu, Nov 16, 6:25 PM
emaste added inline comments to D13114: Add sanity check for CK_CLYGRP.
Thu, Nov 16, 3:51 PM
emaste added inline comments to D13114: Add sanity check for CK_CLYGRP.
Thu, Nov 16, 1:05 PM
emaste added a comment to D13114: Add sanity check for CK_CLYGRP.

I think this change is good (modulo kib's comment).

Thu, Nov 16, 12:50 PM
emaste added a comment to D12765: newfs: warn if newer than kernel.
In D12765#272641, @imp wrote:

Won't this trigger every single time we build a snapshot with a kernel that doesn't match?

Thu, Nov 16, 12:43 PM

Wed, Nov 15

emaste closed D12765: newfs: warn if newer than kernel.
Wed, Nov 15, 6:40 PM
emaste committed rS325860: newfs: warn if newer than kernel.
newfs: warn if newer than kernel
Wed, Nov 15, 6:40 PM
emaste closed D13103: Sort pkgbase mtree metadata, for reproducible builds.
Wed, Nov 15, 6:03 PM
emaste committed rS325859: Sort pkgbase mtree metadata, for reproducible builds.
Sort pkgbase mtree metadata, for reproducible builds
Wed, Nov 15, 6:03 PM
emaste updated the diff for D13103: Sort pkgbase mtree metadata, for reproducible builds.
  • fix stray ; \
  • add explicit LC_COLLATE=C per @bapt suggestion
Wed, Nov 15, 2:46 PM
emaste added a comment to D13103: Sort pkgbase mtree metadata, for reproducible builds.
In D13103#272413, @bapt wrote:

You should enforce a locale for sort to produce a consistent output! either LC_COLLATE=C or anything (imho the best is LC_COLLATE=C)

Wed, Nov 15, 2:42 PM
emaste updated subscribers of D13103: Sort pkgbase mtree metadata, for reproducible builds.
Wed, Nov 15, 2:01 PM
emaste created D13103: Sort pkgbase mtree metadata, for reproducible builds.
Wed, Nov 15, 1:57 PM

Tue, Nov 14

emaste added a comment to D13018: vmtotal: extend counters to match reality.

I would put the 64-bit fields first, and make the whole struct 8-byte aligned, but I'll defer to any suggestion kib might offer.

Tue, Nov 14, 7:57 PM
emaste committed rS325825: disallow clock_settime too far in the future to avoid panic.
disallow clock_settime too far in the future to avoid panic
Tue, Nov 14, 6:18 PM
emaste accepted D12631: patch(1): don't assume a match if we run out of context to check.

As long as the ports tree is good let's get this back in.

Tue, Nov 14, 5:31 PM
emaste committed rS325811: vnic: report that the driver supports multicast.
vnic: report that the driver supports multicast
Tue, Nov 14, 4:31 PM
emaste added a comment to D13018: vmtotal: extend counters to match reality.
In D13018#272087, @kib wrote:

The problem which I envision is that the uint64_t type has 8-bytes alignment on amd64, but only 4-bytes on i386.

Tue, Nov 14, 3:41 PM

Mon, Nov 13

emaste added inline comments to D13018: vmtotal: extend counters to match reality.
Mon, Nov 13, 11:57 PM
emaste added a comment to D12912: Don't fail the build due to clang integer constant range warnings.

How many warnings of this type does the build produce?

Mon, Nov 13, 6:56 PM

Sun, Nov 12

emaste committed rS325744: boot1: also check for NULL device.
boot1: also check for NULL device
Sun, Nov 12, 5:16 PM

Fri, Nov 10

emaste committed rS325683: vnic: apply BPF tap before passing packet to hardware.
vnic: apply BPF tap before passing packet to hardware
Fri, Nov 10, 10:17 PM
emaste closed D13038: Add check to avoid freeing null pointer in boot1.c.
Fri, Nov 10, 9:27 PM
emaste committed rS325681: boot1: avoid using NULL device path.
boot1: avoid using NULL device path
Fri, Nov 10, 9:27 PM
emaste added inline comments to D13038: Add check to avoid freeing null pointer in boot1.c.
Fri, Nov 10, 8:54 PM
emaste added a comment to D13038: Add check to avoid freeing null pointer in boot1.c.

Also for the commit message -- it's not freeing that we need to avoid, it's using the null pointer at all. free(NULL) is actually fine. it's the printf/setenv that we can't pass a NULL pointer to.

Fri, Nov 10, 8:44 PM
emaste accepted D13038: Add check to avoid freeing null pointer in boot1.c.
Fri, Nov 10, 8:34 PM
emaste committed rS325664: Strip EOL whitespace in usr.sbin/{jail,jexec}.
Strip EOL whitespace in usr.sbin/{jail,jexec}
Fri, Nov 10, 2:53 PM
emaste updated the diff for D13028: vnic: correct and simplify SIOCSIFFLAGS ioctl.

undo accidental if_getdrvflags breakage

Fri, Nov 10, 2:40 PM
emaste created D13028: vnic: correct and simplify SIOCSIFFLAGS ioctl.
Fri, Nov 10, 2:36 PM

Thu, Nov 9

emaste updated subscribers of D13015: Axe xlint..
In D13015#270388, @kib wrote:

Aren't they automatically re-generated by somebody else ? I did found them by grepping, and decided not to update because they are not human-editable. Am I wrong ?

Thu, Nov 9, 2:46 PM
emaste accepted D12985: bhyve: don't try to capsicumise after failed open.
Thu, Nov 9, 2:41 PM ยท bhyve
emaste accepted D13015: Axe xlint..

There are also adjustments to make in targets/pseudo/hosttools/Makefile.depend.host and targets/pseudo/userland/Makefile.depend

Thu, Nov 9, 2:27 PM

Wed, Nov 8

emaste committed rS325523: MFC r325420: lld: accept EINVAL to indicate posix_fallocate is unsupported.
MFC r325420: lld: accept EINVAL to indicate posix_fallocate is unsupported
Wed, Nov 8, 12:45 AM

Sun, Nov 5

emaste committed rS325444: ANSIfy sys/kern/md4c.c.
ANSIfy sys/kern/md4c.c
Sun, Nov 5, 7:50 PM
emaste committed rS325422: posix_fallocate.2: add an EINVAL errno case.
posix_fallocate.2: add an EINVAL errno case
Sun, Nov 5, 3:02 AM
emaste committed rS325420: lld: accept EINVAL to indicate posix_fallocate is unsupported.
lld: accept EINVAL to indicate posix_fallocate is unsupported
Sun, Nov 5, 12:52 AM

Fri, Nov 3

emaste accepted D12925: Only build the libmagic build-tools if MK_FILE != no.

LGTM

Fri, Nov 3, 11:12 PM

Thu, Nov 2

emaste accepted D12910: Remove -fuse-ld= when creating _LDFLAGS from LDFLAGS.
Thu, Nov 2, 2:18 PM
emaste accepted D11925: Export std::get_new_handler() from libcxxrt.so.
Thu, Nov 2, 1:46 PM

Wed, Nov 1

emaste added a comment to D12840: Add option UNIFIED_OBJDIR, on by default, which moves the default build OBJDIR..

Should we make a reference to WITHOUT_UNIFIED_OBJDIR being a transition aid that will be removed later on? (for 12.0)?

Wed, Nov 1, 12:22 AM

Tue, Oct 31

emaste added a comment to D12631: patch(1): don't assume a match if we run out of context to check.

Or even a small example just in this Phabricator review that demonstrates the issue?

Tue, Oct 31, 2:57 PM
emaste accepted D12631: patch(1): don't assume a match if we run out of context to check.

Approved. Could we add a simple test case too?

Tue, Oct 31, 2:40 PM

Mon, Oct 30

emaste added a comment to D12817: Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler..

I think so - I'm not suggesting we add GPL_DTC_BOOTSTRAP since it seems it would be more complexity than is warranted, but just checking that the reason we don't have this same problem with Clang is because it's split out into separate enables for the boostrap and installed cases.

Mon, Oct 30, 6:26 PM

Sun, Oct 29

emaste added a comment to D12817: Follow-up r320149: Enable GPL_DTC if we're using GCC as the cross-compiler..

Is it the case that the other C++11 option in this block (CLANG) works only because it is split into CLANG and CLANG_BOOTSTRAP? It would otherwise have the same problem, yes?

Sun, Oct 29, 2:02 PM

Fri, Oct 27

emaste committed rS325047: dma: fix use-after-free.
dma: fix use-after-free
Fri, Oct 27, 8:21 PM
emaste added a comment to D12717: Import libipt.

Oops, pasted in the wrong review.

Fri, Oct 27, 6:55 PM
emaste updated subscribers of D12717: Import libipt.

I agree with @kib that this should be a private lib

Fri, Oct 27, 6:54 PM
emaste committed rS325042: libdtrace: replace "DOODAD" with more descriptive string.
libdtrace: replace "DOODAD" with more descriptive string
Fri, Oct 27, 4:23 PM

Tue, Oct 24

emaste added a comment to D12718: add libpmcstat.

It is moved around, so I am not sure what is your point.

Tue, Oct 24, 2:26 PM
emaste added a comment to D12718: add libpmcstat.

This stuff would greatly benefit from more cleanup

Tue, Oct 24, 1:47 PM
emaste committed rS324942: MFC r324683: write.2: correct maximum nbytes size for EINVAL error.
MFC r324683: write.2: correct maximum nbytes size for EINVAL error
Tue, Oct 24, 12:32 AM

Mon, Oct 23

emaste committed rS324936: uefi.8: mention use on (32-bit) arm.
uefi.8: mention use on (32-bit) arm
Mon, Oct 23, 8:32 PM
emaste created D12765: newfs: warn if newer than kernel.
Mon, Oct 23, 12:44 AM

Oct 20 2017

emaste committed rS324782: MFC r324595: ANSIfy vm_kern.c.
MFC r324595: ANSIfy vm_kern.c
Oct 20 2017, 12:38 AM
emaste committed rS324781: MFC r324595: ANSIfy vm_kern.c.
MFC r324595: ANSIfy vm_kern.c
Oct 20 2017, 12:36 AM
emaste committed rS324779: MFC r324594: truss: mention 'H' in usage.
MFC r324594: truss: mention 'H' in usage
Oct 20 2017, 12:34 AM
emaste committed rS324777: MFC r324594: truss: mention 'H' in usage.
MFC r324594: truss: mention 'H' in usage
Oct 20 2017, 12:29 AM

Oct 19 2017

emaste accepted D12405: Diff showing stock tcpdump 4.9.2 vs FreeBSD 4.9.2.
Oct 19 2017, 9:31 PM
emaste added a comment to D12404: Update tcpdump to 4.9.2..

@gordon and I discussed this at vBSDcon and he uploaded a diff between upstream tcpdump 4.9.2 and the merged changes, in D12405. Although it's missing context it's good to review to see if the expected FreeBSD changes are present.

Oct 19 2017, 9:17 PM
emaste added a comment to D12639: Enable VIMAGE by default.

Can someone share the benchmarks?

Oct 19 2017, 6:57 PM
emaste accepted D12639: Enable VIMAGE by default.

I think it's important that we get some experience with it enabled in GENERIC so that we can make an informed decision sufficiently far in advance of 12.0. The benchmarks we do have so far show a rather small regression, and downstream FreeBSD consumers who have a need for the maximum possible performance can still disable it.

Oct 19 2017, 5:30 PM
emaste committed rS324758: psci: change bootverbose string to 'PSCI 0.2 compatible'.
psci: change bootverbose string to 'PSCI 0.2 compatible'
Oct 19 2017, 4:40 PM
emaste added inline comments to D12717: Import libipt.
Oct 19 2017, 2:11 PM
emaste committed rS324753: msdosfs: fix build with MSDOSFS_DEBUG.
msdosfs: fix build with MSDOSFS_DEBUG
Oct 19 2017, 12:55 PM

Oct 18 2017

emaste added inline comments to D12717: Import libipt.
Oct 18 2017, 6:20 PM
emaste added a reviewer for D12718: add libpmcstat: kib.
Oct 18 2017, 1:30 PM
emaste added inline comments to D12717: Import libipt.
Oct 18 2017, 1:12 PM

Oct 17 2017

emaste committed rS324707: embed_mfs: add error handling, usage.
embed_mfs: add error handling, usage
Oct 17 2017, 9:13 PM
emaste committed rS324703: loader.mk: clean md.o even if MD_IMAGE_SIZE not defined.
loader.mk: clean md.o even if MD_IMAGE_SIZE not defined
Oct 17 2017, 7:11 PM
emaste committed rS324700: loader: initialize dv_cleanup in md.c to eliminate clang warning.
loader: initialize dv_cleanup in md.c to eliminate clang warning
Oct 17 2017, 6:00 PM
emaste accepted D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 17 2017, 5:21 PM
emaste added a comment to D12693: Update wpa_supplicant/hostapd for 2017-01 vulnerability release..

I believe this is the expected set of patches. I noticed one minor difference between the Debian patch set I inspected and this (tk_to_set vs tk_already_set) which is probably due to targeting different versions?

Oct 17 2017, 1:15 PM
emaste committed rS324684: Remove lib/libstand again, accidentally readded in r324683.
Remove lib/libstand again, accidentally readded in r324683
Oct 17 2017, 2:54 AM
emaste committed rS324683: write.2: correct maximum nbytes size for EINVAL error.
write.2: correct maximum nbytes size for EINVAL error
Oct 17 2017, 2:52 AM
emaste committed rS324679: MFC r324509: sysctl.9: document CTLFLAG_CAPRD and CTLFLAG_CAPWR.
MFC r324509: sysctl.9: document CTLFLAG_CAPRD and CTLFLAG_CAPWR
Oct 17 2017, 12:26 AM

Oct 16 2017

emaste added inline comments to D12574: Mark kgmon(8) as obsolete.
Oct 16 2017, 1:15 AM

Oct 14 2017

emaste added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Oct 14 2017, 2:27 AM

Oct 13 2017

emaste added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Oct 13 2017, 9:54 PM
emaste added a comment to D8895: Rearrange vcs detection..

I think this idea is good - we should look for any vcs at the src topdir first, followed by any vcs at ../, etc. $topdir/../.git should not take precedence over $topdir/.svn e.g.

Oct 13 2017, 8:54 PM
emaste added inline comments to D12315: Update bsdinstall/zfsboot to use newfs_msdos instead of an image file.
Oct 13 2017, 8:38 PM
emaste updated subscribers of D12404: Update tcpdump to 4.9.2..
Oct 13 2017, 8:26 PM
emaste committed rS324605: clean up remnants of removed GPL software.
clean up remnants of removed GPL software
Oct 13 2017, 6:30 PM
emaste committed rS324604: Remove additional groff leftovers (r319664).
Remove additional groff leftovers (r319664)
Oct 13 2017, 6:23 PM
emaste committed rS324603: ObsoleteFiles.inc: correct year on libstand removal.
ObsoleteFiles.inc: correct year on libstand removal
Oct 13 2017, 5:15 PM
emaste committed rS324595: ANSIfy vm_kern.c.
ANSIfy vm_kern.c
Oct 13 2017, 1:53 PM
emaste committed rS324594: truss: mention 'H' in usage.
truss: mention 'H' in usage
Oct 13 2017, 1:48 PM
emaste updated subscribers of D12654: Support for Kabylake PMC.
Oct 13 2017, 12:56 PM

Oct 12 2017

emaste committed rS324565: regen freebsd32_sysent.c after r324564 (freebsd32_posix_fallocate).
regen freebsd32_sysent.c after r324564 (freebsd32_posix_fallocate)
Oct 12 2017, 6:31 PM
emaste committed rS324564: allow posix_fallocate in 32-bit compat capability mode.
allow posix_fallocate in 32-bit compat capability mode
Oct 12 2017, 6:31 PM
emaste committed rS324561: regen init_sysent.c r324560.
regen init_sysent.c r324560
Oct 12 2017, 3:48 PM