Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

D20978: Remove an old warning from UPDATING. is now accepted and ready to land.

Seems reasonable to me: this is now completely irrelevant for x86, and yet completely insufficient for the trouble that will be encountered migrating e.g. MIPS from GCC to Clang

Wed, Jul 17, 6:24 PM

Mon, Jul 15

emaste added a comment to D20962: pkgbase: move man pages from runtime-manual to runtime.

Sounds good.

Mon, Jul 15, 3:50 PM

Thu, Jul 4

emaste committed rS349751: Update Linux compat version to 2.6.36.
Update Linux compat version to 2.6.36
Thu, Jul 4, 8:42 PM
emaste committed rS349749: MFC r349239, r349241: update vm_map_protect.9.
MFC r349239, r349241: update vm_map_protect.9
Thu, Jul 4, 7:53 PM
emaste added a comment to D20757: Bump Linux version to 3.2.0.
fanotify_init(2)           2.6.37
fanotify_mark(2)           2.6.37
Thu, Jul 4, 6:53 PM
emaste added a comment to D20757: Bump Linux version to 3.2.0.
prlimit64(2)               2.6.36

We have those.

Thu, Jul 4, 6:44 PM
D20852: elfcopy: Clear errors after fetching the shstrtab index. is now accepted and ready to land.
Thu, Jul 4, 2:59 PM
emaste created D20853: bxe: prefer C99 bool to boolean_t.
Thu, Jul 4, 2:58 PM
emaste added a comment to D20757: Bump Linux version to 3.2.0.

I see the following after 2.6.32 and up to and including 3.2, with uninteresting ports (e.g. m68k) excluded:

recvmmsg(2)                2.6.33
prlimit64(2)               2.6.36
fanotify_init(2)           2.6.37
fanotify_mark(2)           2.6.37
clock_adjtime(2)           2.6.39
name_to_handle_at(2)       2.6.39
open_by_handle_at(2)       2.6.39
syncfs(2)                  2.6.39
Thu, Jul 4, 1:25 PM
emaste added a comment to D13028: vnic: correct and simplify SIOCSIFFLAGS ioctl.

rebase

Thu, Jul 4, 12:58 PM

Wed, Jul 3

emaste committed rS349697: correct pmap_ts_referenced return type.
correct pmap_ts_referenced return type
Wed, Jul 3, 8:00 PM
emaste committed rS349658: MFC r349268: nandsim: correct test to avoid out-of-bounds access.
MFC r349268: nandsim: correct test to avoid out-of-bounds access
Wed, Jul 3, 5:35 PM
emaste committed rS349657: MFC r349268: nandsim: correct test to avoid out-of-bounds access.
MFC r349268: nandsim: correct test to avoid out-of-bounds access
Wed, Jul 3, 5:34 PM
emaste committed rS349624: MFC r349619: libc: correct iconv buffer overflow.
MFC r349619: libc: correct iconv buffer overflow
Wed, Jul 3, 12:03 AM
emaste committed rS349622: MFC r349619: libc: correct iconv buffer overflow.
MFC r349619: libc: correct iconv buffer overflow
Wed, Jul 3, 12:01 AM

Tue, Jul 2

emaste committed rS349619: libc: correct iconv buffer overflow.
libc: correct iconv buffer overflow
Tue, Jul 2, 11:56 PM
emaste committed rS349602: if_muge: set IFCAP_VLAN_MTU to maintain 1500 MTU with vlan use.
if_muge: set IFCAP_VLAN_MTU to maintain 1500 MTU with vlan use
Tue, Jul 2, 4:44 PM
emaste accepted D20795: Control implicit PROT_MAX() using proccontrol(1) and the FreeBSD note feature bit..
Tue, Jul 2, 3:08 PM
emaste added a reviewer for D20835: aarch64: enable tagged pointers (TBI — Top Byte Ignored): andrew.
Tue, Jul 2, 1:20 PM · arm64

Sat, Jun 29

emaste committed rS349545: Tag ELF Tool Chain r3769.
Tag ELF Tool Chain r3769
Sat, Jun 29, 3:30 PM
emaste committed rS349544: Import ELF Tool Chain snapshot at r3769.
Import ELF Tool Chain snapshot at r3769
Sat, Jun 29, 3:27 PM

Fri, Jun 28

emaste added a comment to D20795: Control implicit PROT_MAX() using proccontrol(1) and the FreeBSD note feature bit..

Overall looks reasonable, a few small alpha ordering nits.

Fri, Jun 28, 6:28 PM

Thu, Jun 27

emaste committed rS349469: Expose the kernel's build-ID through `uname -b`.
Expose the kernel's build-ID through `uname -b`
Thu, Jun 27, 8:35 PM
Herald added a reviewer for D20511: Expose build-ID through `uname -b`: manpages.
Thu, Jun 27, 8:35 PM
emaste added a comment to D20511: Expose build-ID through `uname -b`.

@imp asked on IRC what would happen if run on a kernel without the kern.build_id sysctl - it would report:

volta% usr.bin/uname/obj/uname -b
uname: sysctlbyname: No such file or directory
Thu, Jun 27, 8:29 PM
emaste updated subscribers of rS348611: Expose the kernel's build-ID through sysctl.

@imp asked on IRC what would happen if run on a kernel without the kern.build_id sysctl - it would report:

volta% usr.bin/uname/obj/uname -b
uname: sysctlbyname: No such file or directory
Thu, Jun 27, 8:28 PM
emaste added inline comments to D20511: Expose build-ID through `uname -b`.
Thu, Jun 27, 8:24 PM
emaste added a comment to D20772: Provide protection against starvation of the ll/sc loops when accessing userpace..

FWIW I have sent links to this change to OpenBSD, NetBSD and DragonFly BSD developers.

Thu, Jun 27, 7:35 PM
emaste updated subscribers of D20780: Add support for getting early entropy from the UEFI RNG protocol.
Thu, Jun 27, 3:02 PM · security, arm64
emaste committed rS349453: picobsd: also exclude .git where we exclude .svn today.
picobsd: also exclude .git where we exclude .svn today
Thu, Jun 27, 1:32 PM

Wed, Jun 26

emaste added a comment to D20755: Emulate the TEST instruction with opcode F7 /0..

@rgrimes would you help coordinate with re@?

Wed, Jun 26, 7:28 PM
emaste added a comment to D20772: Provide protection against starvation of the ll/sc loops when accessing userpace..

We should perhaps use "Reported by:" instead of "Security:" for the xen link

Wed, Jun 26, 5:54 PM
emaste added a comment to D20767: readelf: Add support for RISC-V specific e_flags.

Ideally we'd commit changes upstream and then import a new version with a latency of several days or a week or so but that process seems to be somewhat slow right now so I'm fine with just committing to FreeBSD and then having @markj or me work on upstreaming changes in batches.

Wed, Jun 26, 5:02 PM
D20768: libelftc: add RISC-V bfd targets is now accepted and ready to land.
Wed, Jun 26, 1:34 AM

Tue, Jun 25

D20544: strip: Provide a size hint when creating the string table. is now accepted and ready to land.
Tue, Jun 25, 9:26 PM
D20760: libelftc: Micro-optimize strtab insertion. is now accepted and ready to land.
Tue, Jun 25, 8:00 PM
D20759: Avoid .debug_str lookups. is now accepted and ready to land.
Tue, Jun 25, 7:58 PM
emaste added a comment to D20759: Avoid .debug_str lookups..

Presumably _dwarf_strtab_init is guaranteed to be called?

Tue, Jun 25, 7:45 PM
emaste committed rS349385: bhyve: avoid theoretical stack buffer overflow from integer overflow.
bhyve: avoid theoretical stack buffer overflow from integer overflow
Tue, Jun 25, 7:06 PM
emaste added a comment to D20687: Fix execution of linux binaries with glibc>=2.24.

Also is it the case that /bin/echo 1 1 1 1 1... consistently fails with some number of 1s and runs successfully with other cases? Like 1 1 1 works, 1 1 1 1 fails, 1 1 1 1 1 works?

Tue, Jun 25, 3:07 PM
emaste added a comment to D20687: Fix execution of linux binaries with glibc>=2.24.

Do you have more details about working/non-working versions? I.e., what glibc version works?

Tue, Jun 25, 3:05 PM
emaste added a comment to D20757: Bump Linux version to 3.2.0.

LGTM once dependencies are resolved, of course.

Tue, Jun 25, 2:54 PM
D20757: Bump Linux version to 3.2.0 is now accepted and ready to land.

Do we have a list of syscalls/interfaces by kernel version anywhere?

Tue, Jun 25, 2:53 PM
D20756: fix missing powerpc64 in _LLVM_TARGET_FILT is now accepted and ready to land.
Tue, Jun 25, 2:40 PM
emaste added a comment to D20462: newvers: append commit count to uname version string.

Note that Git can internally store a generation count (tree height) and if that's a suitable proxy for us that can be instantaneous to calculate, however within a given branch a given generation count does not necessarily identify a unique commit.

Tue, Jun 25, 1:03 PM

Mon, Jun 24

emaste committed rS349333: vtfontcvt: improve .bdf validation.
vtfontcvt: improve .bdf validation
Mon, Jun 24, 5:25 PM
emaste added inline comments to D20745: Remove NAND and NANDFS support.
Mon, Jun 24, 4:48 PM

Fri, Jun 21

emaste committed rS349268: nandsim: correct test to avoid out-of-bounds access.
nandsim: correct test to avoid out-of-bounds access
Fri, Jun 21, 1:42 PM
D20702: libelftc: Use size_t for string table size hints. is now accepted and ready to land.
Fri, Jun 21, 1:13 PM

Thu, Jun 20

D20713: Add PROT_MAX to the HISTORY section. is now accepted and ready to land.

LGTM

Thu, Jun 20, 9:46 PM
emaste committed rS349241: Clarify vm_map_protect max_protection downgrade.
Clarify vm_map_protect max_protection downgrade
Thu, Jun 20, 6:30 PM
emaste added inline comments to D20709: Clarify that vm_map_protect cannot upgrade max_protection.
Thu, Jun 20, 6:23 PM
emaste added inline comments to D20709: Clarify that vm_map_protect cannot upgrade max_protection.
Thu, Jun 20, 6:20 PM
Herald added a reviewer for D20709: Clarify that vm_map_protect cannot upgrade max_protection: manpages.
Thu, Jun 20, 6:19 PM
emaste committed rS349239: Clarify that vm_map_protect cannot upgrade max_protection.
Clarify that vm_map_protect cannot upgrade max_protection
Thu, Jun 20, 6:19 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

From another NetBSD commit:

Thu, Jun 20, 4:32 PM
emaste accepted D18880: Extend mmap/mprotect API to specify the max page protections..
Thu, Jun 20, 1:02 PM
emaste created D20709: Clarify that vm_map_protect cannot upgrade max_protection.
Thu, Jun 20, 1:01 PM

Wed, Jun 19

emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

I think it's also something we can easily add later, just swipe another bit from the top half.

Wed, Jun 19, 9:30 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

One last thing before I commit this version. I'm trying to decide if I care about being able to detect PROT_MAX(PROT_NONE) and mostly leaning towards "no, use MAP_GUARD instead". Any alternative views?

Wed, Jun 19, 8:59 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

It wouldn't be too hard to implement that instead if it seems like the right thing to do. It would do what I need for CHERI. Unfortunately, it lacks a way to downgrade max_prot later in mprotect(). We don't have any examples of the latter, but it does seem like something that could be useful in a JIT that avoids flipping back and forth between W and X.

Wed, Jun 19, 8:49 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

Interesting, NetBSD has a related change from 2017: https://github.com/NetBSD/src/commit/6508f5143a1028fc68b4de2151c3a33f65eece53
They list "extra" perms that may be added later rather than the full list.

Wed, Jun 19, 8:30 PM
emaste added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Yea, that's recent to reuse boot1's makefile for gptboot, but have the FAT stuff not done. It's not supposed to be a user controlled knob. If you want *THAT* then you could add a MK_LOADER_EFIFAT_BLOBS and have it default to NO.

Wed, Jun 19, 5:47 PM
emaste added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Are they already unhooked from install?

Wed, Jun 19, 5:06 PM
emaste added a comment to D20562: The efifat files are no longer used: remove the code to build them..

I'm not sure it's worth moving them, but I can commit the OptionalObsoleteFiles.inc and ObsoleteFiles.inc changes if you think that makes sense.

Wed, Jun 19, 5:01 PM
emaste committed rS349193: MFC r347228: makesyscalls: use @generated tag in generated files.
MFC r347228: makesyscalls: use @generated tag in generated files
Wed, Jun 19, 2:58 PM
emaste added a comment to D20562: The efifat files are no longer used: remove the code to build them..

Is there a way to build the efi fs this without root? I build images in a Jenkins instance to test FreeBSD/arm64 on various simulators and would prefer to not need to give the Jenkins user sudo access.

There's a review from July 2018 at D16438 to add msdos support to makefs, but it seems to have stalled. But otherwise, root access will be needed.

Wed, Jun 19, 2:41 PM
D20689: Add support for PTRACE_O_TRACEEXIT to linuxulator ptrace(2) is now accepted and ready to land.

LGTM

Wed, Jun 19, 2:35 PM
emaste added a comment to D20693: Fix bogomips calculation.

Would be good to put some reference to determining the appropriate bogomips value, either as a comment in the code if there's something reasonable you can link to, or in the commit message if you just found this case by observation (e.g., something like "on the same hardware I noticed that Linux's real bogomips value was twice that that we reported" if that's the case).

Wed, Jun 19, 2:30 PM
D20690: Silently ignore FS_IOC_FIEMAP is now accepted and ready to land.

Minor point, I wouldn't call this "silently ignored" - the console message will be gone but we still return error, except a different error.

Wed, Jun 19, 2:21 PM
emaste added a comment to D20642: efinet: Defer exclusively opening the network handles.

Mentor approval for commit.

Wed, Jun 19, 2:16 PM
D20692: Fix prlimit64(2) with pid == 0 is now accepted and ready to land.

LGTM

Wed, Jun 19, 2:14 PM
emaste added inline comments to D20644: MFC 348757: nvdimm: Provide nvdimm location information.
Wed, Jun 19, 1:53 PM
emaste added a comment to D18038: Capsicumize strings.
In D18038#446790, @reg wrote:

Fails with WITHOUT_CAPSICUM...

Wed, Jun 19, 1:48 PM
emaste committed rS349191: vtfontcvt: whitespace and other cleanup.
vtfontcvt: whitespace and other cleanup
Wed, Jun 19, 1:33 PM
emaste committed rS349189: vtfontcvt: whitespace and other cleanup.
vtfontcvt: whitespace and other cleanup
Wed, Jun 19, 1:19 PM

Tue, Jun 18

emaste added a comment to D20127: Restore x18 in efi_arch_leave.

Related links courtesy of Ed Vielmetti:
https://bugzilla.tianocore.org/show_bug.cgi?id=625
https://github.com/tianocore/edk2/commit/6d73863b5464f382af2a17b2c2ec1abc550d0af5

Tue, Jun 18, 7:58 PM

Jun 18 2019

emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

With @markj's KASSERT change the panic at startup is fixed and now the existing mmap_test tests pass (with and without imply_prot_max).

Jun 18 2019, 4:33 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

Testing in my wipbsd branch worked on Cirrus-CI for the basic QEMU smoke test but failed on packet.net with the full system:

Jun 18 2019, 4:12 PM
emaste committed rS349170: Remove sys/capability.h for the third time.
Remove sys/capability.h for the third time
Jun 18 2019, 2:14 PM

Jun 16 2019

emaste committed rS349111: vtfontcvt: correct typo in hex parsing update.
vtfontcvt: correct typo in hex parsing update
Jun 16 2019, 3:14 PM
emaste committed rS349108: vtfontcvt: improve .bdf validation.
vtfontcvt: improve .bdf validation
Jun 16 2019, 1:52 PM
emaste committed rS349107: vtfontcvt: improve .bdf verification.
vtfontcvt: improve .bdf verification
Jun 16 2019, 1:35 PM
emaste committed rS349106: allow vt(4) fonts to be built from .bdf files.
allow vt(4) fonts to be built from .bdf files
Jun 16 2019, 12:44 PM
emaste committed rS349105: vtfontcvt: initialize another variable to quiet GCC warning.
vtfontcvt: initialize another variable to quiet GCC warning
Jun 16 2019, 12:26 PM
emaste added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Jun 16 2019, 12:16 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..
*** Check failed: /root/freebsd/tests/sys/vm/mmap_test.c:107: MAP_ANON with extra PROT flags succeeded
*** Check failed: /root/freebsd/tests/sys/vm/mmap_test.c:107: shm fd with garbage PROT succeeded
Jun 16 2019, 12:09 PM
emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

Some straightforward ad-hoc testing looks good.

Jun 16 2019, 11:50 AM
emaste committed rS349101: vtfontcvt: initialize bbwbytes to avoid GCC 4.2.1 uninitialized warning.
vtfontcvt: initialize bbwbytes to avoid GCC 4.2.1 uninitialized warning
Jun 16 2019, 10:43 AM
emaste added inline comments to D18880: Extend mmap/mprotect API to specify the max page protections..
Jun 16 2019, 10:01 AM
emaste committed rS349100: vtfontcvt: improve BDF and hex font parsing.
vtfontcvt: improve BDF and hex font parsing
Jun 16 2019, 9:17 AM
emaste closed D20650: vtfontcvt: improve BDF and hex font parsing.
Jun 16 2019, 9:17 AM
emaste added inline comments to D20650: vtfontcvt: improve BDF and hex font parsing.
Jun 16 2019, 9:02 AM

Jun 15 2019

emaste added a comment to D18880: Extend mmap/mprotect API to specify the max page protections..

I've imported the update into my testing tree (after encountering the boot failure on the previous version) and it works fine.

Jun 15 2019, 1:46 PM
emaste updated subscribers of D20654: Add spleen vt(4) fonts.
Jun 15 2019, 1:36 PM
emaste added a comment to D20654: Add spleen vt(4) fonts.

Spleen fonts from https://www.cambus.net/spleen-monospaced-bitmap-fonts/
Requires vtfontcvt changes from D20650

Jun 15 2019, 1:36 PM
emaste created D20654: Add spleen vt(4) fonts.
Jun 15 2019, 1:35 PM
emaste created D20653: Import spleen bitmap fonts to contrib/.
Jun 15 2019, 1:33 PM
emaste updated the diff for D20650: vtfontcvt: improve BDF and hex font parsing.

Correct typo (; instead of , in variable definition)

Jun 15 2019, 1:17 PM
emaste added a comment to D20650: vtfontcvt: improve BDF and hex font parsing.

Can use spleen font for testing.

Jun 15 2019, 12:45 PM