After @manu's review, you have my approval.
Fri, Nov 17
I believe that the patch was already tested on arm64, IMO amd64 would be much more interesting.
Attempting to set the time on OD1000:
root@od1000:~ # date 1711171600 timeout stopping cpus panic: invalid fpcurthread cpuid = 2 time = 1510952400 KDB: stack backtrace: db_trace_self() at db_trace_self_wrapper+0x28 pc = 0xffff00000060d8f8 lr = 0xffff000000086eec sp = 0xffff0000e64e93e0 fp = 0xffff0000e64e95f0
I'm building a new kernel to test this on a SoftIron OverDrive 1000 now.
Thu, Nov 16
Ok, no objection to this patch.
Because we use the new newfs with the old kernel in the release process
I think this change is good (modulo kib's comment).
Won't this trigger every single time we build a snapshot with a kernel that doesn't match?
Wed, Nov 15
- fix stray ; \
- add explicit LC_COLLATE=C per @bapt suggestion
You should enforce a locale for sort to produce a consistent output! either LC_COLLATE=C or anything (imho the best is LC_COLLATE=C)
Tue, Nov 14
I would put the 64-bit fields first, and make the whole struct 8-byte aligned, but I'll defer to any suggestion kib might offer.
As long as the ports tree is good let's get this back in.
The problem which I envision is that the uint64_t type has 8-bytes alignment on amd64, but only 4-bytes on i386.
Mon, Nov 13
How many warnings of this type does the build produce?
Sun, Nov 12
Fri, Nov 10
Also for the commit message -- it's not freeing that we need to avoid, it's using the null pointer at all. free(NULL) is actually fine. it's the printf/setenv that we can't pass a NULL pointer to.
undo accidental if_getdrvflags breakage
Thu, Nov 9
Aren't they automatically re-generated by somebody else ? I did found them by grepping, and decided not to update because they are not human-editable. Am I wrong ?
There are also adjustments to make in targets/pseudo/hosttools/Makefile.depend.host and targets/pseudo/userland/Makefile.depend
Wed, Nov 8
Sun, Nov 5
Fri, Nov 3
Thu, Nov 2
Wed, Nov 1
Should we make a reference to WITHOUT_UNIFIED_OBJDIR being a transition aid that will be removed later on? (for 12.0)?
Tue, Oct 31
Or even a small example just in this Phabricator review that demonstrates the issue?
Approved. Could we add a simple test case too?
Mon, Oct 30
I think so - I'm not suggesting we add GPL_DTC_BOOTSTRAP since it seems it would be more complexity than is warranted, but just checking that the reason we don't have this same problem with Clang is because it's split out into separate enables for the boostrap and installed cases.
Sun, Oct 29
Is it the case that the other C++11 option in this block (CLANG) works only because it is split into CLANG and CLANG_BOOTSTRAP? It would otherwise have the same problem, yes?
Fri, Oct 27
Oops, pasted in the wrong review.
I agree with @kib that this should be a private lib
Tue, Oct 24
It is moved around, so I am not sure what is your point.
This stuff would greatly benefit from more cleanup
Mon, Oct 23
Oct 20 2017
Oct 19 2017
@gordon and I discussed this at vBSDcon and he uploaded a diff between upstream tcpdump 4.9.2 and the merged changes, in D12405. Although it's missing context it's good to review to see if the expected FreeBSD changes are present.
I think it's important that we get some experience with it enabled in GENERIC so that we can make an informed decision sufficiently far in advance of 12.0. The benchmarks we do have so far show a rather small regression, and downstream FreeBSD consumers who have a need for the maximum possible performance can still disable it.
Oct 18 2017
Oct 17 2017
I believe this is the expected set of patches. I noticed one minor difference between the Debian patch set I inspected and this (tk_to_set vs tk_already_set) which is probably due to targeting different versions?
Oct 16 2017
Oct 14 2017
Oct 13 2017
I think this idea is good - we should look for any vcs at the src topdir first, followed by any vcs at ../, etc. $topdir/../.git should not take precedence over $topdir/.svn e.g.