Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

emaste accepted D25600: Avoid leaking kernel pointers from msgctl(IPC_STAT)..
Thu, Jul 9, 3:51 PM
emaste accepted D25600: Avoid leaking kernel pointers from msgctl(IPC_STAT)..

In that case I think it is reasonable to patch the leak, if only to avoid seeing the same reports again and again.

Thu, Jul 9, 2:57 PM

Wed, Jul 8

emaste added inline comments to D21997: Allow SCTP to be build as a module.
Wed, Jul 8, 11:59 PM

Sun, Jul 5

emaste accepted D25563: Use KERN_MAXPHYS..
Sun, Jul 5, 12:03 AM

Sat, Jul 4

emaste accepted D24508: Gather writes to larger chunks (MAXPHYS) instead of issuing them in sectors..
Sat, Jul 4, 3:22 PM

Fri, Jul 3

emaste committed rS362914: bc: disable -flto on powerpc64.
bc: disable -flto on powerpc64
Fri, Jul 3, 8:33 PM
emaste added inline comments to D24688: Introduce cap_net a network service for Casper..
Fri, Jul 3, 3:14 PM
emaste added inline comments to D17653: Teach newvers.sh how to get the last revision on the branch.
Fri, Jul 3, 2:53 PM
emaste added a comment to D17653: Teach newvers.sh how to get the last revision on the branch.

I think this is still useful, is there any concern of committing this to head?

Fri, Jul 3, 1:56 PM

Thu, Jul 2

emaste added inline comments to D25273: amd64 pmap: LA57 AKA 5-level paging.
Thu, Jul 2, 2:20 PM
emaste added inline comments to D25273: amd64 pmap: LA57 AKA 5-level paging.
Thu, Jul 2, 1:40 PM

Tue, Jun 30

emaste added inline comments to D23804: Update Azure release bits.
Tue, Jun 30, 2:19 PM
emaste added a comment to D25229: Allow bootstrapping localdef on non-FreeBSD systems.

approach seems reasonable to me

Tue, Jun 30, 1:06 PM
emaste added a comment to D25229: Allow bootstrapping localdef on non-FreeBSD systems.

collate.c looks like an independent bugfix you can just commit first?

Tue, Jun 30, 1:05 PM

Mon, Jun 29

emaste added a comment to D25452: devel/valgrind-devel: update to Paul Floyd's FreeBSD valgrind branch.

LGTM

Mon, Jun 29, 9:32 PM
emaste updated subscribers of D25509: LinuxKPI: support thread IDs in linux_task_exiting.
Mon, Jun 29, 9:30 PM
emaste added a comment to D25135: RISC-V boot1.efi and loader.efi support.

Looks good to my cursory review.

Mon, Jun 29, 9:29 PM
emaste added inline comments to D25256: Create the /proc/<PID>/task/ directory in linprocfs.
Mon, Jun 29, 7:18 PM
emaste committed rS362782: Revert r362261, "Re-apply r333944 to unbreak ports".
Revert r362261, "Re-apply r333944 to unbreak ports"
Mon, Jun 29, 1:31 PM

Fri, Jun 26

emaste accepted D25469: Only include object files from .ALLSRC when linking crt1 objects..

LGTM, maybe worth a comment?

Fri, Jun 26, 5:12 PM

Wed, Jun 24

emaste updated subscribers of D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 5:00 PM
emaste added a comment to D25428: Update .clang-format with style(9) header-sorting.

I'm not sure off hand of other representative test cases - most likely we can just find them from user feedback as folks start using this.

Wed, Jun 24, 4:56 PM
emaste updated subscribers of D25428: Update .clang-format with style(9) header-sorting.
Wed, Jun 24, 4:54 PM
emaste accepted D25427: Add WITH_CLANG_FORMAT option.
Wed, Jun 24, 4:48 PM
emaste added a comment to D25427: Add WITH_CLANG_FORMAT option.

Also add a WITH_CLANG_FORMAT text description file

Wed, Jun 24, 4:36 PM
emaste accepted D25427: Add WITH_CLANG_FORMAT option.

LGTM

Wed, Jun 24, 4:36 PM
emaste updated subscribers of D25427: Add WITH_CLANG_FORMAT option.
Wed, Jun 24, 4:35 PM

Tue, Jun 23

emaste added a comment to D25420: Fix printf(3) output of long doubles on RISC-V.

👍

Tue, Jun 23, 8:42 PM
emaste added a comment to D25415: Remove ldconfig_paths_aout from rc.conf after r362543.

Thanks!

Tue, Jun 23, 6:37 PM
emaste closed D24883: ldconfig: remove i386 aout invocation.
Tue, Jun 23, 3:36 PM
emaste committed rS362543: ldconfig: remove i386 aout invocation.
ldconfig: remove i386 aout invocation
Tue, Jun 23, 3:36 PM
emaste committed rS362542: arm64 armreg.h: fix TCR_TBI1 definition.
arm64 armreg.h: fix TCR_TBI1 definition
Tue, Jun 23, 3:32 PM
emaste closed D25411: arm64 armreg.h: fix TCR_TBI1 definition.
Tue, Jun 23, 3:32 PM · arm64
emaste accepted D25411: arm64 armreg.h: fix TCR_TBI1 definition.
Tue, Jun 23, 3:32 PM · arm64
emaste closed D25383: Drop unnecessary 'Subversion' reference.
Tue, Jun 23, 1:48 PM
emaste committed rD54291: Drop an unnecessary 'Subversion' reference..
Drop an unnecessary 'Subversion' reference.
Tue, Jun 23, 1:48 PM
emaste added a comment to D24835: kmod.mk: Don't split out debug symbols if requested.

Anyway, it’s easier to change base.

Tue, Jun 23, 1:38 PM
emaste accepted D24835: kmod.mk: Don't split out debug symbols if requested.

Seems reasonable to me, although I'd also argue that ports ought not set MK_KERNEL_SYMBOLS=no.

Tue, Jun 23, 12:42 PM
emaste requested review of D25383: Drop unnecessary 'Subversion' reference.
Tue, Jun 23, 3:22 AM
emaste closed D24986: kern/subr_intr: fix build with DEBUG on arm64/aarch64.
Tue, Jun 23, 3:21 AM · arm64
emaste requested review of D24883: ldconfig: remove i386 aout invocation.
Tue, Jun 23, 3:19 AM
emaste requested review of D24728: add Mk/Uses/objdump.mk to handle objdump removal from the base system.
Tue, Jun 23, 3:16 AM
emaste requested review of D24729: databases/galera: add objdump to USES.
Tue, Jun 23, 3:16 AM
emaste closed D24602: Remove erroneous spacing in SCTP_ABORT_ASSOCIATION case statement comment in send_reject6().
Tue, Jun 23, 3:16 AM
emaste requested review of D24605: flua: support "require" in the base system.
Tue, Jun 23, 3:16 AM

Mon, Jun 22

emaste added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

@glebius have you heard back from Cronyx?

Mon, Jun 22, 5:06 PM
emaste added inline comments to D25392: Fix Linux recvmsg(2) when msg_namelen returned is 0.
Mon, Jun 22, 4:36 PM

Sun, Jun 21

emaste added a comment to D25009: flua: add ucl library.

Just FYI I'm planning to add module loading support to flua soon, although the current plan is not to have it enabled under BOOTSTRAPPING.

Sun, Jun 21, 8:57 PM
emaste added inline comments to D25392: Fix Linux recvmsg(2) when msg_namelen returned is 0.
Sun, Jun 21, 8:54 PM
emaste added a comment to D25386: Add proper types for linux message queue syscalls.

sys/arm64/linux/syscalls.master too?

Sun, Jun 21, 1:03 PM
emaste added a comment to D25385: Adjust types of linuxulator syscalls.

sys/arm64/linux/syscalls.master too?

Sun, Jun 21, 1:01 PM

Sat, Jun 20

emaste accepted D25369: Make vipw error message less cryptic.
Sat, Jun 20, 1:28 AM

Thu, Jun 18

emaste accepted D25319: rtld: parse rtld own phdr, notes, and enforce relro..
Thu, Jun 18, 9:58 PM
emaste accepted D25339: Update tests(7) as it was imported to base in r359260.
Thu, Jun 18, 6:38 PM
emaste added a comment to D25293: Fix execution of linux binary from multithreaded process..

I think for metadata we probably have:

Thu, Jun 18, 2:57 PM
emaste added a comment to D23893: Sync vis(1) with NetBSD.

@gbe indeed you can commit to src with approval from any src committer, however I noticed after that this code comes from vendor/NetBSD/vis, so we will want to import the update there and merge to contrib/

Thu, Jun 18, 1:58 PM

Tue, Jun 16

emaste added a comment to D14210: Rationalize license test on Linuxolator files.

Still need approval from:

  • Assar Westerlund
  • Peter Wemm
  • Tim J. Robbins
Tue, Jun 16, 1:36 PM
emaste added a comment to D25293: Fix execution of linux binary from multithreaded process..

Now-removed code was added in rS284051, described as a followon to rS282708.

Tue, Jun 16, 1:32 PM

Mon, Jun 15

emaste added a comment to D10335: VirtFS/9p filesystem passthrough support (virtio-9p).

Looking good. Two inline comments and I have not yet reviewed usr.sbin/bhyve/pci_virtio_9p.c

Mon, Jun 15, 6:00 PM
emaste committed rS362198: Tag 2020-06-15 blocklist snapshot.
Tag 2020-06-15 blocklist snapshot
Mon, Jun 15, 1:47 PM
emaste committed rS362197: blocklist: update to 2020-06-15 snapshot.
blocklist: update to 2020-06-15 snapshot
Mon, Jun 15, 1:44 PM
emaste committed rS362196: Following upstream, rename blacklist to blocklist.
Following upstream, rename blacklist to blocklist
Mon, Jun 15, 1:17 PM

Sun, Jun 14

emaste added a comment to D25272: Add linux_madvise(2)..

arm64 also?

Sun, Jun 14, 10:23 PM
emaste accepted D25248: Make Linux uname(2) return x86_64 to 32-bit apps.

https://twitter.com/duncaen/status/1271714593816162304
After setarch linux32 the architecture says armv8l

Sun, Jun 14, 10:22 PM

Fri, Jun 12

emaste added a comment to D25248: Make Linux uname(2) return x86_64 to 32-bit apps.

https://twitter.com/agentdero/status/1271570495041761281
looks like it's actually aarch64 for 32-bit uname on 64-bit kernel

Fri, Jun 12, 11:49 PM
emaste added a comment to D25248: Make Linux uname(2) return x86_64 to 32-bit apps.

lazytwitter turned up https://unix.stackexchange.com/questions/136407/is-my-linux-arm-32-or-64-bit for me,

Fri, Jun 12, 9:39 PM
emaste updated subscribers of D23970: libelf: add note desc endian conversion.
Fri, Jun 12, 3:46 PM
emaste accepted D25230: Add compat.linux.debug sysctl..
Fri, Jun 12, 2:33 PM
emaste accepted D23893: Sync vis(1) with NetBSD.

OK

Fri, Jun 12, 2:32 PM

Thu, Jun 11

emaste added inline comments to D24986: kern/subr_intr: fix build with DEBUG on arm64/aarch64.
Thu, Jun 11, 2:20 PM · arm64
emaste added a comment to D25230: Add compat.linux.debug sysctl..

reasonable IMO

Thu, Jun 11, 1:25 PM

Wed, Jun 10

emaste accepted D25216: Make linux(4) handle SO_REUSEPORT.

LGTM

Wed, Jun 10, 8:26 PM
emaste added a comment to D25211: Remove the sed hack for ABI tag notes..

I very much like the cleanup/simplification that comes from this

Wed, Jun 10, 4:54 PM
emaste committed rS362013: Fix arm64 kernel build with DEBUG on.
Fix arm64 kernel build with DEBUG on
Wed, Jun 10, 4:01 PM

Jun 9 2020

emaste added a comment to D25139: Add lldb version of gdb mini-tutorial..

this lgtm, thanks for all the effort here!

Jun 9 2020, 4:57 PM
emaste accepted D25148: remove references to using shar archives for submitting ports.
Jun 9 2020, 4:42 PM
emaste committed rS361966: MFC r361657: elf_common.h: define DF_1_PIE.
MFC r361657: elf_common.h: define DF_1_PIE
Jun 9 2020, 2:20 PM
emaste committed rS361948: MFC r361740: lld: Set DF_1_PIE for -pie.
MFC r361740: lld: Set DF_1_PIE for -pie
Jun 9 2020, 12:28 AM
emaste committed rS361947: MFC r361739: llvm: Add DF_1_PIE.
MFC r361739: llvm: Add DF_1_PIE
Jun 9 2020, 12:26 AM
emaste committed rS361946: MFC r361739: llvm: Add DF_1_PIE.
MFC r361739: llvm: Add DF_1_PIE
Jun 9 2020, 12:26 AM

Jun 8 2020

emaste added inline comments to D25139: Add lldb version of gdb mini-tutorial..
Jun 8 2020, 8:18 PM
emaste accepted D25177: Default Linux openfiles to 1024.
Jun 8 2020, 6:52 PM
emaste accepted D25173: Support SO_SNDBUFFORCE/SO_RCVBUFFORCE..
Jun 8 2020, 6:49 PM
emaste added inline comments to D25139: Add lldb version of gdb mini-tutorial..
Jun 8 2020, 4:32 PM
emaste added a comment to D25139: Add lldb version of gdb mini-tutorial..

(And, thank you very much for your submission!)

Jun 8 2020, 4:31 PM
emaste committed rS361930: crashinfo: stop looking for gdb in /usr/bin/gdb.
crashinfo: stop looking for gdb in /usr/bin/gdb
Jun 8 2020, 4:11 PM
emaste added a comment to D25173: Support SO_SNDBUFFORCE/SO_RCVBUFFORCE..

I think this is fine, although I wish we had some standard comment (along the lines of /* XXX */) we could use to identify cases where we intentionally implement a low-fidelity version of Linux behaviour.

Jun 8 2020, 1:51 AM

Jun 7 2020

emaste committed rS361894: Remove now-unused GNU as build infrastructure.
Remove now-unused GNU as build infrastructure
Jun 7 2020, 1:53 PM
emaste committed rS361892: src.conf.5: regen after BINUTILS options removal.
src.conf.5: regen after BINUTILS options removal
Jun 7 2020, 1:53 PM
emaste committed rS361880: Retire BINUTILS and BINUTILS_BOOTSTRAP options.
Retire BINUTILS and BINUTILS_BOOTSTRAP options
Jun 7 2020, 12:07 AM

Jun 6 2020

emaste committed rS361879: src.conf.5: regen after r361876, SYSTEM_LINKER description update.
src.conf.5: regen after r361876, SYSTEM_LINKER description update
Jun 6 2020, 10:26 PM
emaste committed rS361876: Update SYSTEM_LINKER descriptions wrt BINUTILS.
Update SYSTEM_LINKER descriptions wrt BINUTILS
Jun 6 2020, 9:08 PM
emaste committed rS361860: Remove GNU objcopy and objdump build infrastructure.
Remove GNU objcopy and objdump build infrastructure
Jun 6 2020, 2:46 AM
emaste committed rS361858: src.conf.5: regen after r361857, BINUTILS_BOOTSTRAP off by default.
src.conf.5: regen after r361857, BINUTILS_BOOTSTRAP off by default
Jun 6 2020, 2:28 AM
emaste committed rS361857: src.opts.mk: disable BINUTILS_BOOTSTRAP universally.
src.opts.mk: disable BINUTILS_BOOTSTRAP universally
Jun 6 2020, 2:27 AM
emaste committed rS361853: Rename skein_block_asm.s to .S and assemble using Clang IAS.
Rename skein_block_asm.s to .S and assemble using Clang IAS
Jun 6 2020, 12:36 AM
emaste closed D8434: Rename to skein_block_asm.s to .S, to use Clang's integrated assembler.
Jun 6 2020, 12:36 AM

Jun 5 2020

emaste committed rS361850: Makefile.inc1: remove stale dependency cleanup from 2018.
Makefile.inc1: remove stale dependency cleanup from 2018
Jun 5 2020, 8:19 PM
emaste added a comment to D25154: skein_block_asm.s: use #ifdef not .ifdef, for Clang IAS.

The other option would have been to change the build system to pass -Wa,-defsym, SKEIN_USE_ASM=XXX (that's what I did for my godbolt testing.
But either solution seems fine.

Jun 5 2020, 7:42 PM
emaste added a comment to D8434: Rename to skein_block_asm.s to .S, to use Clang's integrated assembler.

We assemble skein_block_asm.S four times - once for sys/modules/crypto, and three times for lib/libmd (.o, .pico, .po). All four instances have the same change when assembled with Clang IAS vs. GNU as 2.17.50:

Jun 5 2020, 7:11 PM