On ThunderX2 bcast_tlbi_workaround is 0. I successfully netbooted with the patch but haven't done anything significant.
A Poudriere build is now running on a kernel with this patch on the Ampere eMAG in Kitchener.
I do not see any other variant except a new macros.
I dislike the fact that you now have to strictly match ENTRY with END
I think you could go ahead and commit the END() additions independently in any case?
On my eMAG bcast_tlbi_workaround is 0. I'm now installing a new kernel to start Poudriere runs.
Mon, Oct 21
Fri, Oct 18
Unfortunately I haven't been able to get a ThunderX from packet.net this week
Thu, Oct 17
Committed in r353685, I'm not sure why Phabricator has not closed this yet.
Two points - first, please upload with full context (see https://wiki.freebsd.org/action/show/Phabricator for commandline examples). Second, please more details about the reason for the patch - e.g. a description of the problem that this solves, a link to the PR, a reproduction case, etc.
Wed, Oct 16
I would appreciate it if folks would exercise this patch a bit, particularly on ThunderX, ThunderX2, and eMAG machines.
Fri, Oct 11
Wed, Oct 9
update comment again
update comment per jhb
chase member rename
Note that the types are the same size on LP64 archs. This breaks the ABI on ILP32.
Tue, Oct 8
Of course, totally identical devices (down to serial numbers) can still cause confusion.
My use case for something like this is a USB-serial console server where I might have 16 different USB-serial adapters attached to various USB hubs; I intended to address it by using the serial number in each device.
Fri, Oct 4
Thu, Oct 3
Wed, Oct 2
I'm mostly in favor of the change (smaller kernel size, etc.), but since we are removing driver from GENERIC, it's better if we can provide a mechanism to load the driver on demand, or a binary update can easily brick the system...
looks ok to me
Drop min and make the test >= PATH_MAX. As the sysctl passes the string excluding the NUL req->newlen equal to PATH_MAX is too long.
Correct per @kib
Ah, I probably just grepped in sys/kern. I'll take a look at a patch for nfs_nfsdport.c in a bit - it's not so straightforward.
@kib pointed out on IRC that the original PATH_MAX + 1 is incorrect but arguably innocent and I agree, but think it is worth the change to avoid confusing folks (who find that code) into wondering if PATH_MAX includes space for the NUL or not - that's what prompted me to look at this in the first place.
Tue, Oct 1
I wonder if it's worth committing all but actually switching amd64 to KLD_SHARED, then making that change separately.
Mon, Sep 30
Just abandon it then I guess?
It may be that the right approach is to just have elfcopy/strip fail on such broken input and we should just drop this patch.
Actually set alignment in output
What do we do with this change?
Previously we checked for only BINUTILS_BOOTSTRAP as a broken option and suggested installing the binutils package. This was originally done for arm64 where we used the in-tree Clang and external binutils package. Extend the warning to suggest instead the full xtoolchain package if we have no in-tree compiler either.
Fri, Sep 27
Ouch, command substitution in syscalls.conf
(of course the message is only valid after D20575)
This one actually does have public distfiles and ongoing development (and maybe upstream does not use sys/dir.h any longer), but I think someone would have to take maintainership to restore it.