Feed Advanced Search

Yesterday

emaste updated subscribers of D16370: Implement early microcode loading for Intel i386 and amd64 platforms..
Fri, Jul 20, 10:01 PM
emaste updated subscribers of D16370: Implement early microcode loading for Intel i386 and amd64 platforms..
Fri, Jul 20, 10:00 PM

Fri, Jul 13

emaste accepted D16257: As discussed several times on freebsd-arch, start to decommission armeb..
Fri, Jul 13, 5:58 PM

Fri, Jul 6

emaste committed rS336044: Regen arm64 linux sysent after r336043.
Regen arm64 linux sysent after r336043
Fri, Jul 6, 7:47 PM
emaste committed rS336043: Fix arm64 linuxulator clone() argument order.
Fix arm64 linuxulator clone() argument order
Fri, Jul 6, 7:45 PM
emaste accepted D16154: Adding myself to committers-src.dot and calendar.freebsd.

Approved

Fri, Jul 6, 1:49 AM

Thu, Jul 5

emaste accepted D16140: Create a new macro for static DPCPU data.

Fine with me

Thu, Jul 5, 4:31 PM
emaste added inline comments to D16140: Create a new macro for static DPCPU data.
Thu, Jul 5, 3:35 PM
emaste added a comment to D16141: Disable sbrk() use in GNU tools..

I doubt an exp-run is necessary, as only three binutils are built today, as, ld, objdump (on some subset of architectures), and if anything does break I expect it would most likely be found by tinderbox.

Thu, Jul 5, 3:33 PM
emaste added a comment to D16141: Disable sbrk() use in GNU tools..

Although we still need to make sure that everything still works with this change.

Thu, Jul 5, 2:49 PM
emaste added a comment to D16141: Disable sbrk() use in GNU tools..

No objection from me.

Thu, Jul 5, 2:49 PM
emaste added inline comments to D16141: Disable sbrk() use in GNU tools..
Thu, Jul 5, 2:38 PM
emaste added a comment to D16140: Create a new macro for static DPCPU data.
In D16140#342262, @bz wrote:

What about (what do others think):

  • leave the non static and not rename them to *_GLOBAL_*
  • rename the static to STATIC_DPCPU_DEFINE

    That way grep()ing for DPCPU_DEFINE will still give us all of them, there's less noise in the change, and only the problematic case is (will be) dealt with.
Thu, Jul 5, 2:36 PM
emaste accepted D16140: Create a new macro for static DPCPU data.

I'm fine with this as a NFC first step

Thu, Jul 5, 2:02 PM
emaste added a comment to D16140: Create a new macro for static DPCPU data.

LGTM

Thu, Jul 5, 1:54 PM
emaste committed rS335981: Welcome Ben Widawsky (bwidawsk) as a src committer.
Welcome Ben Widawsky (bwidawsk) as a src committer
Thu, Jul 5, 1:46 PM

Wed, Jul 4

emaste committed rS335965: MFC r306098 (br): Use kqueue(2) instead of select(2)..
MFC r306098 (br): Use kqueue(2) instead of select(2).
Wed, Jul 4, 6:03 PM
emaste committed rS335964: MFC r306098 (br): Use kqueue(2) instead of select(2)..
MFC r306098 (br): Use kqueue(2) instead of select(2).
Wed, Jul 4, 6:02 PM
emaste added a comment to D12298: libc: remove gets.

Just tried building lang/gcc7 on my gets-less dev system and see:

Wed, Jul 4, 4:37 PM
emaste updated subscribers of D12298: libc: remove gets.
Wed, Jul 4, 3:09 PM
emaste committed rS335942: muge(4): remove DTB MAC addr from TODO list after r335925.
muge(4): remove DTB MAC addr from TODO list after r335925
Wed, Jul 4, 1:38 PM
emaste accepted D16117: muge(4): add DTB blob as one more possible source of MAC address.
Wed, Jul 4, 12:03 AM

Tue, Jul 3

emaste accepted D16117: muge(4): add DTB blob as one more possible source of MAC address.

Some suggestions but overall I think this is fine. I can futz with it after commit otherwise.

Tue, Jul 3, 9:43 PM
emaste added inline comments to D16117: muge(4): add DTB blob as one more possible source of MAC address.
Tue, Jul 3, 8:39 PM
emaste updated the diff for D12298: libc: remove gets.

Update with kib@ and jhb@ feedback

Tue, Jul 3, 7:21 PM
emaste added a comment to D12298: libc: remove gets.

I requested an exp-run in PR222796. I think we could deal with most of the failures post-commit, but a few gcc ports fail and we should probably address those in advance.

Tue, Jul 3, 7:18 PM

Fri, Jun 29

emaste added a comment to D15141: Add support for ThunderX2 PCIe.

Any further comment @andrew?

Fri, Jun 29, 7:36 PM
emaste committed rS335800: newvers.sh: avoid possibly invalid relative directory.
newvers.sh: avoid possibly invalid relative directory
Fri, Jun 29, 6:45 PM
emaste committed rS335796: r335795 build fix: make static functions static.
r335795 build fix: make static functions static
Fri, Jun 29, 2:51 PM

Thu, Jun 28

emaste committed rS335775: Add stub arm64 linuxulator VDSO ldscript.
Add stub arm64 linuxulator VDSO ldscript
Thu, Jun 28, 8:36 PM

Wed, Jun 27

emaste added inline comments to D16033: Add LLVM BPF backend.
Wed, Jun 27, 4:25 PM
emaste committed rS335702: Split kern_break from sys_break and use it in linuxulator.
Split kern_break from sys_break and use it in linuxulator
Wed, Jun 27, 2:45 PM
emaste closed D16019: Split kern_break from sys_break and use it in linuxulator.
Wed, Jun 27, 2:45 PM
emaste added inline comments to D16019: Split kern_break from sys_break and use it in linuxulator.
Wed, Jun 27, 2:10 PM
emaste added a comment to D16019: Split kern_break from sys_break and use it in linuxulator.

I wonder if we also want to restore ibcs2's int return value?

Wed, Jun 27, 12:46 PM
emaste added inline comments to D16019: Split kern_break from sys_break and use it in linuxulator.
Wed, Jun 27, 12:43 PM
emaste updated the diff for D16019: Split kern_break from sys_break and use it in linuxulator.

Review feedback from @kib

Wed, Jun 27, 12:42 PM

Tue, Jun 26

emaste committed rS335676: Correct linprocfs/linsysfs arch check in r335672.
Correct linprocfs/linsysfs arch check in r335672
Tue, Jun 26, 7:14 PM
emaste added a comment to D15687: libssp is part of GCC, not an independent library..

The libssp subdir should be added only if both MK_SSP and MK_GCC are true; someone who sets WITHOUT_SSP but WITH_GCC should not get it.

Tue, Jun 26, 6:48 PM
emaste created D16019: Split kern_break from sys_break and use it in linuxulator.
Tue, Jun 26, 6:17 PM
emaste committed rS335672: Build linprocfs and linsysfs also on arm64.
Build linprocfs and linsysfs also on arm64
Tue, Jun 26, 4:50 PM
emaste added a comment to D15687: libssp is part of GCC, not an independent library..

For reference, BSDL __stack_chk_fail in Android https://android.googlesource.com/platform/bionic/+/ics-mr1-release/libc/bionic/ssp.c and NetBSD http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/misc/stack_protector.c?annotate=1.9&only_with_tag=MAIN.

Tue, Jun 26, 3:08 PM

Mon, Jun 25

emaste committed rS335646: linux64: add arm64 linuxulator build details.
linux64: add arm64 linuxulator build details
Mon, Jun 25, 8:33 PM
emaste closed D16011: Add arm64 target support to linux64 Makefile.
Mon, Jun 25, 8:33 PM
emaste added inline comments to D16011: Add arm64 target support to linux64 Makefile.
Mon, Jun 25, 8:02 PM
emaste committed rS335644: Quiet unused fn warning for linuxulator w/o legacy syscalls.
Quiet unused fn warning for linuxulator w/o legacy syscalls
Mon, Jun 25, 7:25 PM
emaste created D16011: Add arm64 target support to linux64 Makefile.
Mon, Jun 25, 7:15 PM
emaste accepted D16008: Allow the linuxulator to use a common cpu_set_syscall_retval.
Mon, Jun 25, 5:44 PM
emaste added inline comments to D16008: Allow the linuxulator to use a common cpu_set_syscall_retval.
Mon, Jun 25, 3:40 PM
emaste closed D15834: arm64 linuxulator: arm64 linux64 sysvec.
Mon, Jun 25, 2:12 PM
emaste committed rS335639: Initial arm64 linuxulator linux_sysvec.
Initial arm64 linuxulator linux_sysvec
Mon, Jun 25, 2:12 PM

Fri, Jun 22

emaste updated the diff for D15968: newvers.sh: fix git false positive -dirty tag.

cd to the VCS topdir before invoking git diff

Fri, Jun 22, 5:10 PM
emaste planned changes to D15968: newvers.sh: fix git false positive -dirty tag.

Hrm, this only works if git diff is run at the top level dir; needs further investigation.

Fri, Jun 22, 4:55 PM
emaste added inline comments to D15968: newvers.sh: fix git false positive -dirty tag.
Fri, Jun 22, 4:45 PM
emaste updated subscribers of D15968: newvers.sh: fix git false positive -dirty tag.
Fri, Jun 22, 4:36 PM
emaste created D15968: newvers.sh: fix git false positive -dirty tag.
Fri, Jun 22, 4:36 PM
emaste committed rS335521: MFC r335213: ldd: reference readelf instead of objdump in warning message.
MFC r335213: ldd: reference readelf instead of objdump in warning message
Fri, Jun 22, 12:30 AM
emaste committed rS335520: MFC r335209: elf.5: add readelf cross-reference.
MFC r335209: elf.5: add readelf cross-reference
Fri, Jun 22, 12:29 AM
emaste committed rS335519: MFC r335214: Correct kern.pre.mk comment: objcopy copies objects..
MFC r335214: Correct kern.pre.mk comment: objcopy copies objects.
Fri, Jun 22, 12:28 AM
emaste committed rS335518: MFC r335221: Add deprecation notice in asf.8.
MFC r335221: Add deprecation notice in asf.8
Fri, Jun 22, 12:27 AM

Thu, Jun 21

emaste added a comment to D15952: Fix the Linux kernel version number calculation.

Bah, this one was named linux32_trans_osrel() so my search missed it. I'll add that to this patch as well.

Thu, Jun 21, 11:01 PM
emaste accepted D15858: Fix output of linprocfs stat entry.
Thu, Jun 21, 10:57 PM
emaste added inline comments to D15858: Fix output of linprocfs stat entry.
Thu, Jun 21, 9:23 PM
emaste accepted D15952: Fix the Linux kernel version number calculation.

I'm fine with either check (<= 0 or @cem's version) with the same change applied to linux32_sysvec.c

Thu, Jun 21, 8:45 PM
emaste added inline comments to D15952: Fix the Linux kernel version number calculation.
Thu, Jun 21, 8:18 PM
emaste added inline comments to D15952: Fix the Linux kernel version number calculation.
Thu, Jun 21, 8:07 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.

I'm only finding two copies: sys/i386/linux/linux_sysvec.c and sys/amd64/linux/linux_sysvec.c but have updated the patch to fix those copies.

Thu, Jun 21, 8:02 PM
emaste accepted D15952: Fix the Linux kernel version number calculation.

We will also need to address the four copies of linux_trans_osrel (but after further investigation if desired, I have not checked exactly how the value they calculate is used).

Thu, Jun 21, 7:00 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.
In D15952#337697, @cem wrote:

Right, I suggested using LINUX_KERNVER() to do this in my initial comment :-).

Thu, Jun 21, 6:42 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.

Ah, top level Linux Makefile emits a definition of KERNEL_VERSION using shifts.

Thu, Jun 21, 6:38 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.

Ah, I see the comment in the bug now - yes, if Linux uses shifts we should too. It would be good to put a reference in the commit that mentions the Linux macro/etc. that calculates it though.

Thu, Jun 21, 6:31 PM
emaste added a comment to D15952: Fix the Linux kernel version number calculation.
In D15952#337607, @cem wrote:

Ed, can you explain it in a little more detail?

Thu, Jun 21, 6:26 PM
emaste added a comment to D15858: Fix output of linprocfs stat entry.

See linux_map_osrel

This probably fits better with the existing code, and I'm inclined to move that direction. Is using linux_kernver() the way to access this value?

Thu, Jun 21, 2:53 PM
emaste committed rS335482: Rename usr.bin/elfcopy to usr.bin/objcopy.
Rename usr.bin/elfcopy to usr.bin/objcopy
Thu, Jun 21, 2:28 PM
emaste committed rS335464: Makefile.inc1: rename build metadata file to toolchain-metadata.mk.
Makefile.inc1: rename build metadata file to toolchain-metadata.mk
Thu, Jun 21, 2:16 AM

Jun 20 2018

emaste added a comment to D15931: Add LPIT parsing to acpidump.

I'm still getting the handle of the process here. In my local repo, these are two separate git commits, are you saying the correct way to do this would have been two separate arc diff commands for each of my git commits?

Jun 20 2018, 8:00 PM
emaste added a comment to D15931: Add LPIT parsing to acpidump.

I took care of the NFIT man page addition in rS335459 - it was my fault :)

Jun 20 2018, 7:41 PM
emaste committed rS335459: acpidump.8: include NFIT in the man page list of tables.
acpidump.8: include NFIT in the man page list of tables
Jun 20 2018, 7:41 PM
emaste updated subscribers of D15931: Add LPIT parsing to acpidump.
Jun 20 2018, 6:59 PM
emaste committed rS335454: usr.bin/ar: use standard 2-Clause FreeBSD license.
usr.bin/ar: use standard 2-Clause FreeBSD license
Jun 20 2018, 6:43 PM
emaste accepted D15928: Add ThunderX2 CPU revision macro. Add ThunderX2 name in identcpu.c.
Jun 20 2018, 4:47 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..
In D15904#336964, @mat wrote:

What matters is that it is available on all supported releases :-)

Jun 20 2018, 2:58 PM
emaste updated subscribers of D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..

Another option: upon discussion with @dim we will likely end up installing llvm's llvm-objdump as objdump. It's broadly compatible, but the output format etc. might be slightly different.

Jun 20 2018, 2:17 PM
emaste added a comment to D15908: readelf: add `--print-file-name`.

On second thought I'm not sure about this: --print-file-name options typically prefix all output lines with the file name.

Jun 20 2018, 1:53 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..

This looks fine to me. It's probably worth adding a comment explaining the use of ${NONEXISTENT} though.

Jun 20 2018, 1:52 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..
In D15904#336884, @mat wrote:

Mmmm,

$ readelf --print-file-name -r /usr/bin/mktemp
readelf: unrecognized option `--print-file-name'
Jun 20 2018, 1:46 PM

Jun 19 2018

emaste committed rS335387: linuxulator: handle V3 capget/capset.
linuxulator: handle V3 capget/capset
Jun 19 2018, 9:26 PM
emaste closed D15887: linuxulator: handle V3 capget/capset.
Jun 19 2018, 9:26 PM
emaste committed rS335377: usr.bin/ar: remove incorrect SPDX tags.
usr.bin/ar: remove incorrect SPDX tags
Jun 19 2018, 5:30 PM
emaste committed rS335376: usr.bin/ar: use standard 2-Clause FreeBSD license.
usr.bin/ar: use standard 2-Clause FreeBSD license
Jun 19 2018, 5:28 PM
emaste closed D14561: usr.bin/ar: use standard 2-Clause FreeBSD license.
Jun 19 2018, 5:28 PM
emaste committed rS335375: MFC r334363: elfdump: chase ABI tag note name change from r232832.
MFC r334363: elfdump: chase ABI tag note name change from r232832
Jun 19 2018, 5:12 PM
emaste created D15908: readelf: add `--print-file-name`.
Jun 19 2018, 5:10 PM
emaste added a comment to D15904: As objdump is being phased out for 12.0, convert the small bit using it to using readelf..

Reported in the PR -- nm might be more useful for this script.

Jun 19 2018, 3:05 PM
emaste updated subscribers of D15834: arm64 linuxulator: arm64 linux64 sysvec.
Jun 19 2018, 1:03 PM
emaste accepted D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Jun 19 2018, 2:27 AM
emaste added a comment to D15836: Rework how the ld link is handled in WORLDTMP from r322811..

LGTM

Jun 19 2018, 2:27 AM
emaste added inline comments to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..
Jun 19 2018, 2:24 AM
emaste added inline comments to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..
Jun 19 2018, 2:19 AM
emaste added a comment to D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..

Would it make sense to set some new variable based on TOOLS_PREFIX, MK_LLD, MK_LLD_BOOTSTRAP so that the same expression doesn't need to be repeated?

Jun 19 2018, 1:34 AM