Page MenuHomeFreeBSD
Differential D53948

bsd.lib.mk: document INTERNALLIB and PRIVATELIB
ClosedPublic
Actions

Authored by kib on Thu, Nov 27, 4:44 PM.

Details

Reviewers
des
emaste
dim
Commits
rGe60861eb41ca: bsd.lib.mk: document INTERNALLIB and PRIVATELIB

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Thu, Nov 27, 4:44 PM
Herald added subscribers: imp, bdrewery. · View Herald TranscriptThu, Nov 27, 4:44 PM
kib requested review of this revision.Thu, Nov 27, 4:44 PM
emaste accepted this revision.Thu, Nov 27, 5:02 PM

All the variables in here would benefit from documentation but we can start with these

This revision is now accepted and ready to land.Thu, Nov 27, 5:02 PM
dim accepted this revision.Thu, Nov 27, 5:57 PM

LGTM with one nit.

share/mk/bsd.lib.mk
5

For consistency, either add "we" before "build", or remove it in the INTERNALLIB entry.

des requested changes to this revision.Thu, Nov 27, 6:06 PM
des added inline comments.
share/mk/bsd.lib.mk
2
8

This is incorrect, as I told you on IRC. Headers for private libraries are installed in /usr/include/private.

This revision now requires changes to proceed.Thu, Nov 27, 6:06 PM
kib updated this revision to Diff 167203.Thu, Nov 27, 6:42 PM
kib marked 3 inline comments as done.

INTERNALLIB: s/pic/pie/; only state that the result is suitable for linking into binaries. This sounds like a bug to me: we should build pic version instead of pie.
PRIVATELIB: headers go into include/private/<name>

des accepted this revision.Thu, Nov 27, 6:47 PM
This revision is now accepted and ready to land.Thu, Nov 27, 6:47 PM
kib updated this revision to Diff 167204.Thu, Nov 27, 6:48 PM

Slightly more clarity for normal libs.

This revision now requires review to proceed.Thu, Nov 27, 6:48 PM
emaste accepted this revision.Thu, Nov 27, 6:51 PM
This revision is now accepted and ready to land.Thu, Nov 27, 6:51 PM
Closed by commit rGe60861eb41ca: bsd.lib.mk: document INTERNALLIB and PRIVATELIB (authored by kib). · Explain WhyThu, Nov 27, 7:53 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGe60861eb41ca: bsd.lib.mk: document INTERNALLIB and PRIVATELIB.

Revision Contents
Changeset List

PathSize
share/
mk/
15 lines

Diff 167209

View Options

share/mk/bsd.lib.mk

Loading...