aq(4): Fix VLAN tag test
ClosedPublic
Actions

Authored by emaste on Nov 20 2025, 2:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 14, 3:01 PM

	Unknown Object (File)
	Sun, Dec 14, 2:51 PM

	Unknown Object (File)
	Dec 6 2025, 6:13 AM

	Unknown Object (File)
	Dec 4 2025, 4:22 AM

	Unknown Object (File)
	Dec 3 2025, 3:19 AM

	Unknown Object (File)
	Dec 1 2025, 3:17 AM

	Unknown Object (File)
	Nov 30 2025, 4:38 PM

	Unknown Object (File)
	Nov 29 2025, 3:29 AM

View All 14 Files

Subscribers

imp

Details

Reviewers

adrian

Commits

rG8666fda1afb0: aq(4): Fix VLAN tag test

Summary

Previously emitted a compiler warning "warning: bitwise comparison
always evaluates to false."

Looking at the OpenBSD driver (which is based on this code) it looks
like the VLAN flag should be set if either of thsee bits is.  In the
OpenBSD driver these are AQ_RXDESC_TYPE_VLAN and AQ_RXDESC_TYPE_VLAN2
rather than a magic number 0x60.