aq(4): Fix VLAN tag test
Needs ReviewPublic
Actions

Authored by emaste on Thu, Nov 20, 2:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 20, 6:40 PM

	Unknown Object (File)
	Thu, Nov 20, 2:20 PM

	Unknown Object (File)
	Thu, Nov 20, 11:07 AM

	Unknown Object (File)
	Thu, Nov 20, 8:51 AM

	Unknown Object (File)
	Thu, Nov 20, 7:50 AM

Subscribers

None

Details

Reviewers

adrian

Summary

Previously emitted a compiler warning "warning: bitwise comparison
always evaluates to false."

Looking at the OpenBSD driver (which is based on this code) it looks
like the VLAN flag should be set if either of thsee bits is.  In the
OpenBSD driver these are AQ_RXDESC_TYPE_VLAN and AQ_RXDESC_TYPE_VLAN2
rather than a magic number 0x60.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Thu, Nov 20, 2:27 AM

emaste created this revision.

emaste added a parent revision: D53813: Import snapshot of Aquantia ACQ107 vendor driver.Thu, Nov 20, 2:35 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

aq/

aq_ring.c

2 lines

Diff 166818

View Options

aq(4): Fix VLAN tag testNeeds ReviewPublicActions