Makefile.inc1: Skip pkgbase installkernel check with INSTKERNNAME

[emaste]

Summary

Specifying a non-default kernel name with INSTKERNNAME means that the
user will not conflict with a pkgbase kernel, so skip the check.

[ivy]

Specifying a non-default kernel name with INSTKERNNAME means that the
user will not conflict with a pkgbase kernel, so skip the check.

i'm fairly sure this isn't true: what stops me providing an INSTKERNNAME that matches a pkgbase kernel?

[emaste]

It's not guaranteed to be true in general, but this is just intended prevent foot-shooting in the default/common case, where DESTDIR and INSTKERNNAME are not set and default to / and kernel, respectively.

[ivy]

but this suggests it's safe to use make installkernel if you're using INSTKERNNAME, which isn't true. it may be true, but it also may be safe to use it without INSTKERNNAME set at all - it depends on what you set it to and what pkgbase kernels you have installed.

i would rather add a variable to disable this check (other than DESTDIR), like DISABLE_INSTALLKERNEL_PKG_CHECK, which people could put in /etc/make.conf if they're sure they understand the implications of doing this. alternatively, perhaps we could check if /boot/${INSTKERNNAME} was installed by pkg.

[christos]

In D54164#1239214, @ivy wrote:

but this suggests it's safe to use make installkernel if you're using INSTKERNNAME, which isn't true. it may be true, but it also may be safe to use it without INSTKERNNAME set at all - it depends on what you set it to and what pkgbase kernels you have installed.

i would rather add a variable to disable this check (other than DESTDIR), like DISABLE_INSTALLKERNEL_PKG_CHECK, which people could put in /etc/make.conf if they're sure they understand the implications of doing this. alternatively, perhaps we could check if /boot/${INSTKERNNAME} was installed by pkg.

I actually think the latter is a good idea, and probably more robust.

[ivy]

In D54164#1239215, @christos wrote:

I actually think the latter is a good idea, and probably more robust.

D54346

[emaste]

D54346 landed