Page MenuHomeFreeBSD
Differential D53897

xhci: Add header values for Debug Capability (DbC)
Needs ReviewPublic
Actions

Authored by thj on Mon, Nov 24, 1:19 PM.
Tags
None
Referenced Files
F137718957: D53897.diff
Tue, Nov 25, 5:08 AM
F137617731: D53897.diff
Mon, Nov 24, 3:32 PM
F137614007: D53897.id167017.diff
Mon, Nov 24, 3:09 PM
F137612206: D53897.id.diff
Mon, Nov 24, 2:59 PM
F137612016: D53897.diff
Mon, Nov 24, 2:58 PM
F137610190: D53897.id167017.diff
Mon, Nov 24, 2:48 PM
Subscribers
imp

Details

Reviewers
aokblast
adrian
bz
emaste
Group Reviewers
USB

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68822
Build 65705: arc lint + arc unit

Event Timeline

thj created this revision.Mon, Nov 24, 1:19 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 24, 1:19 PM
thj requested review of this revision.Mon, Nov 24, 1:19 PM
Harbormaster completed remote builds in B68822: Diff 167017.Mon, Nov 24, 1:19 PM
emaste added inline comments.Mon, Nov 24, 2:03 PM
sys/dev/usb/controller/xhcireg.h
221–224

Why both the "extract bits 15:8" macro and shifted #defines for in and out? Also what's special about 0xFF? 0x02-0xFE are equally reserved afaics.

252

SBR is bit 1, not 2?

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
controller/
123 lines

Diff 167017

View Options

sys/dev/usb/controller/xhcireg.h

Loading...