release: Remove not-NO_ROOT cases
AcceptedPublic
Actions

Authored by emaste on Dec 11 2025, 5:18 PM.

Details

Reviewers

cperciva

Group Reviewers

releng

Summary

We always use NO_ROOT for release artifact builds, so remove the
alternate code paths.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Dec 11 2025, 5:18 PM

Herald added subscribers: ivy, jrtc27. · View Herald TranscriptDec 11 2025, 5:18 PM

emaste requested review of this revision.Dec 11 2025, 5:18 PM

@cperciva any suggestion on the best way to test this / confirm that I haven't missed something?

cperciva added inline comments.Mon, Jan 5, 4:45 PM

release/tools/azure.conf
37	This looks wrong; we're going to treat NO_ROOT not being set as if it was set.

In D54179#1245798, @emaste wrote:

@cperciva any suggestion on the best way to test this / confirm that I haven't missed something?

You mean aside from running a build without NO_ROOT set and comparing the outputs? But generally speaking I'd say that grep -R NO_ROOT should be most of what's needed.

emaste added inline comments.Mon, Jan 5, 7:45 PM

release/tools/azure.conf
37	My intent was to set `NO_ROOT` unconditionally in cases that invoke submakes, and turn `NO_ROOT` being unset into an error for the lower-level targets or includes like this, just in case there's some out-of-tree build scripts that expect to be able to run not-NO_ROOT builds. A 2nd step would remove these entirely.