Allow -DNO_STRICT_ERE to restore historic regex behavior
ClosedPublic
Actions

Authored by sjg on Wed, May 8, 10:15 PM.

Details

Reviewers

kevans

Commits

rGf77b5b295da3: Allow -DNO_STRICT_REGEX to restore historic regex behavior

Summary

Allow restoring the behavior of '{' as described in regex(3).
Ie. only treat it as start of bounds if followed by a digit.

If NO_STRICT_ERE is not defined, the behavior introduced by
commit a4a801688c909ef39cbcbc3488bc4fdbabd69d66 is retained,
otherwise the previous behavior is restored.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sjg created this revision.Wed, May 8, 10:15 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, May 8, 10:15 PM

sjg requested review of this revision.Wed, May 8, 10:15 PM

Harbormaster completed remote builds in B57626: Diff 138271.Wed, May 8, 10:15 PM

kevans added inline comments.Wed, May 8, 10:30 PM

lib/libc/regex/regcomp.c
910	It occurs to me that this is the BRE path, but it'd be good for the knob to be consistent across BREs and EREs- maybe just rename the knob to `NO_STRICT_REGEX`? I don't think I have any complaints otherwise.