Page MenuHomeFreeBSD

bsdinstall: Stop loading cryptodev for ZFS installations
ClosedPublic

Authored by markj on May 8 2024, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 9:18 AM
Unknown Object (File)
Sat, Sep 27, 9:12 AM
Unknown Object (File)
Sat, Sep 27, 9:02 AM
Unknown Object (File)
Sat, Sep 27, 8:57 AM
Unknown Object (File)
Mon, Sep 15, 12:17 PM
Unknown Object (File)
Sun, Sep 14, 9:17 PM
Unknown Object (File)
Sun, Sep 14, 3:34 AM
Unknown Object (File)
Sun, Sep 14, 2:58 AM
Subscribers

Details

Summary
  • zfs doesn't actually depend on cryptodev, and most arm64 kernel configs include std.dev, which includes "device crypto" anyway.
  • This config works around a problem with kldxref, not with the loader, and this is believed to be fixed.
  • Loading cryptodev creates /dev/crypto, which gives unprivileged users access to the kernel's opencrypto framework. Very few applications need it, so we're needlessly increasing the kernel's surface area.

Thus, stop auto-loading cryptodev.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.May 8 2024, 3:11 PM
This revision is now accepted and ready to land.May 8 2024, 3:16 PM

You might want to clarify the first bullet point in the commit message: the second part of the sentence seems like a non sequitur or a typo if the reader does not realize that zfs depends on crypto, which is different from cryptodev.