Page MenuHomeFreeBSD
Differential D47978

rtwn: add tx power training for RTL8812/RTL8821
Needs ReviewPublic
Actions

Authored by adrian on Sat, Dec 7, 3:49 PM.

Details

Reviewers
None
Group Reviewers
wireless
Summary

This apparently kicks off TX power level self-calibration, which
can't hurt.

Locally tested:

  • RTL8812AU, STA
  • RTL8821AU, STA

Obtained from: Linux rtw88

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61024
Build 57908: arc lint + arc unit

Event Timeline

adrian created this revision.Sat, Dec 7, 3:49 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Dec 7, 3:49 PM
adrian requested review of this revision.Sat, Dec 7, 3:49 PM
Harbormaster completed remote builds in B61024: Diff 147680.Sat, Dec 7, 3:49 PM
adrian added a parent revision: D47976: rtwn: add a register value for R92C_FPGA0_POWER_SAVE, and other bits.Sat, Dec 7, 3:50 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
imp added inline comments.Sat, Dec 7, 3:54 PM
sys/dev/rtwn/rtl8812a/r12a_chan.c
194

So there are 3 writes? Why the loop?

adrian added a child revision: D47979: rtwn: add APIs for setting transmit power.Sat, Dec 7, 4:34 PM
adrian added inline comments.Sat, Dec 7, 10:58 PM
sys/dev/rtwn/rtl8812a/r12a_chan.c
194

For now i'm just trying to mirror what the BSD licenced rtw88 code is doing - save the underflow, which I addressed but their driver doesn't.

Once I know it's all working OK, we should absolutely clean it up before landing. It could be done with three lines and some ternary operators.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8812a/
32 lines
1 line

Diff 147680

View Options

sys/dev/rtwn/rtl8812a/r12a_chan.c

Loading...
View Options

sys/dev/rtwn/rtl8812a/r12a_reg.h

Loading...