Page MenuHomeFreeBSD
Differential D48118

rtwn: set the maximum AMPDU size correctly for RTL8812AU/RTL8821AU
ClosedPublic
Actions

Authored by adrian on Dec 17 2024, 5:37 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:00 AM
Unknown Object (File)
Tue, Oct 14, 7:49 AM
Unknown Object (File)
Thu, Oct 9, 10:53 PM
Unknown Object (File)
Tue, Sep 23, 4:29 PM
Unknown Object (File)
Sat, Sep 20, 6:07 PM
Unknown Object (File)
Sat, Sep 20, 6:07 PM
Unknown Object (File)
Thu, Sep 18, 2:51 AM
Unknown Object (File)
Sep 5 2025, 1:49 PM
View All 60 Files
Subscribers
bz
fuz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rGdd58d03a2a46: rtwn: set the maximum A-MPDU size correctly for RTL8812AU/RTL8821AU
Summary

The vendor driver sets it to 64k or 128k depending upon chipset,
along with bit 31 being set.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Dec 17 2024, 5:37 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 17 2024, 5:37 AM
adrian requested review of this revision.Dec 17 2024, 5:37 AM
Harbormaster completed remote builds in B61213: Diff 148133.Dec 17 2024, 5:37 AM
adrian added a parent revision: D48113: rtwn: don't set the RTS/CTS primary channel field for RTL8812AU/RTL8821AU.Dec 17 2024, 5:37 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D48140: rtwn: explicitly configure RTS based on basic rates.Dec 19 2024, 2:22 AM
fuz added a subscriber: fuz.Dec 26 2024, 8:53 PM

Also reasonable.

bz accepted this revision as: bz.Jan 7 2025, 7:14 PM
bz added a subscriber: bz.

Adjust the comments and good to go I would say.

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c
144

Funny, what is that value doing? 11n PLCP is 64k max. Oh this one does 11ac as well. Rightyho.

sys/dev/rtwn/rtl8812a/usb/r12au_init.c
147

A-MPDU also in the 1st line of the commit message

151

I think the comment should extend to what's in the commit message about the high bit always being set by the vendor driver.

This revision is now accepted and ready to land.Jan 7 2025, 7:14 PM
adrian updated this revision to Diff 148923.Jan 8 2025, 2:30 AM

feedback from bz

This revision now requires review to proceed.Jan 8 2025, 2:30 AM
Harbormaster completed remote builds in B61571: Diff 148923.Jan 8 2025, 2:30 AM
adrian marked 2 inline comments as done.Jan 8 2025, 2:30 AM
adrian added inline comments.
sys/dev/rtwn/rtl8812a/usb/r12au_init.c
147

i'll fix that in the commit ;otherwise it'll break git arc update

This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2025, 2:59 AM
Closed by commit rGdd58d03a2a46: rtwn: set the maximum A-MPDU size correctly for RTL8812AU/RTL8821AU (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian marked an inline comment as done.
adrian added a commit: rGdd58d03a2a46: rtwn: set the maximum A-MPDU size correctly for RTL8812AU/RTL8821AU.
adrian added a child revision: D48239: ath_hal_ar9300: quick refactor of tx/rx chain handling.Jan 9 2025, 5:07 PM
adrian removed a child revision: D48140: rtwn: explicitly configure RTS based on basic rates.Jan 9 2025, 5:11 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8812a/
1 line
usb/
1 line
12 lines
rtl8821a/
usb/
1 line

Diff 148925

View Options

sys/dev/rtwn/rtl8812a/r12a_var.h

Loading...
View Options

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c

Loading...
View Options

sys/dev/rtwn/rtl8812a/usb/r12au_init.c

Loading...
View Options

sys/dev/rtwn/rtl8821a/usb/r21au_attach.c

Loading...