Page MenuHomeFreeBSD

rtwn: set the maximum AMPDU size correctly for RTL8812AU/RTL8821AU
ClosedPublic

Authored by adrian on Dec 17 2024, 5:37 AM.
Referenced Files
Unknown Object (File)
Wed, Oct 15, 2:00 AM
Unknown Object (File)
Tue, Oct 14, 7:49 AM
Unknown Object (File)
Thu, Oct 9, 10:53 PM
Unknown Object (File)
Tue, Sep 23, 4:29 PM
Unknown Object (File)
Sat, Sep 20, 6:07 PM
Unknown Object (File)
Sat, Sep 20, 6:07 PM
Unknown Object (File)
Thu, Sep 18, 2:51 AM
Unknown Object (File)
Sep 5 2025, 1:49 PM
Subscribers

Details

Summary

The vendor driver sets it to 64k or 128k depending upon chipset,
along with bit 31 being set.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Adjust the comments and good to go I would say.

sys/dev/rtwn/rtl8812a/usb/r12au_attach.c
144

Funny, what is that value doing? 11n PLCP is 64k max. Oh this one does 11ac as well. Rightyho.

sys/dev/rtwn/rtl8812a/usb/r12au_init.c
147

A-MPDU also in the 1st line of the commit message

151

I think the comment should extend to what's in the commit message about the high bit always being set by the vendor driver.

This revision is now accepted and ready to land.Jan 7 2025, 7:14 PM
This revision now requires review to proceed.Jan 8 2025, 2:30 AM
adrian added inline comments.
sys/dev/rtwn/rtl8812a/usb/r12au_init.c
147

i'll fix that in the commit ;otherwise it'll break git arc update

This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2025, 2:59 AM
This revision was automatically updated to reflect the committed changes.
adrian marked an inline comment as done.