Page MenuHomeFreeBSD

rtwn: use ieee80211_ht_check_tx_shortgi_20() and ieee80211_ht_check_tx_shortgi_40()
Needs ReviewPublic

Authored by adrian on Mon, Nov 25, 11:21 PM.
Referenced Files
F103874708: D47751.diff
Sat, Nov 30, 2:15 PM
Unknown Object (File)
Mon, Nov 25, 11:27 PM
Subscribers

Details

Reviewers
None
Group Reviewers
wireless
Summary

Use the new net80211 routines rather than rolling our own.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60777
Build 57661: arc lint + arc unit

Event Timeline

looking at these, i'm wondering whether the better move is to be doing the channel check inside the helper functions as well. i remember the node channel being .. weirdly sketchy thought. i'll go do some more deep diving on this before it lands.

looking at these, i'm wondering whether the better move is to be doing the channel check inside the helper functions as well. i remember the node channel being .. weirdly sketchy thought. i'll go do some more deep diving on this before it lands.

Let us know when you come to the final conclusion and we can do the review then; I'd rather do it once than thrice.

Yeah, it shouldn't take long.

ah I remember it now. ni->ni_chw has to do with the currently configured channel width, which can be changed via a HT_TXCHWIDTH action frame. The STA can request that the AP switch to 20MHz for transmitting to that station for now, even if the station is associated in 40MHz.

So when it's associated, ni_chw == the width of ni->ni_chan.

I think I'm going to add another helper function that returns true if the channel is 40MHz, the peer is 40MHz /and/ the currently selected width is 40MHz, so if someone requests a channel width change, it'll correctly start transmitting at 20MHz even though it's associated at 40MHz. (which is perfectly legal.)

Ugh now I remember this mess in more detail. :-) Stay tuned.

Staying tuned; please indicate when done.