Page MenuHomeFreeBSD

rtwn: remove SEQ_SEL, replace with a QOS bit
ClosedPublic

Authored by adrian on Sun, Dec 15, 6:20 PM.
Referenced Files
Unknown Object (File)
Tue, Dec 31, 2:50 AM
Unknown Object (File)
Thu, Dec 26, 8:08 AM
Unknown Object (File)
Thu, Dec 26, 2:26 AM
Unknown Object (File)
Thu, Dec 26, 2:14 AM
Unknown Object (File)
Wed, Dec 25, 5:23 AM
Unknown Object (File)
Wed, Dec 25, 5:20 AM
Unknown Object (File)
Tue, Dec 24, 5:19 PM
Unknown Object (File)
Wed, Dec 18, 7:40 PM
Subscribers

Details

Summary

I've reviewed all of the linux vendor and upstream drivers.
This SEQ_SEL field isn't a mask and doesn't ever look like it
it was; instead this bit is set to tag QoS data frames.

In fact, it effectively was set to 0 for STA frames and potentially 1
for broadcast/multicast frames as the STA macid of 0 and broadcast/
multicast macid of 1 maps to that. In AP modes it would be tagged
based on bit 0.

So, bring it in line with the vendor and linux drivers.

Locally tested:

  • RTL8192CU, STA, hostap
  • RTL8188EU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable