Page MenuHomeFreeBSD

rtwn: remove SEQ_SEL, replace with a QOS bit
ClosedPublic

Authored by adrian on Dec 15 2024, 6:20 PM.
Referenced Files
F121037048: D48092.diff
Mon, Jun 23, 3:06 AM
F121019795: D48092.id.diff
Sun, Jun 22, 11:36 PM
Unknown Object (File)
Fri, Jun 20, 8:25 PM
Unknown Object (File)
Mon, Jun 16, 6:10 PM
Unknown Object (File)
Mon, Jun 2, 2:33 AM
Unknown Object (File)
May 21 2025, 4:12 AM
Unknown Object (File)
May 19 2025, 6:17 AM
Unknown Object (File)
Apr 21 2025, 10:54 PM
Subscribers

Details

Summary

I've reviewed all of the linux vendor and upstream drivers.
This SEQ_SEL field isn't a mask and doesn't ever look like it
it was; instead this bit is set to tag QoS data frames.

In fact, it effectively was set to 0 for STA frames and potentially 1
for broadcast/multicast frames as the STA macid of 0 and broadcast/
multicast macid of 1 maps to that. In AP modes it would be tagged
based on bit 0.

So, bring it in line with the vendor and linux drivers.

Locally tested:

  • RTL8192CU, STA, hostap
  • RTL8188EU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable