Differential D48112

rtwn: make sure RCR_APPFCS stays set in monitor mode / mode changes.
ClosedPublic
Actions

Authored by adrian on Dec 16 2024, 8:12 PM.

Details

Reviewers

None

Group Reviewers

wireless

Commits

rG791170aaf7ef: rtwn: make sure RCR_APPFCS stays set in monitor mode / mode changes.

Summary

My previous commit meant that APPFCS wasn't enabled during monitor
mode and likely other corner cases.

Ensure it stays on at all times.

This, amusingly, fixes monitor mode in RTL8812AU/RTL8821AU - without it,
I don't see HT/VHT frames in monitor mode but I can still receive them
in normal STA mode.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 16 2024, 8:12 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 16 2024, 8:12 PM

adrian requested review of this revision.Dec 16 2024, 8:12 PM

Harbormaster completed remote builds in B61206: Diff 148120.Dec 16 2024, 8:12 PM

adrian added a parent revision: D48103: rtwn: announce VHT support for RTL8812AU/RTL8821AU..Dec 16 2024, 8:13 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D48113: rtwn: don't set the RTS/CTS primary channel field for RTL8812AU/RTL8821AU.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 28 2024, 1:47 AM

Closed by commit rG791170aaf7ef: rtwn: make sure RCR_APPFCS stays set in monitor mode / mode changes. (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG791170aaf7ef: rtwn: make sure RCR_APPFCS stays set in monitor mode / mode changes..

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

if_rtwn_rx.c

9 lines

Diff 148450

View Options

rtwn: make sure RCR_APPFCS stays set in monitor mode / mode changes.ClosedPublicActions