rtwn: remove unused rate configuration code for management traffic.
ClosedPublic
Actions

Authored by adrian on Dec 6 2024, 4:00 AM.

Details

Reviewers

None

Group Reviewers

wireless

Commits

rG977679d651de: rtwn: remove unused rate configuration code for management traffic.

Summary

After discussion with the rtlwifi maintainers, it looks like this
path isn't even used.

(And it's part of the firmware rate control path which we currently
don't enable for other reasons.)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 6 2024, 4:00 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2024, 4:00 AM

adrian requested review of this revision.Dec 6 2024, 4:00 AM

Harbormaster completed remote builds in B60982: Diff 147565.Dec 6 2024, 4:00 AM

adrian added a parent revision: D47902: rtwn: update RTL8812AU/RTL8821AU receive path to include VHT info.Dec 6 2024, 4:01 AM

adrian added a reviewer: wireless.Dec 6 2024, 3:36 PM

adrian added a project: wireless.

LGTM, I don't think disabled code full of XXX comments has much value and it's not going to help much in whatever we might need to implement here.

adrian added a child revision: D47976: rtwn: add a register value for R92C_FPGA0_POWER_SAVE, and other bits.Dec 6 2024, 11:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2024, 7:15 AM

Closed by commit rG977679d651de: rtwn: remove unused rate configuration code for management traffic. (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG977679d651de: rtwn: remove unused rate configuration code for management traffic..

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

rtl8192c/

r92c_fw.c

25 lines

Diff 147675

View Options

sys/dev/rtwn/rtl8192c/r92c_fw.c

rtwn: remove unused rate configuration code for management traffic.ClosedPublicActions