Differential D47988

ath_rate_sample: correct the "best rate" calculation
ClosedPublic
Actions

Authored by adrian on Dec 8 2024, 5:13 PM.

Details

Reviewers

imp

Group Reviewers

wireless

Commits

rG25af78d0bdcf: ath_rate_sample: correct the "best rate" calculation

Summary

This should be a *9 rather than a *10 so higher stream MCS rates
(eg comparing MCS0 and MCS8) that have slightly longer average transmit
times (but better burst transmit times) get considered.

This mirrors what the later code does when considering if a rate
change is needed.

Locally tested:

AR9280, AP mode
AR9380, AP mode

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Dec 8 2024, 5:13 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2024, 5:13 PM

adrian requested review of this revision.Dec 8 2024, 5:13 PM

Harbormaster completed remote builds in B61033: Diff 147700.Dec 8 2024, 5:13 PM

adrian added a parent revision: D47987: rtwn: try enforcing net80211 regulatory / txpower limits for 11n chips.Dec 8 2024, 5:17 PM

adrian added a reviewer: wireless.Dec 8 2024, 5:22 PM

adrian added a project: wireless.

adrian added a child revision: D47990: rtwn: bump up the RX USB buffers.Dec 8 2024, 7:36 PM

imp accepted this revision.Dec 12 2024, 6:13 PM

imp added inline comments.

sys/dev/ath/ath_rate/sample/sample.c
401	Does this need a note about why?

This revision is now accepted and ready to land.Dec 12 2024, 6:13 PM

Closed by commit rG25af78d0bdcf: ath_rate_sample: correct the "best rate" calculation (authored by adrian). · Explain WhyDec 18 2024, 11:50 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG25af78d0bdcf: ath_rate_sample: correct the "best rate" calculation.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ath/

ath_rate/

sample/

sample.c

3 lines

Diff 148224

View Options

sys/dev/ath/ath_rate/sample/sample.c

ath_rate_sample: correct the "best rate" calculationClosedPublicActions