Paths

Table of Contentst

Differential D47860

rtwn: remove the conditional compilation around the sc_ht40 option.
ClosedPublic
Actions

Authored by adrian on Dec 2 2024, 5:30 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 2:55 AM

	Unknown Object (File)
	Thu, Dec 12, 1:24 AM

	Unknown Object (File)
	Mon, Dec 9, 1:25 AM

	Unknown Object (File)
	Dec 5 2024, 7:48 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG81aef988acc7: rtwn: remove the conditional compilation around the sc_ht40 option.

Summary

This option stems from a bunch of issues a long time ago where HT40
support on some NICs is unstable - likely because we're not setting
up the RF/baseband correctly.

In any case, it doesn't need to be conditionally compiled anymore.
Leave it in, leave it off by default, and various chipset initialisation
paths can decide whether to enable it themselves.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60907
Build 57791: arc lint + arc unit

Event Timeline

adrian created this revision.Dec 2 2024, 5:30 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 2 2024, 5:30 AM

adrian requested review of this revision.Dec 2 2024, 5:30 AM

Harbormaster completed remote builds in B60907: Diff 147339.Dec 2 2024, 5:30 AM

adrian added a parent revision: D47776: rtwn: enable receiving AMSDU in AMPDU.Dec 2 2024, 5:32 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D47861: rtwn: don't do 64 bit TSF extension by default.

Yeah it seems #if 1 serves no useful documentary purpose

sys/dev/rtwn/if_rtwnvar.h
175	shall we switch it to `bool` while here?

This revision is now accepted and ready to land.Dec 3 2024, 9:28 PM

ugh somehow i missed the differential revision url in this when I landed it, sorry :(

In D47860#1092750, @adrian wrote:

ugh somehow i missed the differential revision url in this when I landed it, sorry :(

Then you can also Close it.

emaste closed this revision.Dec 6 2024, 2:30 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

2 lines

2 lines

Diff 147339

sys/dev/rtwn/if_rtwn.c

Loading...

sys/dev/rtwn/if_rtwnvar.h

Loading...