Page MenuHomeFreeBSD

rtwn: remove SEQ_SEL, replace with a QOS bit
ClosedPublic

Authored by adrian on Dec 15 2024, 6:20 PM.
Referenced Files
F133606679: D48092.diff
Sun, Oct 26, 11:56 PM
Unknown Object (File)
Sun, Oct 26, 1:49 AM
Unknown Object (File)
Fri, Oct 24, 9:58 PM
Unknown Object (File)
Fri, Oct 24, 7:46 PM
Unknown Object (File)
Tue, Oct 14, 5:34 PM
Unknown Object (File)
Wed, Oct 8, 3:43 PM
Unknown Object (File)
Mon, Sep 29, 3:00 AM
Unknown Object (File)
Sun, Sep 28, 1:26 AM
Subscribers

Details

Summary

I've reviewed all of the linux vendor and upstream drivers.
This SEQ_SEL field isn't a mask and doesn't ever look like it
it was; instead this bit is set to tag QoS data frames.

In fact, it effectively was set to 0 for STA frames and potentially 1
for broadcast/multicast frames as the STA macid of 0 and broadcast/
multicast macid of 1 maps to that. In AP modes it would be tagged
based on bit 0.

So, bring it in line with the vendor and linux drivers.

Locally tested:

  • RTL8192CU, STA, hostap
  • RTL8188EU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61176
Build 58060: arc lint + arc unit