header for nvlist_t declaration
ClosedPublic
Actions

Authored by jhb on Sat, Dec 28, 9:15 PM.

Details

Reviewers

imp
chuck
oshogbo

Commits

rG8a50aa09019a: nv: Add <sys/_nv.h> header for nvlist_t declaration

Summary

This can be useful for headers that wish to use nvlist_t pointers in a
structure or function argument without pulling in all of the headers
from <sys/nv.h>.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sat, Dec 28, 9:15 PM

jhb created this revision.

Harbormaster completed remote builds in B61369: Diff 148483.Sat, Dec 28, 9:15 PM

jhb added a child revision: D48230: nvmf: Switch several ioctls to using nvlists.Sat, Dec 28, 9:15 PM

imp added inline comments.Sat, Dec 28, 9:26 PM

sys/sys/cnv.h
40	Can't this be removed, here and elsewhere, since _nv.h includes it for !KERNEL and this is in !KERNEL?

One thing I did not try to address is the other places that define nvlist_t (notably in libcasper). They do so _after_ including <sys/nv.h> which is kind of confusing to me and I'm not sure why that is so I've left them alone.

sys/sys/cnv.h
40	Yes in theory. The reason I did not is that conceptually I just want <sys/_nv.h> to ensure that nvlist_t is defined. These headers define other symbols that <sys/nv_namespace.h> renames such as cnvlist_*, etc.