Page MenuHomeFreeBSD

nv: Add <sys/_nv.h> header for nvlist_t declaration
ClosedPublic

Authored by jhb on Dec 28 2024, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 4, 9:49 AM
Unknown Object (File)
Mon, Sep 22, 10:10 PM
Unknown Object (File)
Sep 5 2025, 8:50 AM
Unknown Object (File)
Aug 14 2025, 11:22 PM
Unknown Object (File)
Aug 2 2025, 6:04 PM
Unknown Object (File)
Jul 28 2025, 2:49 AM
Unknown Object (File)
Jul 27 2025, 10:21 PM
Unknown Object (File)
Jul 27 2025, 7:18 PM
Subscribers
None

Details

Summary

This can be useful for headers that wish to use nvlist_t pointers in a
structure or function argument without pulling in all of the headers
from <sys/nv.h>.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Dec 28 2024, 9:15 PM
jhb created this revision.
sys/sys/cnv.h
40

Can't this be removed, here and elsewhere, since _nv.h includes it for !KERNEL and this is in !KERNEL?

One thing I did not try to address is the other places that define nvlist_t (notably in libcasper). They do so _after_ including <sys/nv.h> which is kind of confusing to me and I'm not sure why that is so I've left them alone.

sys/sys/cnv.h
40

Yes in theory. The reason I did not is that conceptually I just want <sys/_nv.h> to ensure that nvlist_t is defined. These headers define other symbols that <sys/nv_namespace.h> renames such as cnvlist_*, etc.

Ok. Those are good reasons.

This revision is now accepted and ready to land.Dec 30 2024, 5:54 PM