Makefile.inc1: Require DISTDIR be set for `make distributeworld`
ClosedPublic
Actions

Authored by emaste on Dec 11 2024, 3:56 PM.

Details

Reviewers

imp
brooks

Group Reviewers

releng

Commits

rG6d1d5577ce10: Makefile.inc1: Require DISTDIR be set for `make distributeworld`
rGf6575ed0deb0: Makefile.inc1: Require DISTDIR be set for `make distributeworld`

Summary

distributeworld is the target used to stage world for building dist sets
for release targets.  Error out if attempting to distributeworld to /.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Dec 11 2024, 3:56 PM

emaste created this revision.

emaste added a reviewer: brooks.Dec 12 2024, 5:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2024, 3:24 PM

Closed by commit rGf6575ed0deb0: Makefile.inc1: Require DISTDIR be set for `make distributeworld` (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf6575ed0deb0: Makefile.inc1: Require DISTDIR be set for `make distributeworld`.

This seems like a good change. I have some vague memories about complaints when I changed things in this area, but I think that might have been the largely unrelated "distribution" target.

Yes. Good change. I've shot my foot off this way

emaste added a commit: rG6d1d5577ce10: Makefile.inc1: Require DISTDIR be set for `make distributeworld`.Dec 16 2024, 12:40 AM

Revision Contents
Changeset List

Path

Size

Makefile.inc1

3 lines

Diff 147924

View Options

Makefile.inc1: Require DISTDIR be set for `make distributeworld`ClosedPublicActions