Differential D46031

nvme: Warn if there's system interrupt issues.
ClosedPublic
Actions

Authored by imp on Jul 18 2024, 9:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 11, 4:50 AM

	Unknown Object (File)
	Thu, Nov 6, 6:16 AM

	Unknown Object (File)
	Tue, Nov 4, 12:48 AM

	Unknown Object (File)
	Mon, Nov 3, 10:39 PM

	Unknown Object (File)
	Mon, Nov 3, 10:37 PM

	Unknown Object (File)
	Mon, Nov 3, 5:37 AM

	Unknown Object (File)
	Sun, Nov 2, 6:56 PM

	Unknown Object (File)
	Oct 29 2025, 1:43 AM

Subscribers

Details

Reviewers

gallatin
chs
mav
chuck
jhb

Commits

rGbb7f7d5b5201: nvme: Warn if there's system interrupt issues.

Summary

Issue a warning if we have system interrupt issues. If you get this
warning, then we submitted a request, it timed out without an interrupt
being posted, but when we polled the card's completion, we found
completion events. This indicates that we're missing interrupts, and to
date all the times I've helped people track issues like this down it has
been a system issue, not an NVMe driver isseue.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 18 2024, 9:55 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 18 2024, 9:55 PM

imp requested review of this revision.Jul 18 2024, 9:55 PM

Harbormaster completed remote builds in B58712: Diff 141093.Jul 18 2024, 9:55 PM

imp added a parent revision: D46026: nvme: Optimize timeout code further.Jul 18 2024, 9:55 PM

gallatin accepted this revision.Jul 18 2024, 9:56 PM

This revision is now accepted and ready to land.Jul 18 2024, 9:56 PM

Tweak comments

This revision now requires review to proceed.Jul 18 2024, 10:01 PM

Harbormaster completed remote builds in B58714: Diff 141095.Jul 18 2024, 10:01 PM

Misc updates with testing

Harbormaster completed remote builds in B58730: Diff 141114.Jul 19 2024, 4:23 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2024, 11:04 PM

Closed by commit rGbb7f7d5b5201: nvme: Warn if there's system interrupt issues. (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGbb7f7d5b5201: nvme: Warn if there's system interrupt issues..

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

9 lines

sys/

dev/

nvme/

1 line

9 lines

Diff 141300

share/man/man4/nvme.4

Loading...

sys/dev/nvme/nvme_private.h

Loading...

sys/dev/nvme/nvme_qpair.c

Loading...