Page MenuHomeFreeBSD

cdefs: Add __deprecated
AcceptedPublic

Authored by imp on Jul 25 2024, 5:31 PM.
Tags
None
Referenced Files
F93426784: D46137.diff
Mon, Sep 9, 11:12 AM
F93281900: D46137.diff
Sun, Sep 8, 4:55 PM
Unknown Object (File)
Sun, Sep 8, 7:47 AM
Unknown Object (File)
Sat, Sep 7, 8:01 AM
Unknown Object (File)
Wed, Aug 21, 4:39 PM
Unknown Object (File)
Wed, Aug 21, 4:39 PM
Unknown Object (File)
Tue, Aug 20, 2:12 PM
Unknown Object (File)
Jul 26 2024, 4:55 PM

Details

Reviewers
emaste
jhb
Summary

Add __deprecated decorator. This is for a deprecated interface. We use
it today in our documentation, but don't actually provide it or use it.

Also, OpenZFS has a poorly-updated copy of compiler.h that we'll need
to fix upstream before this can land. Ideally, they'd be identical (and
OpenZFS would use the linuxkpi in FreeBSD version).

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58831
Build 55718: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jul 25 2024, 5:31 PM

copystr (see copy(9)) might be a good candidate for this that might justify adding it?

The tense in the commit message confused me: when the commit lands we will provide __deprecated so it won't be correct to say we don't provide it.

This revision is now accepted and ready to land.Jul 25 2024, 5:36 PM

The tense in the commit message confused me: when the commit lands we will provide __deprecated so it won't be correct to say we don't provide it.

Perhaps 's/don't actually/don't currently/' or 's/don't actually provide/haven't been providing or using it/'?

Yea, I hadn't planned on including the second paragraph...

Also, just looked at Linux. It defines this as just a decorator. It used to provide warnings, but doesn't anymore.
So this could whine more than Linux does when we compile linuxkpi items that provide deprecated interfaces.

Also also: it can take an arg that's a message, so maybe we want to include that.