Page MenuHomeFreeBSD
Differential D46827

roundup_pow_of_two: don't take the log of it
ClosedPublic
Actions

Authored by dougm on Sep 28 2024, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 6:07 AM
Unknown Object (File)
Nov 6 2024, 5:43 PM
Unknown Object (File)
Nov 6 2024, 3:39 PM
Unknown Object (File)
Oct 24 2024, 12:40 AM
Unknown Object (File)
Oct 21 2024, 7:29 AM
Unknown Object (File)
Oct 21 2024, 6:29 AM
Unknown Object (File)
Oct 20 2024, 8:28 AM
Unknown Object (File)
Oct 19 2024, 5:52 PM
View All 14 Files
Subscribers
imp
kib

Details

Reviewers
bz
kib
Commits
rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it
Summary

Based on the definitions, ilog2(roundup_pow_of_two(x)) == order_base_2(x). Replace the former with the latter in a few places to save a few calculations.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Sep 28 2024, 12:02 AM
dougm created this revision.
bz added a reviewer: kib.Sep 28 2024, 12:11 AM
bz added a subscriber: kib.

Add @kib in the hope that he's maintaining the mlx* bits these days.

bz added a comment.Sep 28 2024, 12:11 AM

To me looks ok

kib accepted this revision.Sep 28 2024, 11:40 AM
This revision is now accepted and ready to land.Sep 28 2024, 11:40 AM
Closed by commit rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it (authored by dougm). · Explain WhySep 28 2024, 5:01 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGc44fbfdb5686: roundup_pow_of_two: don't take the log of it.
Herald added a subscriber: imp. · View Herald TranscriptSep 28 2024, 5:01 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mlx4/
mlx4_en/
2 lines
mlx4_ib/
4 lines

Diff 143836

View Options

sys/dev/mlx4/mlx4_en/en.h

Loading...
View Options

sys/dev/mlx4/mlx4_ib/mlx4_ib_qp.c

Loading...