This compiles.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/compat/linuxkpi/common/include/linux/highmem.h | ||
|---|---|---|
| 82–83 | This seems highly suspect, and warrants investigation. | |
| sys/compat/linuxkpi/common/include/linux/highmem.h | ||
|---|---|---|
| 84 | This is a hack that I don't understand, but the change is probably ok. | |
| sys/compat/linuxkpi/common/include/linux/mm.h | ||
| 417 | These are used by drm-kmod. I believe changing them to vm_page_tryxbusy() and vm_page_xunbusy() would be correct. I can test such a change. | |
| sys/compat/linuxkpi/common/include/linux/mm.h | ||
|---|---|---|
| 406–418 | Is the out-of-tree i915kms driver that you mentioned using these? | |
| sys/compat/linuxkpi/common/include/linux/mm.h | ||
|---|---|---|
| 406–418 | Yes, here: https://github.com/freebsd/drm-kmod/blob/master/drivers/gpu/drm/i915/gem/i915_gem_userptr.c#L209 It's more correct to use the busy lock there. I'm not convinced that that code is sane at all in any case, but now I'm not sure that the userptr code gets compiled in at all. All of this file is conditionally defined based on whether CONFIG_MMU_NOTIFIER is configured, and I can't see any evidence that it is. | |
Comment Actions
Use busy style synchronization in linux emulation.
Delete more unused declarations from vm_page.h.
| sys/compat/linuxkpi/common/include/linux/mm.h | ||
|---|---|---|
| 406–418 | That code isn't compiled indeed, so we could drop these wrappers as well. | |
Comment Actions
Can we remove PA_LOCK_COUNT too? There is one use in a powerpc64 pmap to size the PV lock array, but substituting MAXCPU there would be more consistent with other platforms and would also avoid changing the size of the array.