Page MenuHomeFreeBSD

vm_pageout: reduce number of flush() params
ClosedPublic

Authored by dougm on May 28 2025, 6:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 24, 7:29 AM
Unknown Object (File)
Tue, Sep 23, 5:54 PM
Unknown Object (File)
Mon, Sep 22, 12:42 PM
Unknown Object (File)
Thu, Sep 18, 8:17 PM
Unknown Object (File)
Wed, Sep 17, 6:18 PM
Unknown Object (File)
Wed, Sep 17, 1:15 PM
Unknown Object (File)
Sep 14 2025, 5:15 AM
Unknown Object (File)
Sep 12 2025, 10:25 AM
Subscribers

Details

Summary

vm_pageout_flush is called in two places, and in both, the mreq parameter is 0. Drop that parameter, and simplify the calculations that use it.

The prunlen and eio parameters are either both NULL, or neither NULL. Drop the prunlen parameter and, when eio is NULL, return the runlen value instead of the numpagedout parameter, which the caller ignores.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.May 28 2025, 6:02 AM
dougm created this revision.
sys/vm/vm_pageout.c
457
sys/vm/vm_pageout.h
103

Consider changing the boolean_t to a plain bool since you're changing this anyway: we're gradually removing uses of the former from the tree.

dougm marked 2 inline comments as done.
sys/vm/vm_pageout.c
454
sys/vm/vm_pageout.h
103
dougm marked 2 inline comments as done.
This revision is now accepted and ready to land.May 30 2025, 8:02 PM
This revision was automatically updated to reflect the committed changes.
sys/vm/vm_pageout.c
546

This causes the for loop to end. Before, it kept going.