arm64: Use the DMAP region in pmap_mapbios

[andrew]

Summary

As pmap_mapbios is used to map a physical address with a default memory
attribute we can try to use the DMAP region. For now check if all pages
are mapped, however it is expected this check can be removed later
after testing on more hardware.

Sponsored by: Arm Ltd

[jhb]

I expect most of the calls to pmap_mapbios to be mapping firmware tables that are in RAM and covered by the direct map.

[alc]

sys/arm64/arm64/pmap.c

7845

Using pmap_pte() would be faster because it would tell you that the virtual address is mapped by an L1 or L2 block, allowing you to advance by 2M or 1G in a single iteration.

[andrew]

sys/arm64/arm64/pmap.c

7845

I expect this is mostly used for small mappings as it's mostly used for ACPI to map in its tables.

I'm planning on moving pmap_mapbios to subr_devmap.c so won't be able to use pmap_pte. We could add a function to check if a range of memory is mapped that could use pmap_pte.

[markj]

sys/arm64/arm64/pmap.c

7844

7845

I expect this is mostly used for small mappings as it's mostly used for ACPI to map in its tables.

On its own this isn't a great argument: someone might copy and paste this code elsewhere, so all else being equal it's better to use a faster implementation.

7963

What if the caller called pmap_change_attr() or pmap_change_prot() on the mapped range? We would want to restore the old mapping attributes.

Hmm, pmap_unmapdev() on amd64 ignores this possibility. I suppose that the worst case, surrounding regions of the direct map might be using a smaller page size than necessary.

[andrew]

• Add pmap_kmapped_range to check if a range is mapped & use it in pmap_mapbios
• Reset memory attribute and protections on unmap

[markj]

sys/arm64/arm64/pmap.c

2153

When can this condition be false?

2154

If ATTR_CONTIGUOUS is set, you could skip more than a page.

7964

Assert that the end of the range is also in the DMAP region?

[andrew]

• MPASS on ATTR_DESCR_TYPE_PAGE
• Check for ATTR_CONTIGUOUS
• Add a KASERT for the end in the DMAP in pmap_unmapbios

[alc]

sys/arm64/arm64/pmap.c

2114