arm64: Make L1_BLOCKS_SUPPORTED dynamic
ClosedPublic
Actions

Authored by andrew on Wed, Aug 21, 12:16 PM.

Details

Reviewers

alc
kib
markj
manu

Group Reviewers

arm64

Commits

rGd99e6b22c01f: arm64: Make L1_BLOCKS_SUPPORTED dynamic

Summary

When FEAT_LPA2 is implemented and the TCR_EL1.DS field is set we can
create blocks at level 1 with a 16kB page size. Add a variable to
tell the kernel this is enabled.

This will be used by other parts of pmap.c with a 4k page kernel so
make it visible there.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Wed, Aug 21, 12:16 PM

Herald added a reviewer: manu. · View Herald TranscriptWed, Aug 21, 12:16 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Wed, Aug 21, 12:16 PM

andrew added a parent revision: D46394: arm64: Make shareability attributes dynamic.

Harbormaster completed remote builds in B59123: Diff 142301.Wed, Aug 21, 12:16 PM

markj accepted this revision.Thu, Aug 22, 3:32 PM

markj added inline comments.

sys/arm64/arm64/pmap.c
1693	Maybe `blocks_supported` would be a better name.

This revision is now accepted and ready to land.Thu, Aug 22, 3:32 PM

kib added inline comments.Thu, Aug 22, 6:55 PM

sys/arm64/arm64/pmap.c
369	Should both vars have __read_mostly annotation?

alc accepted this revision.Fri, Aug 23, 5:10 AM

alc added inline comments.

sys/arm64/arm64/pmap.c
1693	I don't think that the `blocks_` prefix is necessary. The other counter under the same sysctl node is about blocks too. In general, any of these sysctl nodes not ending in c, e.g., `pmap.l1`, `pmap.l2`, are about block mappings.