arm64: Remove TCR_CACHE_ATTRS and TCR_SMP_ATTRS
ClosedPublic
Actions

Authored by andrew on Aug 21 2024, 12:15 PM.

Details

Reviewers

alc
kib
markj
manu

Group Reviewers

arm64

Commits

rG3a3aa2cc0756: arm64: Remove TCR_CACHE_ATTRS and TCR_SMP_ATTRS

Summary

These are only used in one place so expand them there.

While here always set TCR_SH0_IS and TCR_SH1_IS. There is no advantage
to not set them in a UP kernel.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Aug 21 2024, 12:15 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 21 2024, 12:15 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Aug 21 2024, 12:15 PM

andrew added a parent revision: D46392: arm64: Add the tcr_el2 ds field.

Harbormaster completed remote builds in B59121: Diff 142299.Aug 21 2024, 12:15 PM

andrew added a child revision: D46394: arm64: Make shareability attributes dynamic.Aug 21 2024, 12:15 PM

markj accepted this revision.Aug 22 2024, 3:27 PM

This revision is now accepted and ready to land.Aug 22 2024, 3:27 PM

alc accepted this revision.Aug 23 2024, 5:01 AM

kib accepted this revision.Aug 23 2024, 11:21 AM

andrew removed a child revision: D46394: arm64: Make shareability attributes dynamic.Aug 28 2024, 2:06 PM

andrew added a child revision: D46466: arm64: Remove ATTR_DEFAULT from pte.h.

Closed by commit rG3a3aa2cc0756: arm64: Remove TCR_CACHE_ATTRS and TCR_SMP_ATTRS (authored by andrew). · Explain WhySep 5 2024, 12:28 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG3a3aa2cc0756: arm64: Remove TCR_CACHE_ATTRS and TCR_SMP_ATTRS.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

locore.S

5 lines

include/

armreg.h

8 lines

Diff 142961

View Options

sys/arm64/arm64/locore.S