vm_page: drop mpred from grab_valid_iter()
ClosedPublic
Actions

Authored by dougm on May 20 2025, 3:19 AM.

Details

Reviewers

markj
kib
alc

Commits

rG142bcdad1f67: vm_page: drop mpred from grab_valid_iter()
rG0f941203ac51: vm_page: drop mpred from grab_valid_iter()

Summary

Variable mpred in vm_page_grab_valid_iter() has become a write-only variable. Drop it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.May 20 2025, 3:19 AM

dougm created this revision.

kib accepted this revision.May 20 2025, 6:09 AM

This revision is now accepted and ready to land.May 20 2025, 6:09 AM

Closed by commit rG0f941203ac51: vm_page: drop mpred from grab_valid_iter() (authored by dougm). · Explain WhyMay 20 2025, 7:16 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG0f941203ac51: vm_page: drop mpred from grab_valid_iter().

Herald added a subscriber: imp. · View Herald TranscriptMay 20 2025, 7:16 AM

dougm added a reverting change: rGc8ffb90b1dd3: Revert "vm_page: drop mpred from grab_valid_iter()".May 20 2025, 8:10 AM

Fixed.

dougm reopened this revision.May 20 2025, 8:18 AM

dougm added a reviewer: alc.May 24 2025, 10:06 PM

alc accepted this revision.May 25 2025, 6:31 AM

alc added inline comments.

sys/vm/vm_page.c
4932–4933	vm_page_alloc_iter(VM_ALLOC_WAITFAIL) performs the reset.

This revision is now accepted and ready to land.May 25 2025, 6:31 AM

Closed by commit rG142bcdad1f67: vm_page: drop mpred from grab_valid_iter() (authored by dougm). · Explain WhyMay 25 2025, 9:15 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG142bcdad1f67: vm_page: drop mpred from grab_valid_iter().

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_page.c

8 lines

Diff 156024

View Options

vm_page: drop mpred from grab_valid_iter()ClosedPublicActions