Page MenuHomeFreeBSD
Differential D50729

pctrie_lookup_node: assume parent_out != NULL
ClosedPublic
Actions

Authored by dougm on Jun 6 2025, 6:16 PM.
Tags
None
Referenced Files
F167305222: D50729.diff
Thu, Aug 20, 7:41 PM
Unknown Object (File)
Tue, Aug 18, 6:03 PM
Unknown Object (File)
Thu, Aug 13, 5:47 PM
Unknown Object (File)
Thu, Aug 13, 5:46 PM
Unknown Object (File)
Tue, Aug 11, 6:35 PM
Unknown Object (File)
Sun, Aug 9, 6:44 PM
Unknown Object (File)
Fri, Aug 7, 5:50 PM
Unknown Object (File)
Mon, Aug 3, 2:32 AM
View All Files
Subscribers
imp
olce

Details

Reviewers
alc
Commits
rG7908b5df1abd: pctrie_lookup_node: assume parent_out != NULL
Summary

Since NULL is never passed as the parent_out parameter to _pctrie_lookup_node, stop making the assignment to *parent_out check parent_out for NULL first.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 6 2025, 6:16 PM
dougm created this revision.
alc accepted this revision.Jun 6 2025, 6:44 PM
This revision is now accepted and ready to land.Jun 6 2025, 6:44 PM
Closed by commit rG7908b5df1abd: pctrie_lookup_node: assume parent_out != NULL (authored by dougm). · Explain WhyJun 6 2025, 8:25 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG7908b5df1abd: pctrie_lookup_node: assume parent_out != NULL.
Herald added subscribers: olce, imp. · View Herald TranscriptJun 6 2025, 8:25 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
3 lines

Diff 156656

View Options

sys/kern/subr_pctrie.c

Loading...