Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

kib requested review of D47834: fileno(3): set errno when returning -1.
Thu, Nov 28, 10:40 PM
kib added inline comments to D47394: x86: Add routines for querying XSAVE feature information.
Thu, Nov 28, 7:19 PM
kib added inline comments to D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Thu, Nov 28, 7:08 PM
kib added a reviewer for D47830: Fix various opt_kbd.h related built error in hid module: wulf.
Thu, Nov 28, 7:03 PM
kib added inline comments to D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Thu, Nov 28, 2:15 PM
kib added inline comments to D47822: fix build with LOCK_PROFILING but without KDTRACE_HOOKS.
Thu, Nov 28, 1:42 PM
kib committed rG1c65ea28841a: efirt: Fix the TDP_EFIRT assertion (authored by markj).
efirt: Fix the TDP_EFIRT assertion
Thu, Nov 28, 1:31 PM
kib committed rG7efa3a6028ce: fhreadlink.2: fix old typo in the manpage (authored by wosch).
fhreadlink.2: fix old typo in the manpage
Thu, Nov 28, 1:31 PM
kib committed rGab6a6a092834: kern___realpathat(): style (authored by kib).
kern___realpathat(): style
Thu, Nov 28, 1:31 PM
kib committed rG5f5b47e37416: amd64 efi rt: handle #BP (authored by kib).
amd64 efi rt: handle #BP
Thu, Nov 28, 1:30 PM
kib committed rG617e683319be: efirt: mark dynamic region executing the RT code with the TDP_EFIRT flag (authored by kib).
efirt: mark dynamic region executing the RT code with the TDP_EFIRT flag
Thu, Nov 28, 1:30 PM

Wed, Nov 27

kib added inline comments to D47782: procctl.2: Editing pass.
Wed, Nov 27, 10:51 PM
kib committed rG45d108ee147c: pf_route6(): one more __sdt_used annotation (authored by kib).
pf_route6(): one more __sdt_used annotation
Wed, Nov 27, 2:32 PM
kib committed rG73cc71607d37: rtld: drop RTLD_INIT_PAGESIZES_EARLY (authored by kib).
rtld: drop RTLD_INIT_PAGESIZES_EARLY
Wed, Nov 27, 11:33 AM

Tue, Nov 26

kib committed rG3f0289ea7f66: dmar: set acpi ivar domain on identify() (authored by kib).
dmar: set acpi ivar domain on identify()
Tue, Nov 26, 10:01 PM
kib committed rG7dd1f0dcd134: acpica: add domain ivar (authored by kib).
acpica: add domain ivar
Tue, Nov 26, 10:01 PM
kib closed D47291: acpi bus: store children domain in ivar.
Tue, Nov 26, 10:01 PM
kib committed rG6f423295f18a: acpica: rename acpi_parse_pxm() to acpi_pxm_parse() and make it non-static (authored by kib).
acpica: rename acpi_parse_pxm() to acpi_pxm_parse() and make it non-static
Tue, Nov 26, 10:01 PM
kib committed rG28fdf718b30b: amd64: add machine/pte.h (authored by kib).
amd64: add machine/pte.h
Tue, Nov 26, 7:49 PM
kib closed D47749: amd64: add machine/pte.h.
Tue, Nov 26, 7:48 PM
kib abandoned D47768: amdiommu_create_dev_tbl(): eliminate magic '3'.
Tue, Nov 26, 6:39 PM
kib added a comment to D47768: amdiommu_create_dev_tbl(): eliminate magic '3'.
In D47768#1089266, @jah wrote:

Oops, I didn't see this until after I wrote and tested my own version: https://reviews.freebsd.org/D47769

Tue, Nov 26, 6:38 PM
kib accepted D47769: amdiommu: use static device table base register offset array.
Tue, Nov 26, 6:38 PM
kib accepted D47767: swap_pager: fix seek_data with invalid first page.
Tue, Nov 26, 6:11 PM
kib added inline comments to D47752: amdiommu: Fix device table segment base register offsets.
Tue, Nov 26, 6:07 PM
kib requested review of D47768: amdiommu_create_dev_tbl(): eliminate magic '3'.
Tue, Nov 26, 6:07 PM
kib added inline comments to D47752: amdiommu: Fix device table segment base register offsets.
Tue, Nov 26, 1:32 PM
kib committed rG4cc5d081d8c2: mlx5en: only enable to toggle offload caps if they are supported (authored by kib).
mlx5en: only enable to toggle offload caps if they are supported
Tue, Nov 26, 12:35 PM
kib committed rGcca0dc49e0ca: mlx5en: move runtime capabilities checks into helper functions (authored by kib).
mlx5en: move runtime capabilities checks into helper functions
Tue, Nov 26, 12:35 PM
kib accepted D47741: kern: restore signal mask before ast() for pselect/ppoll.
Tue, Nov 26, 12:22 AM
kib added inline comments to D47741: kern: restore signal mask before ast() for pselect/ppoll.
Tue, Nov 26, 12:08 AM

Mon, Nov 25

kib accepted D47752: amdiommu: Fix device table segment base register offsets.
Mon, Nov 25, 11:40 PM
kib requested review of D47749: amd64: add machine/pte.h.
Mon, Nov 25, 11:14 PM
kib accepted D47741: kern: restore signal mask before ast() for pselect/ppoll.
Mon, Nov 25, 10:54 PM
kib added a comment to D47741: kern: restore signal mask before ast() for pselect/ppoll.
In D47741#1088837, @kib wrote:
In D47741#1088787, @kib wrote:

Is the problem caused by the fact that AST_SIG is processed before AST_SIGSUSPEND? Would reordering the AST indexes be enough?

As I understand, the complain is that signal ast handler might push the signal frame before sigsuspend handler restores the sigmask which marks the signal as blocked?

AST_SIG has to be processed before AST_SIGSUSPEND in order for the temporary signal mask stuff to work, AFAICT,

Do you mean AST_SIGSUSPEND scheduling from kern_sigsuspend()? If yes, then perhaps we need AST_SIGSUSPEND2, which is scheduled from pselect/ppoll and processed after AST_SIG.

I mean AST_SIGSUSPEND as scheduled from here- if seltdwait()'s sleep was interrupted by a signal, then my understanding is that we need to keep the temporary signal mask installed all the way until AST_SIG is done in order to process signals that are blocked by the old signal mask, but not by the temporary signal mask.

Mon, Nov 25, 10:05 PM
kib added a comment to D47741: kern: restore signal mask before ast() for pselect/ppoll.
In D47741#1088787, @kib wrote:

Is the problem caused by the fact that AST_SIG is processed before AST_SIGSUSPEND? Would reordering the AST indexes be enough?

As I understand, the complain is that signal ast handler might push the signal frame before sigsuspend handler restores the sigmask which marks the signal as blocked?

AST_SIG has to be processed before AST_SIGSUSPEND in order for the temporary signal mask stuff to work, AFAICT,

Mon, Nov 25, 9:10 PM
kib added a comment to D47741: kern: restore signal mask before ast() for pselect/ppoll.

Is the problem caused by the fact that AST_SIG is processed before AST_SIGSUSPEND? Would reordering the AST indexes be enough?

Mon, Nov 25, 8:18 PM
kib committed rGbde575b273ee: kern___realpathat(): honor uio_seg argument (authored by kib).
kern___realpathat(): honor uio_seg argument
Mon, Nov 25, 7:37 PM
kib committed rG67218bcea847: kern___realpathat(): do not copyout past end of string (authored by kib).
kern___realpathat(): do not copyout past end of string
Mon, Nov 25, 7:37 PM
kib committed rG31784ee1e37d: kern___realpathat(): style (authored by kib).
kern___realpathat(): style
Mon, Nov 25, 7:37 PM
kib closed D47739: kern___realpathat(): fix uninitialized memory read.
Mon, Nov 25, 7:37 PM
kib added a comment to D47739: kern___realpathat(): fix uninitialized memory read.
In D47739#1088673, @kib wrote:

Just realized that this is a kernel memory exposure.

Yes :(

It looks like the problem can happen "only" when a nullfs file mount is present?

Mon, Nov 25, 7:33 PM
kib retitled D47739: kern___realpathat(): fix uninitialized memory read from kern___readlink(): fix uninitialized memory read to kern___realpathat(): fix uninitialized memory read.
Mon, Nov 25, 7:01 PM
kib added a comment to D47739: kern___realpathat(): fix uninitialized memory read.

Just realized that this is a kernel memory exposure.

Mon, Nov 25, 7:00 PM
kib requested review of D47739: kern___realpathat(): fix uninitialized memory read.
Mon, Nov 25, 6:58 PM
kib committed rG6ec4ff70885d: amd64: switch pmap_map_io_transient() to use pmap_kenter_attr() (authored by kib).
amd64: switch pmap_map_io_transient() to use pmap_kenter_attr()
Mon, Nov 25, 12:21 PM
kib committed rG2d6923790b16: amd64 pmap: assert and explain why pmap_qremove() is safe WRT supermappings (authored by kib).
amd64 pmap: assert and explain why pmap_qremove() is safe WRT supermappings
Mon, Nov 25, 12:21 PM
kib closed D47717: Tweaks for pmap_qremove() and transient mappings.
Mon, Nov 25, 12:21 PM
kib accepted D47729: vm: Retire an unused declaration.
Mon, Nov 25, 10:25 AM

Sun, Nov 24

kib accepted D47718: vm_map: replace list links with iterator.
Sun, Nov 24, 8:02 AM

Sat, Nov 23

kib requested review of D47717: Tweaks for pmap_qremove() and transient mappings.
Sat, Nov 23, 9:07 PM
kib added inline comments to D47678: arm64: Implement pmap_map_io_transient.
Sat, Nov 23, 6:54 PM
kib committed rG253a1fa16b98: mlx5: Fix handling of port_module_event (authored by Ariel Ehrenberg <aehrenberg@nvidia.com>).
mlx5: Fix handling of port_module_event
Sat, Nov 23, 11:01 AM
kib committed rG0d38b0bc8fbc: mlx5en: fix the sign of mlx5e_tls_st_init() error, convert from Linux to BSD (authored by kib).
mlx5en: fix the sign of mlx5e_tls_st_init() error, convert from Linux to BSD
Sat, Nov 23, 10:22 AM
kib committed rG81b38bce0794: mlx5e tls: Ensure all allocated tags have a hw context associated (authored by gallatin).
mlx5e tls: Ensure all allocated tags have a hw context associated
Sat, Nov 23, 10:05 AM
kib committed rG7fbc896e28e4: vm_page.c: remove transiently defined vm_page_free_toq_impl() prototype (authored by kib).
vm_page.c: remove transiently defined vm_page_free_toq_impl() prototype
Sat, Nov 23, 10:05 AM
kib committed rG64bf5a431cbe: mlx5_en: style function prototype (authored by kib).
mlx5_en: style function prototype
Sat, Nov 23, 10:05 AM

Fri, Nov 22

kib added inline comments to D47678: arm64: Implement pmap_map_io_transient.
Fri, Nov 22, 11:22 PM
kib added inline comments to D47678: arm64: Implement pmap_map_io_transient.
Fri, Nov 22, 8:50 AM
kib added inline comments to D47694: amd64 efi rt: handle #BP.
Fri, Nov 22, 8:46 AM

Thu, Nov 21

kib committed rGe6ec41fa86d8: amd64 efi rt: handle #BP (authored by kib).
amd64 efi rt: handle #BP
Thu, Nov 21, 10:06 PM
kib committed rGa03957a706a0: efirt: mark dynamic region executing the RT code with the TDP_EFIRT flag (authored by kib).
efirt: mark dynamic region executing the RT code with the TDP_EFIRT flag
Thu, Nov 21, 10:06 PM
kib closed D47694: amd64 efi rt: handle #BP.
Thu, Nov 21, 10:06 PM
kib added inline comments to D47694: amd64 efi rt: handle #BP.
Thu, Nov 21, 8:09 PM
kib updated the diff for D47694: amd64 efi rt: handle #BP.

Mark rt call region with TDP_EFIRT. It allows to not depend on the implementation detail of disabling page faults in the region.

Thu, Nov 21, 7:43 PM
kib accepted D47696: buf: Add a runningbufclaim() helper.
Thu, Nov 21, 7:37 PM
kib added a comment to D47694: amd64 efi rt: handle #BP.

Reformulating what @imp said, loader is executing in EFI boot services environment, while EFI RT is EFI runtime services client. The switch is supposed to pass ownership of the machine to OS, and also the rt code must be relocated. The later is known to be often buggy. This is why I implemented onfault handling for RT calls.

Thu, Nov 21, 7:27 PM
kib updated the diff for D47694: amd64 efi rt: handle #BP.

Reorder checks. Explain why I did not wanted to do it initially.

Thu, Nov 21, 4:07 PM
kib accepted D47692: device_pager: user iterators to free device pages.
Thu, Nov 21, 10:34 AM
kib updated the diff for D47694: amd64 efi rt: handle #BP.

Add some debugging

Thu, Nov 21, 10:24 AM
kib requested review of D47694: amd64 efi rt: handle #BP.
Thu, Nov 21, 5:01 AM

Wed, Nov 20

kib accepted D47681: sh(1): add -l option.
Wed, Nov 20, 12:31 PM
kib committed rG5bc24fd7a21f: rtld: drop RTLD_INIT_PAGESIZES_EARLY (authored by kib).
rtld: drop RTLD_INIT_PAGESIZES_EARLY
Wed, Nov 20, 8:17 AM
kib added inline comments to D47678: arm64: Implement pmap_map_io_transient.
Wed, Nov 20, 7:54 AM
kib accepted D47678: arm64: Implement pmap_map_io_transient.
Wed, Nov 20, 6:15 AM

Tue, Nov 19

kib accepted D47672: vfs: Fix vop_stdis_text().
Tue, Nov 19, 4:01 PM
kib accepted D47672: vfs: Fix vop_stdis_text().

So currently ETXTBSY does not work?

Tue, Nov 19, 3:14 PM
kib committed rGab2dfb93e372: ps.1: remove stray tab which breaks columns alignment (authored by kib).
ps.1: remove stray tab which breaks columns alignment
Tue, Nov 19, 5:21 AM
kib committed rG8925ea58c206: mlx5en: improve reporting of kernel TLS, IPSEC offload, and ratelimit caps (authored by kib).
mlx5en: improve reporting of kernel TLS, IPSEC offload, and ratelimit caps
Tue, Nov 19, 5:20 AM
kib closed D47523: SU+J: all writes to SU journal must be exempt from runningbufspace throttling.
Tue, Nov 19, 1:21 AM

Mon, Nov 18

kib committed rG645f8bcba9c8: ps.1: remove stray tab which breaks columns alignment (authored by kib).
ps.1: remove stray tab which breaks columns alignment
Mon, Nov 18, 12:25 PM
kib accepted D47647: Speed up syncer shutdown.
Mon, Nov 18, 12:38 AM

Sun, Nov 17

kib accepted D47644: vm: static-ize vm_page_alloc_after().
Sun, Nov 17, 5:49 AM

Sat, Nov 16

kib accepted D47630: atomic.9: Document atomic_testand*_64 and atomic_testandset_acq_long.
Sat, Nov 16, 7:01 PM
kib accepted D47629: atomic(9): Remove fcmpset-based fallback for atomic_testand(clear|set).
Sat, Nov 16, 6:59 PM
kib accepted D47628: arm: Implement atomic_testandset_acq_long as a simple wrapper.
Sat, Nov 16, 6:58 PM
kib accepted D47627: riscv: Add implementations of atomic_testand(set|clear)_(32|64|long).
Sat, Nov 16, 6:57 PM
kib accepted D47632: rangelock: Use atomic_testandset_ptr.
Sat, Nov 16, 1:50 AM
kib accepted D47631: atomic(9): Implement atomic_testand(clear|set)_ptr.
Sat, Nov 16, 1:49 AM
kib committed rG9b2226eef29a: SU+J: all writes to SU journal must be exempt from runningbufspace throttling (authored by kib).
SU+J: all writes to SU journal must be exempt from runningbufspace throttling
Sat, Nov 16, 1:42 AM
kib committed rGff7de7aa49fa: bufwrite(): adjust the comment (authored by kib).
bufwrite(): adjust the comment
Sat, Nov 16, 1:41 AM
kib committed rG9d9a14c5b612: bufwrite(): style (authored by kib).
bufwrite(): style
Sat, Nov 16, 1:41 AM

Fri, Nov 15

kib accepted D47588: fork: document _Fork as POSIX 2024.
In D47588#1085785, @kib wrote:

My feeling is that it is strange to claim that fork is 2024. It costs nothing to say there specifically that it is -p1003.1 (might be even -88, but I do not have the text).

Fri, Nov 15, 10:46 PM
kib added a comment to D47588: fork: document _Fork as POSIX 2024.

My feeling is that it is strange to claim that fork is 2024. It costs nothing to say there specifically that it is -p1003.1 (might be even -88, but I do not have the text).

Fri, Nov 15, 10:17 PM
kib accepted D47583: aio: remove write-only jobid & kernelinfo.
Fri, Nov 15, 5:09 AM
kib added a comment to D47581: libc: indicate existing functions in POSIX 2024.

Also _Fork()

Fri, Nov 15, 3:55 AM

Thu, Nov 14

kib committed rG209fd89a2810: _dl_iterate_phdr_locked(): fix libc and libdl (authored by kib).
_dl_iterate_phdr_locked(): fix libc and libdl
Thu, Nov 14, 4:58 AM
kib closed D47563: _dl_iterate_phdr_locked(): fix libc and libdl.
Thu, Nov 14, 4:58 AM
kib requested review of D47563: _dl_iterate_phdr_locked(): fix libc and libdl.
Thu, Nov 14, 3:59 AM
kib committed rG092e2ff33be2: ps.1: restore always true if predicate (authored by kib).
ps.1: restore always true if predicate
Thu, Nov 14, 2:42 AM