fileno(3): set errno when returning -1
ClosedPublic
Actions

Authored by kib on Nov 28 2024, 10:40 PM.

Details

Reviewers

emaste
des
imp

Commits

rG7cd756ff4fe7: fileno(3): set errno when returning -1
rG35ac34a23bc0: stdio(3): correct summary information for fileno(3)

Summary

as required by IEEE Std 1003.1™-2024.

PR: 283014
Reported by: Graham Percival <gperciva@tarsnap.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Nov 28 2024, 10:40 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 28 2024, 10:40 PM

kib requested review of this revision.Nov 28 2024, 10:40 PM

imp accepted this revision.Nov 28 2024, 10:47 PM

This revision is now accepted and ready to land.Nov 28 2024, 10:47 PM

emaste accepted this revision.Nov 28 2024, 11:24 PM

Thanks for the quick patch!

To nitpick the summary, it should be "as required by IEEE Std 1003.1™-2016"

Direct link to it:
https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/functions/fileno.html

In D47834#1090509, @gperciva_tarsnap.com wrote:

Thanks for the quick patch!

To nitpick the summary, it should be "as required by IEEE Std 1003.1™-2016"

The first one is really 1003.1-2008. The 2016 edition is just nitpicky corrections...

Buy kib's reference is fine. It's not wrong.

Direct link to it:
https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/functions/fileno.html

Closed by commit rG35ac34a23bc0: stdio(3): correct summary information for fileno(3) (authored by kib). · Explain WhyNov 29 2024, 3:26 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG35ac34a23bc0: stdio(3): correct summary information for fileno(3).

kib added a commit: rG7cd756ff4fe7: fileno(3): set errno when returning -1.

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdio/

stdio.3

2 lines

Diff 147161

View Options

fileno(3): set errno when returning -1ClosedPublicActions