Page MenuHomeFreeBSD
Differential D47834

fileno(3): set errno when returning -1
ClosedPublic
Actions

Authored by kib on Thu, Nov 28, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:44 PM
Unknown Object (File)
Sun, Dec 1, 11:25 AM
Unknown Object (File)
Fri, Nov 29, 3:52 PM
Unknown Object (File)
Fri, Nov 29, 9:26 AM
Subscribers
gperciva_tarsnap.com
imp

Details

Reviewers
emaste
des
imp
Commits
rG7cd756ff4fe7: fileno(3): set errno when returning -1
rG35ac34a23bc0: stdio(3): correct summary information for fileno(3)
Summary

as required by IEEE Std 1003.1™-2024.




PR:     283014

Reported by:    Graham Percival <gperciva@tarsnap.com>
Diff Detail
Repository 
rG FreeBSD src repository 
Lint 
Lint Skipped
 
Unit 
Tests Skipped
 
Event Timeline
kib created this revision.Thu, Nov 28, 10:40 PM
Herald added a subscriber: imp.  ·  View Herald TranscriptThu, Nov 28, 10:40 PM
kib requested review of this revision.Thu, Nov 28, 10:40 PM
imp accepted this revision.Thu, Nov 28, 10:47 PM
This revision is now accepted and ready to land.Thu, Nov 28, 10:47 PM
emaste accepted this revision.Thu, Nov 28, 11:24 PM
gperciva_tarsnap.com added a subscriber: gperciva_tarsnap.com.Fri, Nov 29, 2:25 AM
Thanks for the quick patch!



To nitpick the summary, it should be "as required by IEEE Std 1003.1™-2016"



Direct link to it:

https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/functions/fileno.html
imp added a comment.Fri, Nov 29, 2:53 AM


In D47834#1090509, @gperciva_tarsnap.com wrote:


Thanks for the quick patch!



To nitpick the summary, it should be "as required by IEEE Std 1003.1™-2016"





The first one is really 1003.1-2008. The 2016 edition is just nitpicky corrections...



Buy kib's reference is fine. It's not wrong.



Direct link to it:

https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/functions/fileno.html



Closed by commit rG35ac34a23bc0: stdio(3): correct summary information for fileno(3) (authored by kib).  ·  Explain WhyFri, Nov 29, 3:26 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG35ac34a23bc0: stdio(3): correct summary information for fileno(3).
kib added a commit: rG7cd756ff4fe7: fileno(3): set errno when returning -1.
Revision Contents
Changeset List
PathSize
include/
4 lines
lib/
libc/
stdio/
20 lines
25 lines
2 lines
Diff 147136
View Options
include/stdio.h
Loading...
View Options
lib/libc/stdio/ferror.3
Loading...
View Options
lib/libc/stdio/fileno.c
Loading...
View Options
lib/libc/stdio/stdio.3
Loading...