Differential D47717

Tweaks for pmap_qremove() and transient mappings
ClosedPublic
Actions

Authored by kib on Nov 23 2024, 9:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 4, 10:18 PM

	Unknown Object (File)
	Wed, Nov 26, 8:59 AM

	Unknown Object (File)
	Sat, Nov 22, 10:48 AM

	Unknown Object (File)
	Sat, Nov 22, 10:47 AM

	Unknown Object (File)
	Sat, Nov 22, 10:32 AM

	Unknown Object (File)
	Sat, Nov 22, 10:29 AM

	Unknown Object (File)
	Fri, Nov 21, 4:10 AM

	Unknown Object (File)
	Wed, Nov 12, 12:07 PM

View All 76 Files

Subscribers

Details

Reviewers

alc
markj

Commits

rG6ec4ff70885d: amd64: switch pmap_map_io_transient() to use pmap_kenter_attr()
rG2d6923790b16: amd64 pmap: assert and explain why pmap_qremove() is safe WRT supermappings

Summary

amd64: switch pmap_map_io_transient() to use pmap_kenter_attr()

instead of constructing transient pte itself.  This pre-set PG_A and
PG_M bits, avoiding atomic pte update on access and modification.  Also
it set the nx bit, the mapping is not supposed to be used for executing.

amd64 pmap: assert and explain why pmap_qremove() is safe WRT supermappings

Based on alc@ comments from https://reviews.freebsd.org/D47678.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Nov 23 2024, 9:07 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2024, 9:07 PM

kib requested review of this revision.Nov 23 2024, 9:07 PM

alc accepted this revision.Nov 24 2024, 11:18 PM

This revision is now accepted and ready to land.Nov 24 2024, 11:18 PM

Closed by commit rG2d6923790b16: amd64 pmap: assert and explain why pmap_qremove() is safe WRT supermappings (authored by kib). · Explain WhyNov 25 2024, 12:21 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG2d6923790b16: amd64 pmap: assert and explain why pmap_qremove() is safe WRT supermappings.

kib added a commit: rG6ec4ff70885d: amd64: switch pmap_map_io_transient() to use pmap_kenter_attr().

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

12 lines

Diff 146901

sys/amd64/amd64/pmap.c

Loading...