Page MenuHomeFreeBSD

kern_malloc: fold free and zfree together into one __always_inline func
ClosedPublic

Authored by bz on Jul 24 2024, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 11, 11:40 PM
Unknown Object (File)
Thu, Dec 11, 10:48 PM
Unknown Object (File)
Mon, Dec 1, 1:14 PM
Unknown Object (File)
Sun, Nov 30, 8:08 AM
Unknown Object (File)
Thu, Nov 27, 8:36 AM
Unknown Object (File)
Tue, Nov 25, 11:20 AM
Unknown Object (File)
Tue, Nov 25, 4:31 AM
Unknown Object (File)
Tue, Nov 25, 1:00 AM
Subscribers

Details

Summary

free() and zfree() are essentially the same copy and pasted code with
the extra explicit_bzero() (and kasan) calls. Add a bool to add the
extra functionality and make both functions a wrapper around the common
code and let the compiler do the optimization based on the bool input
when inlining.

No functional changes intended.

Suggested by: kib (in D45812)
Sponsored by: The FreeBSD Foundation
MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Jul 24 2024, 3:59 PM
kib added inline comments.
sys/kern/kern_malloc.c
935
This revision is now accepted and ready to land.Jul 24 2024, 4:19 PM
bz marked an inline comment as done.Jul 24 2024, 4:20 PM

Done locally.

This revision now requires review to proceed.Jul 24 2024, 4:23 PM
sys/kern/kern_malloc.c
944

Hmm, I'm not sure why I put these kasan_mark() calls in zfree(), but they are unnecessary and can be removed.

Remove kasan_mark calls as per @markj

bz marked an inline comment as done.Jul 25 2024, 12:56 PM
This revision is now accepted and ready to land.Jul 25 2024, 12:56 PM