Differential D45813

LinuxKPI: skbuff: adjust to updated malloc/contigmalloc and free(9).
Needs ReviewPublic
Actions

Authored by bz on Sun, Jun 30, 7:52 PM.

Tags

None

Referenced Files

	F87556907: D45813.diff
	Thu, Jul 4, 11:42 PM

	Unknown Object (File)
	Wed, Jul 3, 11:28 AM

	Unknown Object (File)
	Tue, Jul 2, 11:34 PM

	Unknown Object (File)
	Mon, Jul 1, 3:32 PM

Subscribers

Details

Reviewers

Summary

Simplify the code using the extended contigmalloc(9) which means we
(a) no longer have to remember our allocation size, and (b) we can
call free(9) independent of the allocator (malloc or contigmalloc).

This will likely also allow us to make the TUNABLE a SYSCTL in the
future, allow drivers to change it on the fly (at least lowering the
limit) and with that removing the need for user adjustments.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 58430
Build 55318: arc lint + arc unit

Event Timeline

bz created this revision.Sun, Jun 30, 7:52 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Jun 30, 7:52 PM

bz requested review of this revision.Sun, Jun 30, 7:52 PM

Harbormaster completed remote builds in B58430: Diff 140407.Sun, Jun 30, 7:52 PM

bz added a parent revision: D45812: malloc(9): extend contigmalloc(9) by a "slab cookie".Sun, Jun 30, 7:52 PM

s/siplify/simplify/ in the commit message

bz edited the summary of this revision. (Show Details)Sun, Jun 30, 8:09 PM

bz added inline comments.Sun, Jun 30, 8:32 PM

sys/compat/linuxkpi/common/src/linux_skbuff.c
100	@jhb This should likely be len > PAGE_SIZE only and not >= ?

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

1 line

src/

42 lines

Diff 140407

sys/compat/linuxkpi/common/include/linux/skbuff.h

Loading...

sys/compat/linuxkpi/common/src/linux_skbuff.c

Loading...