• Fix the two QCA entries which depend on two packages
• Update the comments on Intel iwlwifi removing some initial logic in favor of a script (it is currently two but I'll try to clean it up and add it either to src or ports to generate both the fwget case pattern and the ports flavor->firmware files list generation)

In D44918#1024641, @manu wrote:

Looks better now, thanks a lot.

In D44918#1024544, @imp wrote:

I don't suppose that yhese could be generated automatically? It's a huge table to maintain by hand...

Is is likely mis-sorted in the stack as this should go after D44922?

Are you going to change the few drivers which need change to get rid of the public exposure as well? Otherwise this is a dead code before added.

I haven't reviewed the actual function changes yet; just scrolled through

Update to fine(r) grained flavored packages.

In D44918#1024287, @manu wrote:

wifi-firmware-iwlwifi-kmod doesn't seems to exists ?

In D44906#1023889, @markj wrote:

In D44906#1023888, @bz wrote:

In D44906#1023886, @emaste wrote:

Should we change the in-kernel default as well? It will normally be overridden by the rc.conf setting so it doesn't have a practical impact but probably good for consistency.

Would NFS Root be affected by that? Hmm it's a tunable so less of a problem in case people do have trouble.

This is a server setting, so I wouldn't expect so.

In D44906#1023886, @emaste wrote:

Should we change the in-kernel default as well? It will normally be overridden by the rc.conf setting so it doesn't have a practical impact but probably good for consistency.

In D44906#1023836, @rmacklem wrote:

lgtm. I cannot recall if there is any man page change
needed for this?

@cc Adding LOCK asserts is a very good idea; not all the functions need them if I remember correctly. Should I really add it to this "fix" or should I do a separate full pass on the linux_80211_macops.c file?

Move the KASSERT/lsta assignment back to its original place;
I think the idea was to catch that state earlier on before more changes happen which could mask that situation but this change is really about the 2nd half so focus on that.

In D43967#1023740, @emaste wrote:

@bz I put this in my wipbsd tree on Feb 18, and I have been switching between that tree and main since then. I haven't observed any issue attributable to this change. I still do see one Invalid TXQ sometime in early boot.

I wonder if that'll support a lot more than just AX210?

@emaste have you been running with this change the last months?

In D44827#1023208, @adrian wrote:

eg ath(4) would do something like:

Thanks. If no one complains the next days I'll put this in.

Can we shorten hardware/software to hw/sw?

Nice tracking down.
Is there a PR for this somewhere we need to reference?

Any comments on this?

@emaste it seems most attributes in cdef.h have the __x__ instea dof just x. This seems to work with gcc as well for as much as I could test. It seems up-to gcc14-devel non of our gccs recognizes the counter_by in either spelling.

Does this give any information pciconf -l would not already give? I would rather we'd improve our tooling than use a sysctl for that? I'd almost want something like ifconfig -g bridge -l in devctl or somewhere appropriate?

@emaste is the logic correct now?

I will simply express that this will not only open a can of worms by mixing both but the original reasons not to include VRRPv2/3 and hence the "existence" of CARP is also ignored.
Should people think this can go in, I would highly advise to make it 100% compile time option and there's quite a few things to polish (including quoting from copyrighted material without reference).

add logic for counted_by and also add __nonstring

In D44306#1020417, @jhb wrote:

Oh, if it is just a global symbol that isn't a ton of work to handle. You just need to recognize that symbol name when resolving symbols and resolve the pointer to the right thing instead. Probably what we would want to do is having __this_module store the pointer to the current linker_file_t when you are resolving symbols and require it to be the same size as a pointer.

In D44306#1020400, @jhb wrote:

I do think that GCC and clang (and really ld.bfd and lld) will collapse duplicate copies of the same anonymous string down to the same storage.

However, is insmod equivalent to just kldload and is __this_module only valid during then? If so, you can hang a suitable pointer to the current struct linker_file off of struct thread that gets set during kldload(2) and cleared before it exits (probably a bit further down in linker_load_file or the like). Then you can #define __this_module to something like curthread->td_current_linker_file with a suitable wrapper cast or whatever.

THANK YOU!

At this point I will ask -- has anyone considered checking how much linker work would be needed for this?

@salvadore can I commit this? Anything further to do?

@salvadore can I commit this? Anything further to do?

Got imported along the whole file in https://cgit.FreeBSD.org/src/commit/?id=3208d4ad2b8320a24af4a8293f7fd3ef9c35caa6

In D44587#1018196, @emaste wrote:

From a textcase in the LLVM review that introduced it (https://reviews.llvm.org/D148381):

#if !__has_attribute(counted_by)
#error "has attribute broken"
#endif

#ifdef COUNTED_BY
#define __counted_by(member)    __attribute__((__counted_by__(member)))
#else
#define __counted_by(member)
#endif

In D44587#1016767, @emaste wrote:

In general __has_attribute(foo) to check
I think this is fine to get the driver compiling but ought to have a TODO comment

You made me have a look; grep -r HAVE_EXPLICIT_BZERO seems to be a pattern which reveals a few more implementations in the tree; we should probably make sure if we migrate this into more general code to make sure we set the appropriate #defines for the various kernel code bits to switch to the one common implementation then; I'll leave it for someone who can better drive this at this point.

In D44583#1017689, @emaste wrote:

I don't know if the code path in drm_encoder_slave.c actually uses this

I don't think the change in this review should have any effect - we just go from discarding the returned fileid to not requesting it at all.

I don't know if the code path in drm_encoder_slave.c actually uses this; I hit it in iwlwifi yesterday and still have to investigate but having this run from kldloading a module made the system hang in a way that ^T did not work anymore on the console.

Update with some more

Okay, let's see if it is correct now?

Fix logic from NOP to doing something.