Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

bz committed rS352352: MFC 346554,346556,346595,348060,348061,348494 udp locking fixes.
MFC 346554,346556,346595,348060,348061,348494 udp locking fixes
Sun, Sep 15, 8:16 AM

Fri, Sep 13

bz requested changes to D21636: Filter TCP connections to SO_REUSEPORT_LB listen sockets by NUMA domain.
Fri, Sep 13, 3:19 PM

Wed, Sep 11

bz accepted D21591: avoid unneeded call to arc4random() in syncache_add().
Wed, Sep 11, 1:39 PM

Thu, Aug 22

bz committed rS351388: usb: fix usb_fdt_support.c when altq enabled (usb_ehernet.h changes).
usb: fix usb_fdt_support.c when altq enabled (usb_ehernet.h changes)
Thu, Aug 22, 9:25 AM
bz committed rS351385: w: initialize save_p to silence 'may be used uninitilized'.
w: initialize save_p to silence 'may be used uninitilized'
Thu, Aug 22, 7:52 AM

Wed, Aug 21

bz committed rS351329: gprof: disable building of a.out components.
gprof: disable building of a.out components
Wed, Aug 21, 10:55 AM
bz committed rS351327: athhal: disable unused function (big endian only).
athhal: disable unused function (big endian only)
Wed, Aug 21, 10:42 AM

Mon, Aug 19

D20967: new MAC policy module - mac_ipacl is now accepted and ready to land.
Mon, Aug 19, 1:22 PM · GSoC Students, GSoC Admins

Aug 12 2019

bz resigned from D21186: Convert ng_deflate to use new zlib..
Aug 12 2019, 8:48 AM
bz added inline comments to D20655: Make use of stats(3) in the TCP stack.
Aug 12 2019, 7:05 AM

Aug 9 2019

bz added inline comments to D20655: Make use of stats(3) in the TCP stack.
Aug 9 2019, 3:21 PM
bz added reviewers for D20655: Make use of stats(3) in the TCP stack: tuexen, rscheff_gmx.at, rrs.

Adding TCP folks explicitly as reviewers.

Aug 9 2019, 3:10 PM
bz added a comment to D20967: new MAC policy module - mac_ipacl.

There's a couple of public IP(v6) addresses in the test scripts. We'd prefer not to have accidents with people. Can you please change them?

Aug 9 2019, 8:53 AM · GSoC Students, GSoC Admins

Aug 8 2019

bz committed rS350748: frag6: move public structure into file local space..
frag6: move public structure into file local space.
Aug 8 2019, 11:00 AM
bz committed rS350747: frag6.c: cleanup varaibles and return statements..
frag6.c: cleanup varaibles and return statements.
Aug 8 2019, 10:16 AM
bz committed rS350746: frag6.c: initial comment and whitespace cleanup..
frag6.c: initial comment and whitespace cleanup.
Aug 8 2019, 9:43 AM

Aug 7 2019

bz accepted D21178: Rename IPPROTO 33 from SEP to DCCP.
Aug 7 2019, 3:52 PM

Aug 5 2019

bz committed rS350585: frag6.c: rename ip6q[] to ipq6b[] and consistently use "bucket".
frag6.c: rename ip6q[] to ipq6b[] and consistently use "bucket"
Aug 5 2019, 11:01 AM
bz committed rS350584: frag6.c: re-order functions within file.
frag6.c: re-order functions within file
Aug 5 2019, 9:49 AM

Aug 3 2019

bz committed rS350559: frag6.c: fix includes.
frag6.c: fix includes
Aug 3 2019, 4:56 PM

Aug 2 2019

bz committed rS350536: frag6.c: make compile with gcc.
frag6.c: make compile with gcc
Aug 2 2019, 11:05 AM
bz committed rS350535: frag6.c: rename malloc type.
frag6.c: rename malloc type
Aug 2 2019, 10:55 AM
bz committed rS350534: frag6.c: remove dead code.
frag6.c: remove dead code
Aug 2 2019, 10:42 AM
bz committed rS350533: frag6.c: move variables and sysctls into local file.
frag6.c: move variables and sysctls into local file
Aug 2 2019, 10:30 AM
bz committed rS350532: frag6.c: sort includes.
frag6.c: sort includes
Aug 2 2019, 10:07 AM
bz committed rS350531: IPv6 cleanup: kernel.
IPv6 cleanup: kernel
Aug 2 2019, 7:42 AM

Aug 1 2019

bz committed rS350522: IPv6 cleanup: netstat.
IPv6 cleanup: netstat
Aug 1 2019, 8:36 PM

Jul 31 2019

bz added a comment to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

In addition to the other comments I still nowhere see a loop that walks the entire extension header chain. If you don't do that you cannot fulfil the requirement you are trying to solve. What am I missing?

Jul 31 2019, 2:45 PM
D16850: Update the fragment reassembly code's handling of overlapping fragments to conform to RFC 8200. now requires changes to proceed.

I changed my mind...

Jul 31 2019, 12:30 PM

Jul 30 2019

bz added inline comments to D20967: new MAC policy module - mac_ipacl.
Jul 30 2019, 10:59 PM · GSoC Students, GSoC Admins
bz added a comment to D16847: Eliminate KAME custom circular queues in reassembly code..

Just as a comment: I finally figured out what's so confusing when reading this these days. The ip6q[] is the buckets and not of struct ip6q anymore; sadly struct ip6q is a public interface used inside the MAC framework so don't want to break that by renaming it.

Jul 30 2019, 4:38 PM

Jul 24 2019

bz added a comment to D20967: new MAC policy module - mac_ipacl.

Grat work on the cleanup; I think apart from the license there is very few minor nits left which are acceptable.

Jul 24 2019, 1:34 PM · GSoC Students, GSoC Admins

Jul 22 2019

bz added a comment to D20967: new MAC policy module - mac_ipacl.

I have a few doubts:

  • I'm not clear about the license, should the TrustedBSD be included? if yes, then how? Also, I have copied the sysctl_rules from mac_portacl, Is it infringing any copyright as of now? I've read BSD license is very open, can I mention the mac_portacl?
Jul 22 2019, 2:11 PM · GSoC Students, GSoC Admins
D20967: new MAC policy module - mac_ipacl now requires changes to proceed.

Hey, thank you for all the updates. There are a few more. Please let me know when you think you are done with all of them and I'll have a full look again.

Jul 22 2019, 10:36 AM · GSoC Students, GSoC Admins

Jul 17 2019

bz added a comment to D20967: new MAC policy module - mac_ipacl.

I think sys/security/mac_ipacl/design_notes.txt and sys/security/mac_ipacl/notes.txt can be removed. Should be turned into a man page really!?

Jul 17 2019, 10:42 AM · GSoC Students, GSoC Admins

Jul 13 2019

bz added a comment to D20936: Fix a race in udp6_output.

Thanks, was still on my TODO. Always happy if someone does the work for me :-)

Jul 13 2019, 10:01 AM

Jun 17 2019

bz added a comment to D16851: Add support for header chain validation on IPv6 Fragments (RFC7112).

I have a kind-of stupid question: where in all this do you actually walk an entire header chain to the end rather than just checking the next one? Are there no cases when this might be needed?

Jun 17 2019, 9:29 AM

Jun 13 2019

bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

Over in powerpc land, we've been chasing crashes with dpcpu and vnet as well. Our current prospective fix is https://reviews.freebsd.org/D20461 but we don't understand why it seems to fix it.

Jun 13 2019, 7:14 PM
bz added a comment to D20461: [PowerPC64] Don't mark module data as static on PowerPC64 - Fixes panic when loading ipfw.ko and if_epair.ko built with modern compiler..

Does this patch fix your issues?
https://svnweb.freebsd.org/base?view=revision&revision=336909 has a brief explanation of the problem; can you look at the code and see if you get a similar problem, just to confirm (and for you to understand as-to why that is?

Jun 13 2019, 7:12 PM

Jun 10 2019

bz committed rS348885: A bit of code hygiene (no functional changes)..
A bit of code hygiene (no functional changes).
Jun 10 2019, 11:25 PM
bz committed rS348878: Add a bus_add_child device method to bcm2835_sdhci..
Add a bus_add_child device method to bcm2835_sdhci.
Jun 10 2019, 9:25 PM
bz committed rS348861: Enhance the comment ieee80211_add_channel() to avoid a.
Enhance the comment ieee80211_add_channel() to avoid a
Jun 10 2019, 2:31 PM
bz committed rS348860: allwinner mmc: move variable assignment into block.
allwinner mmc: move variable assignment into block
Jun 10 2019, 1:46 PM

Jun 8 2019

bz committed rD53126: Document __FreeBSD_version bump to 1300031 with src r348808.
Document __FreeBSD_version bump to 1300031 with src r348808
Jun 8 2019, 6:14 PM
bz committed rS348808: Fix dpcpu and vnet panics with complex types at the end of the section..
Fix dpcpu and vnet panics with complex types at the end of the section.
Jun 8 2019, 5:44 PM
bz closed D17512: Fix dpcpu and vnet panics with complex types at the end of the section.
Jun 8 2019, 5:44 PM
bz added inline comments to D19749: Add a CAM-Newbus SDIO support module..
Jun 8 2019, 5:39 PM
bz committed rS348807: Remove extra stray + from a diff from the beginning of the lines after.
Remove extra stray + from a diff from the beginning of the lines after
Jun 8 2019, 5:38 PM
bz committed rS348805: Add SDIO support..
Add SDIO support.
Jun 8 2019, 4:27 PM
bz closed D19749: Add a CAM-Newbus SDIO support module..
Jun 8 2019, 4:27 PM
bz closed D20199: bcm2835_sdhci.c: exit DMA if not enough data left to avoid timeout errors.
Jun 8 2019, 4:15 PM
bz committed rS348804: bcm2835_sdhci.c: exit DMA if not enough data left to avoid timeout errors.
bcm2835_sdhci.c: exit DMA if not enough data left to avoid timeout errors
Jun 8 2019, 4:15 PM
bz closed D20197: bcm2835_sdhci.c: save block registers to avoid controller bug.
Jun 8 2019, 4:05 PM
bz committed rS348803: bcm2835_sdhci.c: save block registers to avoid controller bug.
bcm2835_sdhci.c: save block registers to avoid controller bug
Jun 8 2019, 4:05 PM
bz closed D19747: Improve sdhci slot_printf() debug printing..
Jun 8 2019, 3:24 PM
bz committed rS348801: Improve sdhci slot_printf() debug printing..
Improve sdhci slot_printf() debug printing.
Jun 8 2019, 3:24 PM
bz committed rS348800: Introduce sim_dev and cam_sim_alloc_dev()..
Introduce sim_dev and cam_sim_alloc_dev().
Jun 8 2019, 3:20 PM
bz closed D19746: Introduce sim_dev and cam_sim_alloc_dev()..
Jun 8 2019, 3:20 PM

Jun 4 2019

bz committed rS348671: Rather than using the legacy IP struct fields in the union for the.
Rather than using the legacy IP struct fields in the union for the
Jun 4 2019, 8:53 PM

Jun 1 2019

bz added a comment to D20199: bcm2835_sdhci.c: exit DMA if not enough data left to avoid timeout errors.

I'd like to commit this the next days. Can someone please review? If not it'll go in by Sat 8 June.

Jun 1 2019, 5:47 PM
bz added a comment to D20197: bcm2835_sdhci.c: save block registers to avoid controller bug.

I'd like to commit this the next days. Can someone please review? If not it'll go in by Sat 8 June.

Jun 1 2019, 5:46 PM
bz added a comment to D19749: Add a CAM-Newbus SDIO support module..

Warner if you have any further comments .. I'd like to commit this the next days. If not it'll go in by Sat 8 June.

Jun 1 2019, 5:46 PM
bz added a comment to D19747: Improve sdhci slot_printf() debug printing..

I'd like to commit this the next days. Can someone please review? If not it'll go in by Sat 8 June.

Jun 1 2019, 5:46 PM
bz added a comment to D19746: Introduce sim_dev and cam_sim_alloc_dev()..

I'd like to commit this the next days. Can someone please review? If not it'll go in by Sat 8 June.

Jun 1 2019, 5:45 PM
bz added inline comments to D19749: Add a CAM-Newbus SDIO support module..
Jun 1 2019, 3:49 PM
bz closed D20338: Fix a race condition in udp_output().

https://svnweb.freebsd.org/changeset/base/348494 missed the Diff-Rev: tag.

Jun 1 2019, 3:02 PM
bz committed rS348494: After parts of the locking fixes in r346595, syzkaller found.
After parts of the locking fixes in r346595, syzkaller found
Jun 1 2019, 2:58 PM
bz committed rS348493: Improve error/debug messages in sdhci.c.
Improve error/debug messages in sdhci.c
Jun 1 2019, 2:39 PM
bz closed D19748: Improve error/debug messages in sdhci.c.
Jun 1 2019, 2:39 PM

May 29 2019

bz requested changes to D20278: vimage: support kmods determining VIMAGE status at runtime.

I just only scrolled through this and there's a few things. I am not going into detail at the moment as I'd love to give this a full review once my brain capacity for yet-another-module-thing-complication is there. It'll be helpful to later decompose this into "whitespace change" and functional change (as a lot of renaming, etc. makes this hard to read).

May 29 2019, 2:47 PM
bz added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

I'll register strong desire to discard fragments immediately on interface vanishing. I don't expect that to come with any significant weight, my rational is whatever makes state management easier within current codebase and usage patterns of fbsd.

Why do you want to discard a packet if the interface it was received from is going away?
The packet is there, it doesn't matter if the interface goes away after it was received. And we don't have to wait for the interface to come back before continuing processing. We should be able to just process the packet even without that interface it was received on still being present when the processing happens.

May 29 2019, 9:47 AM

May 26 2019

bz added a comment to D17512: Fix dpcpu and vnet panics with complex types at the end of the section.
In D17512#439294, @jhb wrote:

I still don't understand why i386 is special in this regard. Surely i386 isn't the only architecture to ever use this type of relocation?

May 26 2019, 4:18 PM

May 22 2019

bz reclaimed D17512: Fix dpcpu and vnet panics with complex types at the end of the section.

so this happened as well with ipsec.ko not just carp.ko so we need a solution to the problem which scales. We discussed it here a bit in Waterloo and I think the only question is as to whether to use the BYTE(1) option and just put a padding byte at the end, or as to whether put a larger magic number there and actually check that the module might be compiled with the right options?

May 22 2019, 9:33 PM
bz updated the summary of D20338: Fix a race condition in udp_output().
May 22 2019, 3:24 PM

May 21 2019

bz added a comment to D20340: Add deprecation warnings for IPsec algorithms deprecated in RFC 8221..

Did you also want something for ipcomp?

May 21 2019, 10:28 PM
bz committed rS348063: Add very basic afinet socket tests which I started to write in order.
Add very basic afinet socket tests which I started to write in order
May 21 2019, 7:42 PM
bz created D20338: Fix a race condition in udp_output().
May 21 2019, 7:37 PM
bz committed rS348061: Massively blow up the locking-related KASSERTs used to make sure.
Massively blow up the locking-related KASSERTs used to make sure
May 21 2019, 7:24 PM
bz committed rS348060: Similarly to r338257,338306 try to fold the two consecutive.
Similarly to r338257,338306 try to fold the two consecutive
May 21 2019, 7:19 PM

May 18 2019

bz accepted D20311: Change ed(4), ep(4), and fxp(4) examples to em(4)..

Thank you!!!! And for the .Dd changes discussed in person :-)

May 18 2019, 8:57 PM

May 10 2019

bz accepted D20051: Factor out vnet ready check.

LGTM

May 10 2019, 9:47 AM

May 8 2019

bz added a comment to D20051: Factor out vnet ready check.

I kept thinking which states we can really observe and when:

May 8 2019, 5:34 PM
bz updated the diff for D19749: Add a CAM-Newbus SDIO support module..

Handle reviewer comments:

  • add SDIO disclaimer
  • fix typos
  • split up CMD53 function
  • add one device per function (and with that re-adjust to use the parent device as we no longer cache that, add ivar support rather than having hand-rolled accessor functions)
  • Use CMD52 to set blocksize
  • use a sdio specific awk to generate device and vendor defines
  • remove the DEFAULT implementations from the sdio_if.m file as they were only providing the general default
  • rework some error handling
  • rename field "smb" into more descriptive
  • Use dprintfs instead of printfs in the middle of a parsing API
May 8 2019, 12:56 PM
bz created D20199: bcm2835_sdhci.c: exit DMA if not enough data left to avoid timeout errors.
May 8 2019, 10:19 AM
bz created D20197: bcm2835_sdhci.c: save block registers to avoid controller bug.
May 8 2019, 9:45 AM

May 6 2019

bz abandoned D3879: Conflicting use of CCNT by DEV_PMU and HWPMC.

I think a dependency was rejected. This was Cambridge Teaching material code. I would assume this is overcome by time and changes a lot since. I have no more access to these trees where this came from to see. I am abandoning it to clean up.

May 6 2019, 8:52 PM

May 5 2019

bz added a comment to D19749: Add a CAM-Newbus SDIO support module..

I've fixed all requests in my internal tree but the CMD53 request (which I left a comment for what I'll do).
I'll upload a new diff the next 48 hours (need to also adjust the driver to deal with multiple devices).

May 5 2019, 6:32 PM

May 3 2019

bz accepted D20060: Select lacp egress ports based on NUMA domain.
May 3 2019, 7:15 AM

May 2 2019

bz added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

The ip6_fragment() change seems fine if you want to go ahead and factor that out.

May 2 2019, 8:31 PM
bz requested changes to D20060: Select lacp egress ports based on NUMA domain.
May 2 2019, 5:51 PM

Apr 30 2019

bz updated the diff for D19747: Improve sdhci slot_printf() debug printing..

Update based on feedback from marius/imp.

Apr 30 2019, 8:36 PM

Apr 25 2019

bz added a reviewer for D20044: tun/tap: merge: tuexen.

Adding @tuexen as a reviewer. If my memory serves me right he worked on a small part of of tun recently.

Apr 25 2019, 5:38 AM

Apr 24 2019

bz accepted D20028: Track TCP connection's NUMA domain in the inpcb.

LGTM... waiting for more beef :-)

Apr 24 2019, 4:14 PM

Apr 23 2019

bz closed D19594: Fix udp_output() locking strategy in one case.
Apr 23 2019, 10:12 AM
bz committed rS346595: iFix udp_output() lock inconsistency..
iFix udp_output() lock inconsistency.
Apr 23 2019, 10:12 AM
bz updated subscribers of D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

@bz: There is another bug I believe in the IPv6 VNET shutdown code.
Where is the counterpart mtx_destroy() for the following mtx_init():

void
frag6_init(void)
{

struct ip6q *q6;
int i;
V_ip6_maxfragpackets = IP6_MAXFRAGPACKETS;
frag6_set_bucketsize();
for (i = 0; i < IP6REASS_NHASH; i++) {
        q6 = IP6Q_HEAD(i);
        q6->ip6q_next = q6->ip6q_prev = q6;
        mtx_init(&V_ip6q[i].lock, "ip6qlock", NULL, MTX_DEF);
        V_ip6q[i].count = 0;
}
Apr 23 2019, 10:07 AM
bz requested changes to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

Sorry my bad for missing the VIMAGE state problem in the initial submit.

Apr 23 2019, 10:04 AM

Apr 22 2019

bz committed rS346556: r297225 move the assignment of sin from add to the top of the function..
r297225 move the assignment of sin from add to the top of the function.
Apr 22 2019, 2:54 PM
bz updated the diff for D19594: Fix udp_output() locking strategy in one case.

@emaste update the comment a bit.
@tuexen removed the KASSERT and left the sin = to be removed in a separate commit (as it is noise here)
@karels I think with the change we are fine as splitting up the case was for IP_SENDSRCADDR.

Apr 22 2019, 2:45 PM
bz committed rS346554: Remove some excessive brackets..
Remove some excessive brackets.
Apr 22 2019, 2:21 PM