Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

bz accepted D27394: ping: allow building without INET support.

THANK YOU SO MUCH FOR THIS! YOU ROCK!

Sat, Nov 28, 1:12 PM

Thu, Nov 26

bz accepted D27384: ping: add a ping6 hard link for backwards compatibility.

Ignoring the test case (but thanks for adding it) this looks good to me.
Thank you for bringing it back so quickly.

Thu, Nov 26, 4:50 PM

Wed, Nov 25

bz closed D27324: IPv6: Set ifdisabled in the kernel rather than in rc.
Wed, Nov 25, 8:58 PM
bz committed rS368031: IPv6: set ifdisabled in the kernel rather than in rc.
IPv6: set ifdisabled in the kernel rather than in rc
Wed, Nov 25, 8:58 PM

Tue, Nov 24

bz added a comment to D27324: IPv6: Set ifdisabled in the kernel rather than in rc.
In D27324#610809, @phk wrote:

Not sure why I'm asked to review this, not exactly my specialty, but it looks OK and sounds sensible.

Tue, Nov 24, 10:50 PM

Sun, Nov 22

bz updated subscribers of D27324: IPv6: Set ifdisabled in the kernel rather than in rc.
Sun, Nov 22, 10:23 PM
bz requested review of D27324: IPv6: Set ifdisabled in the kernel rather than in rc.
Sun, Nov 22, 10:22 PM

Wed, Nov 18

bz added a comment to D23085: DRM: Add DRM core files and DRMKPI.

Given this is all in sys/dev/drm (at least here) I keep wondering if the main problem we have currently is that people think "drmkpi" == "linuxkpi" and a change away from "KPI" would help that (especially given it is not the DRM KPI but DRM [Linux] Compat").

Wed, Nov 18, 1:20 PM

Thu, Nov 12

bz committed rS367620: MFC r367538:.
MFC r367538:
Thu, Nov 12, 5:26 PM

Tue, Nov 10

bz committed rS367540: MFC r367435,367539:.
MFC r367435,367539:
Tue, Nov 10, 2:14 AM
bz committed rS367538: arm64: bs_sr_<N> take II.
arm64: bs_sr_<N> take II
Tue, Nov 10, 2:14 AM
bz committed rS367539: usb_hub: fix whitespace.
usb_hub: fix whitespace
Tue, Nov 10, 2:14 AM

Sat, Nov 7

bz added inline comments to D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..
Sat, Nov 7, 9:37 PM
bz added inline comments to D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..
Sat, Nov 7, 8:16 PM
bz committed rS367451: MFC r367327:.
MFC r367327:
Sat, Nov 7, 4:36 PM
bz committed rS367450: MFC r367326:.
MFC r367326:
Sat, Nov 7, 4:34 PM

Fri, Nov 6

bz closed D27108: usb_hub: giving up port reset - device vanished.
Fri, Nov 6, 10:40 PM
bz committed rS367435: usb_hub: giving up port reset - device vanished.
usb_hub: giving up port reset - device vanished
Fri, Nov 6, 10:40 PM
bz added inline comments to D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..
Fri, Nov 6, 9:28 PM
bz added a comment to D26617: Rename DISTDIR to RELDISTDIR to avoid clash with ports DISTDIR defined in make.conf.

PR: 232293

Fri, Nov 6, 1:11 AM

Thu, Nov 5

bz updated the summary of D27108: usb_hub: giving up port reset - device vanished.
Thu, Nov 5, 10:46 PM
bz requested review of D27108: usb_hub: giving up port reset - device vanished.
Thu, Nov 5, 10:45 PM
bz committed rS367385: MFC r366268 (and epoch parts of r357093):.
MFC r366268 (and epoch parts of r357093):
Thu, Nov 5, 3:27 PM
bz committed rS367382: MFC r366799:.
MFC r366799:
Thu, Nov 5, 1:46 PM
bz committed rS367381: MFC r366623:.
MFC r366623:
Thu, Nov 5, 1:43 PM
bz committed rS367380: MFC r366523:.
MFC r366523:
Thu, Nov 5, 1:39 PM
bz committed rS367378: MFC r366817:.
MFC r366817:
Thu, Nov 5, 12:18 PM
bz committed rS367377: MFC r366800:.
MFC r366800:
Thu, Nov 5, 12:16 PM
bz committed rS367376: MFC r366525:.
MFC r366525:
Thu, Nov 5, 12:15 PM
bz committed rS367375: MFC r366524:.
MFC r366524:
Thu, Nov 5, 12:12 PM
bz committed rS367374: MFC r366522:.
MFC r366522:
Thu, Nov 5, 12:10 PM
bz committed rS367373: MFC r366112:.
MFC r366112:
Thu, Nov 5, 12:08 PM
bz committed rS367371: MFC r365633:.
MFC r365633:
Thu, Nov 5, 11:57 AM
bz committed rS367370: MFC r365335:.
MFC r365335:
Thu, Nov 5, 11:37 AM
bz committed rS367369: MFC r365334:.
MFC r365334:
Thu, Nov 5, 11:33 AM
bz committed rS367367: MFC r365333:.
MFC r365333:
Thu, Nov 5, 11:20 AM
bz committed rS367366: MFC r364305:.
MFC r364305:
Thu, Nov 5, 11:12 AM

Wed, Nov 4

bz committed rS367327: arm64: implement bs_sr_<N>.
arm64: implement bs_sr_<N>
Wed, Nov 4, 12:12 PM
bz committed rS367326: net80211: fix a typo.
net80211: fix a typo
Wed, Nov 4, 12:07 PM

Tue, Nov 3

bz added a comment to D23085: DRM: Add DRM core files and DRMKPI.

(3) I think I am also a bit confused by the multitude of things in this single review. Forgive my ignorance, but the "core/drm" code, will that be specific to this "DRMKPI" or will that be shared again with the drm-kmod world? I am asking (a) if we can split this up about what we are actually talking it'll be a lot easier to see, and (b) if it'll not be "shared", I think "dev/drm/" itself will lead to a lot of confusion and the question where drm-kmod "DRM" bits would go, but that's not the discussion here (hence (a)).

It will not be shared (at least not at first, some files could be, some can't for now).
drm-kmod will not go there (again for now, there is still a lot to do for that and I'm not sure how this will be done).

Tue, Nov 3, 2:45 PM
bz added a comment to D23085: DRM: Add DRM core files and DRMKPI.

I think there's a few things which currently concern me are:

Tue, Nov 3, 2:13 PM

Sun, Nov 1

bz added inline comments to D26870: arm64: rockchip, implement the two rk808 clocks.
Sun, Nov 1, 12:05 AM

Sat, Oct 31

bz added a reviewer for D26489: IP address parsing in netgraph eating too many characters: network.
Sat, Oct 31, 7:25 PM · network

Fri, Oct 30

bz added a reviewer for D27023: igmp: convert igmpstat to use PCPU counters: network.

Does that mean that we'll see another few changes like this making more stats public?

Fri, Oct 30, 9:15 PM
bz accepted D25963: camcontrol: add mmcsdcmd help.

Thank you SOOOOOOOOOOO MUCH!!!!

Fri, Oct 30, 1:35 PM

Oct 20 2020

bz added inline comments to D26735: Improve loading of multipage aligned buffers..
Oct 20 2020, 6:29 AM

Oct 19 2020

bz requested review of D26874: mmc: pwrseq add a "simple" implementation.
Oct 19 2020, 9:51 PM
bz requested review of D26872: mmc: implement mmc-pwrseq.
Oct 19 2020, 9:37 PM
bz requested review of D26870: arm64: rockchip, implement the two rk808 clocks.
Oct 19 2020, 8:55 PM
bz added a comment to D26334: cxgbe: Apply more checks for INET and INET6.
In D26334#598980, @np wrote:

okay, I'll take care of this.

Oct 19 2020, 7:54 PM
bz added a comment to D26334: cxgbe: Apply more checks for INET and INET6.

It seems by now there is also needs_inner_tcp_csum() ?
Can you possibly incorporate this in your next driver update and do it yourself @np ?

Oct 19 2020, 6:30 PM

Oct 18 2020

bz removed a reviewer for D26847: Add driver for RK3399 non-secure efuse.: bz.
Oct 18 2020, 11:22 PM
bz closed D26541: net80211: factor out the priv(9) checks into OS specifc code..
Oct 18 2020, 9:34 PM
bz committed rS366817: net80211: factor out the priv(9) checks into OS specifc code..
net80211: factor out the priv(9) checks into OS specifc code.
Oct 18 2020, 9:34 PM
bz added inline comments to D26541: net80211: factor out the priv(9) checks into OS specifc code..
Oct 18 2020, 5:29 PM
bz closed D26712: net80211: update for (more) VHT160 support.
Oct 18 2020, 12:27 AM
bz committed rS366800: net80211: update for (more) VHT160 support.
net80211: update for (more) VHT160 support
Oct 18 2020, 12:27 AM

Oct 17 2020

bz committed rS366799: clk: fix indentation.
clk: fix indentation
Oct 17 2020, 11:43 PM
bz committed rS366798: ddb: add show sysinit command.
ddb: add show sysinit command
Oct 17 2020, 10:47 PM

Oct 16 2020

bz updated subscribers of D26712: net80211: update for (more) VHT160 support.

Anyone interested in reviewing this? I'd love to get it in no later than Monday.

Oct 16 2020, 6:47 PM

Oct 14 2020

bz added a comment to D26782: Allow PING(8) in jails without raw socket access permissions.

I have a couple of comments for this:
(a) ICMP access is not just echo requests; this will alllow jails to send other things out which might not be a great idea, so if you do, default off.
(b) I'd love to have an ICMPv6 equivalent; ICMPv6 is even worse as to what people can do; see (a)
(c) I don't think this is a good idea.
(d) Even with this there'll be other issues (as are with raw sockets), such as source address selection, which was once was discussed in 2011 [ https://people.freebsd.org/~bz/20120407-01-ping-source-addr.diff ]; probably on freebsd-net or -jails back then.
(e) lastly we do have full network stacks these days, and even if they are not always needed the tradeoff to adding more hacks on top of classic IP-jails is questionable.

Oct 14 2020, 11:16 PM
bz added inline comments to D26755: Add hash table lookup for IPv6 raw sockets..
Oct 14 2020, 7:43 PM

Oct 13 2020

bz accepted D26578: nd6: Count packets dropped due to an invalid hop limit.
Oct 13 2020, 8:27 PM

Oct 11 2020

bz accepted D26728: linuxkpi: Move timer related functions in its own file..

I haven't tried it but scrolling through it looks ok to me.

Oct 11 2020, 8:19 PM
bz committed rS366623: ip_mroute: fix the viftable export sysctl.
ip_mroute: fix the viftable export sysctl
Oct 11 2020, 12:01 AM

Oct 10 2020

bz added a comment to D26727: linuxkpi: Move kobject related function in its own file.
In D26727#595888, @manu wrote:
In D26727#595874, @bz wrote:

Can you quickly elaborate what "drmkpi" is? Is that what we know as drm.ko? If that's it then is the reason that you basically have a freebsd module implementation there and just an internal glue to the linux device?

See D23085 (Or https://github.com/evadot/freebsd/tree/drm_base_v5.6-20201007 for a more up to date version).

Oct 10 2020, 9:14 AM
bz added a comment to D26727: linuxkpi: Move kobject related function in its own file.

Can you quickly elaborate what "drmkpi" is? Is that what we know as drm.ko? If that's it then is the reason that you basically have a freebsd module implementation there and just an internal glue to the linux device?

Oct 10 2020, 12:45 AM

Oct 8 2020

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Oct 8 2020, 9:45 PM

Oct 7 2020

bz updated the diff for D26712: net80211: update for (more) VHT160 support.
  • Update comment about ieee80211_add_channel_cbw() now supporting HT40/VHT80/..
Oct 7 2020, 11:21 PM
bz updated the diff for D26712: net80211: update for (more) VHT160 support.
  • Remove debug printfs from here as well.
  • Remove the whitespace from regdomain.
Oct 7 2020, 11:10 PM
bz committed rS366525: net80211: whitespace.
net80211: whitespace
Oct 7 2020, 10:52 PM
bz added inline comments to D26712: net80211: update for (more) VHT160 support.
Oct 7 2020, 10:48 PM
bz requested review of D26712: net80211: update for (more) VHT160 support.
Oct 7 2020, 10:44 PM
bz committed rS366524: 80211: ifconfig replace MS() with _IEEE80211_MASKSHIFT().
80211: ifconfig replace MS() with _IEEE80211_MASKSHIFT()
Oct 7 2020, 10:29 PM
bz closed D26708: LinuxKPI: A bitfield.h implementation..
Oct 7 2020, 10:07 PM
bz committed rS366523: LinuxKPI: add a bitfield.h implementation..
LinuxKPI: add a bitfield.h implementation.
Oct 7 2020, 10:07 PM
bz committed rS366522: 80211: non-functional changes.
80211: non-functional changes
Oct 7 2020, 9:57 PM
bz added a comment to D26708: LinuxKPI: A bitfield.h implementation..

manu, if you are okay with it, either commit it yourself or let me know when so that you can deal with the drm-kmod bits as well

Oct 7 2020, 9:05 PM
bz updated the diff for D26708: LinuxKPI: A bitfield.h implementation..
  • Rename f_mul to ___lsb as suggested by hselasky.
Oct 7 2020, 8:43 PM
bz added inline comments to D26708: LinuxKPI: A bitfield.h implementation..
Oct 7 2020, 6:42 PM
bz added a comment to D26681: linuxkpi: Add bitfield.h.
In D26681#594681, @manu wrote:
Oct 7 2020, 6:09 PM
bz added inline comments to D26708: LinuxKPI: A bitfield.h implementation..
Oct 7 2020, 6:07 PM
bz set the repository for D26708: LinuxKPI: A bitfield.h implementation. to rS FreeBSD src repository.
Oct 7 2020, 6:06 PM
bz requested review of D26708: LinuxKPI: A bitfield.h implementation..
Oct 7 2020, 6:05 PM

Oct 6 2020

bz added inline comments to D26578: nd6: Count packets dropped due to an invalid hop limit.
Oct 6 2020, 10:43 PM

Oct 5 2020

bz added inline comments to D26675: linuxkpi: Add hash.h.
Oct 5 2020, 10:19 PM
bz accepted D26676: linuxkpi: Add numa.h: Only contain NUMA_NO_NODE needed by drm.
Oct 5 2020, 10:15 PM
bz accepted D26677: linuxkpi: Add prefetch.h.
Oct 5 2020, 10:10 PM
bz accepted D26678: linuxkpi: Add trylock_page and unlock_page.
Oct 5 2020, 10:08 PM
bz accepted D26679: linuxkpi: Add power_supply.h.

Apart from the line break it's fine. No need for a new version; can commit with the change if you want.

Oct 5 2020, 10:06 PM
bz accepted D26680: linuxkpi: Add pagemap.h.
Oct 5 2020, 9:59 PM
bz added a comment to D26681: linuxkpi: Add bitfield.h.

Can I ask you to drop this one?

Oct 5 2020, 9:51 PM
bz accepted D26674: linuxkpi: Add gcd function.
Oct 5 2020, 9:17 PM
bz updated subscribers of D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.
Oct 5 2020, 5:49 PM

Oct 4 2020

bz accepted D26657: linuxkpi: populate the acquire context field of a ww_mutex.

Looks okay to me as well. The two minor things may be ignored.

Oct 4 2020, 2:41 PM · linuxkpi
bz updated the diff for D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.

Use DEVMETHOD_END.
Include subvendor/subdevice as V32 to deal with the -1 wildcard.
Add the bus name to the name filed in the driver_t.

Oct 4 2020, 2:36 PM

Oct 3 2020

bz added a comment to D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.

I'd still love to update this so that we can have the full set but I need to find the bug first that prevents this (with the comments) from working. You can still see how this turns out (just with less columns):

Oct 3 2020, 6:14 PM
bz requested review of D26651: linuxkpi: MODULE_DEVICE_TABLE to MODULE_PNP_INFO.
Oct 3 2020, 6:12 PM

Oct 2 2020

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Oct 2 2020, 7:15 PM

Oct 1 2020

bz added inline comments to D26598: linuxkpi: upstream drm-kmod conflicting changes.
Oct 1 2020, 2:47 PM