Page MenuHomeFreeBSD

wpa: pass IFM_IEEE80211_VHT5G if vht_enabled on the channel
ClosedPublic

Authored by bz on Jul 29 2022, 12:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 7:57 AM
Unknown Object (File)
Mon, Dec 2, 1:56 AM
Unknown Object (File)
Sun, Nov 24, 5:23 AM
Unknown Object (File)
Sat, Nov 23, 9:24 PM
Unknown Object (File)
Thu, Nov 21, 6:42 AM
Unknown Object (File)
Oct 8 2024, 6:48 AM
Unknown Object (File)
Sep 17 2024, 4:27 PM
Unknown Object (File)
Sep 7 2024, 10:47 AM
Subscribers

Details

Summary

I believe this is needed in order to set media mode correctly to
IFM_IEEE80211_VHT5G if vht_enabled is set ont he channel.
Otherwise we'll end up setting 11NA.

Sponsored by: The FreeBSD Foundation

Test Plan

At the moment this is still chicken-and-egg to be tested
but I don't want to lose the change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Jul 29 2022, 12:45 AM
This revision is now accepted and ready to land.Jul 29 2022, 8:37 PM
bz added a subscriber: adrian.

Adding wireless given @adrian is also working on VHT currently and will need this soon.

it's not entirely required because net80211 actually does the HT and VHT upgrade for us. I'll go check it first though to make sure it doesn't cause drama!

it's not entirely required because net80211 actually does the HT and VHT upgrade for us. I'll go check it first though to make sure it doesn't cause drama!

This is for the ifp media; I cannot see where the HT code would enable VHT media...

here's what i see in ifconfig:
adrian@francine:~ % ifconfig wlan1
wlan1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500

options=200001<RXCSUM,RXCSUM_IPV6>
ether 54:af:97:ec:0a:e6
inet 192.168.0.110 netmask 0xffffff00 broadcast 192.168.0.255
inet6 fe80::56af:97ff:feec:ae6%wlan1 prefixlen 64 scopeid 0x2
groups: wlan
ssid CACHEBOY_HOME channel 157 (5785 MHz 11a vht/40+) bssid 9c:53:22:c7:48:e3
regdomain FCC country US authmode WPA2/802.11i privacy ON
deftxkey UNDEF AES-CCM 2:128-bit txpower 17 bmiss 7 mcastrate 6
mgmtrate 6 scanvalid 60 ampdulimit 64k shortgi -stbc ldpctx -ldpcrx
-uapsd vht vht40 vht80 -vht160 -vht80p80 wme roaming MANUAL
parent interface: rtwn0
media: IEEE 802.11 Wireless Ethernet autoselect mode 11ac
status: associated
nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>

adrian@francine:~ %

.. is that "right" ? Or is one of the strings in media: supposed to be different?

Seems 656d0e8fa92ad72626808479d0935814425ee78d fixed what is reported back back on channel.

Break to ddb and show me vap->iv_des_mode (you can print the vap); I would assume it is 1 and not 13.

# ifconfig wlan0
wlan0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        options=0
        ether 74:13:ea:6e:de:c1
        inet6 fe80::7613:eaff:fe6e:dec1%wlan0 prefixlen 64 scopeid 0x3
        groups: wlan
        ssid abc channel 36 (5180 MHz 11a vht/80+) bssid 9a:9d:7e:76:6f:fa
        regdomain ETSI country DE authmode WPA2/802.11i privacy ON
        deftxkey UNDEF AES-CCM 2:128-bit txpower 23 bmiss 7 mcastrate 6
        mgmtrate 6 scanvalid 60 ampdulimit 64k -amsdutx amsdurx shortgi
        -ldpctx ldpcrx -uapsd vht vht40 vht80 vht160 -vht80p80 wme
        roaming MANUAL
        parent interface: iwlwifi0
        media: IEEE 802.11 Wireless Ethernet autoselect mode 11ac
        status: associated
        nd6 options=23<PERFORMNUD,ACCEPT_RTADV,AUTO_LINKLOCAL>

Reporting iwlwifi can as well but that doesn't mean it's doing.
mode is simply that the channel is VHT capable.

The interesting bit is when autoselect goes away and shows actual media.
This is without the patch as well btw.

aha! ok. I think NOW I get it. :-)