net80211: migrate FC0_TYPE_MASK / FC0_SUBTYPE_MASK frame type checks to macros

[adrian]

Summary

• Add macros for the management and control frame type checks that I've come across in the drivers.
• Delete some now old code (eg ath's ieee80211_is_action()) as there's now a macro for it.

Local testing:

• not yet, I have a lot of wifi devices to find and test against

[adrian]

update w/ url

[bz]

If you want please address the comments but given none is a logic problem I'll leave it to you.

sys/dev/ath/if_ath_tx.c

1136

superfluous ()

sys/dev/ipw/if_ipw.c

1122

I think style in this file doesn't need the space after !

sys/dev/otus/if_otus.c

1689

Space after !

sys/dev/usb/wlan/if_urtw.c

1726–1727

Those two could be macros as well.

[adrian]

updates suggested by bz@

[adrian]

updates, thanks!

[adrian]

landed

[bz]

In D47500#1086528, @adrian wrote:

landed

for reference c249cc3822dc002288700ee206cf28c0c6031449

[emaste]

FYI if Phab doesn't add the commit automatically (either because of a typo or misformatted commit message or because Phab is just broken) you can add it later via Edit Related Objects > Edit Commits and then paste the commit hash.