Differential D41585

ifconfig: fix 'ifconfig -l ether'
ClosedPublic
Actions

Authored by glebius on Aug 24 2023, 5:09 PM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rG31016aa0be6d: ifconfig: fix 'ifconfig -l ether'

Summary

When matching interfaces for being Ethernet, use same trick that
the link module does - pass if_type through convert_iftype().
That restores historicaly behaviour of listing lagg(4) ports.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 24 2023, 5:09 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2023, 5:09 PM

glebius requested review of this revision.Aug 24 2023, 5:09 PM

glebius added a parent revision: D41584: ifconfig: fix logical error in interface matching for '-l ether'.

Harbormaster completed remote builds in B53279: Diff 126482.Aug 24 2023, 5:09 PM

glebius added a child revision: D41586: ifconfig: fix 'ifconfig -l link'.Aug 24 2023, 5:13 PM

melifaro accepted this revision.Aug 24 2023, 8:38 PM

This revision is now accepted and ready to land.Aug 24 2023, 8:38 PM

Closed by commit rG31016aa0be6d: ifconfig: fix 'ifconfig -l ether' (authored by glebius). · Explain WhyAug 25 2023, 5:34 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG31016aa0be6d: ifconfig: fix 'ifconfig -l ether'.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

af_link.c

11 lines

ifconfig.h

2 lines

ifconfig_netlink.c

15 lines

Diff 126519

View Options

sbin/ifconfig/af_link.c

View Options

sbin/ifconfig/ifconfig.h

View Options

sbin/ifconfig/ifconfig_netlink.c

ifconfig: fix 'ifconfig -l ether'ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 126519

sbin/ifconfig/af_link.c

sbin/ifconfig/ifconfig.h

sbin/ifconfig/ifconfig_netlink.c

ifconfig: fix 'ifconfig -l ether'
ClosedPublic
Actions

Revision Contents
Changeset List