Differential D41586

ifconfig: fix 'ifconfig -l link'
ClosedPublic
Actions

Authored by glebius on Aug 24 2023, 5:13 PM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rG52ebb8a7d4f8: ifconfig: fix 'ifconfig -l link'
rG6f3947be2aff: ifconfig: fix 'ifconfig -l link'

Summary

The rtnetlink(4) RTM_GETADDR does not list link level addresses, thus
the correct match for interfaces that have a link level address should
be based on what was returned by RTM_GETLINK.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 24 2023, 5:13 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2023, 5:13 PM

glebius requested review of this revision.Aug 24 2023, 5:13 PM

glebius added a parent revision: D41585: ifconfig: fix 'ifconfig -l ether'.

Harbormaster completed remote builds in B53280: Diff 126483.Aug 24 2023, 5:13 PM

melifaro accepted this revision.Aug 24 2023, 8:40 PM

This revision is now accepted and ready to land.Aug 24 2023, 8:40 PM

Closed by commit rG6f3947be2aff: ifconfig: fix 'ifconfig -l link' (authored by glebius). · Explain WhyAug 25 2023, 5:34 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG6f3947be2aff: ifconfig: fix 'ifconfig -l link'.

zlei added a commit: rG52ebb8a7d4f8: ifconfig: fix 'ifconfig -l link'.Feb 5 2026, 6:12 PM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifconfig_netlink.c

8 lines

Diff 126520

View Options

sbin/ifconfig/ifconfig_netlink.c

ifconfig: fix 'ifconfig -l link'ClosedPublicActions