Page MenuHomeFreeBSD
Feed Advanced Search

Fri, May 14

melifaro committed R10:76cfc6fa0d81: Fix a use after free in update_rtm_from_rc(). (authored by melifaro).
Fix a use after free in update_rtm_from_rc().
Fri, May 14, 4:11 PM
melifaro accepted D30255: style: allow 120.
Fri, May 14, 10:24 AM

Thu, May 13

melifaro added inline comments to D28705: Fix ifa refcount leak in ifa_ifwithnet().
Thu, May 13, 4:44 PM

Mon, May 10

melifaro accepted D30191: ipfw.8: Fix table example.
Mon, May 10, 8:56 PM

Fri, May 7

melifaro committed R10:aad59c79f5f2: Fix panic when trying to delete non-existent gateway in multipath route. (authored by melifaro).
Fix panic when trying to delete non-existent gateway in multipath route.
Fri, May 7, 8:50 PM

Tue, May 4

melifaro committed R10:939c41f3b89b: Fix drace CTF for the rib_head. (authored by melifaro).
Fix drace CTF for the rib_head.
Tue, May 4, 9:43 PM
melifaro committed R10:972fcfb34b0d: [fib algo] Update fib_gen counter under FIB_MOD_LOCK. (authored by melifaro).
[fib algo] Update fib_gen counter under FIB_MOD_LOCK.
Tue, May 4, 9:43 PM
melifaro committed R10:d0666c87184f: Add rib_walk_from() wrapper for selective rib tree traversal. (authored by melifaro).
Add rib_walk_from() wrapper for selective rib tree traversal.
Tue, May 4, 9:43 PM
melifaro committed R10:83add84c00ed: [fib algo] Delay algo init at fib growth to to allow to reliably use rib KPI. (authored by melifaro).
[fib algo] Delay algo init at fib growth to to allow to reliably use rib KPI.
Tue, May 4, 9:43 PM
melifaro committed R10:3fd9848f1593: [rtsock] Enforce netmask/RTF_HOST consistency. (authored by melifaro).
[rtsock] Enforce netmask/RTF_HOST consistency.
Tue, May 4, 9:43 PM
melifaro accepted D30096: Revise FIB lookups per second benchmarking routines.
Tue, May 4, 9:22 PM
melifaro accepted D29821: Introduce DXR IPv4 LPM as a fib_algo module..
Tue, May 4, 8:33 PM
melifaro added a reviewer for D29821: Introduce DXR IPv4 LPM as a fib_algo module.: network.
Tue, May 4, 8:32 PM
melifaro accepted D29821: Introduce DXR IPv4 LPM as a fib_algo module..
Tue, May 4, 8:32 PM
melifaro accepted D30096: Revise FIB lookups per second benchmarking routines.
Tue, May 4, 8:50 AM

Sat, May 1

melifaro added inline comments to D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.
Sat, May 1, 10:13 AM ยท network

Thu, Apr 29

melifaro accepted D29821: Introduce DXR IPv4 LPM as a fib_algo module..

LGTM, please see some comments inline :-)
Also: do you have any preference/requirements on the commit message?

Thu, Apr 29, 9:53 PM
melifaro committed R10:553c1513a8a5: Fix build with gcc (authored by se).
Fix build with gcc
Thu, Apr 29, 9:18 AM
melifaro committed R10:59b3b210a69e: [fib algo] always commit static routes synchronously. (authored by melifaro).
[fib algo] always commit static routes synchronously.
Thu, Apr 29, 9:18 AM
melifaro committed R10:2c0d16218efa: Fix NOINET[6],!VIMAGE builds after FIB_ALGO addition to GENERIC (authored by melifaro).
Fix NOINET[6],!VIMAGE builds after FIB_ALGO addition to GENERIC
Thu, Apr 29, 9:18 AM
melifaro committed R10:1899138d5ad5: Fix rib generation count for fib algo. (authored by melifaro).
Fix rib generation count for fib algo.
Thu, Apr 29, 9:18 AM
melifaro committed R10:a423e945c70b: Fix NOINET[6] build after enabling FIB_ALGO in GENERIC. (authored by melifaro).
Fix NOINET[6] build after enabling FIB_ALGO in GENERIC.
Thu, Apr 29, 9:18 AM
melifaro committed R10:6fa0160556e3: Add batched update support for the fib algo. (authored by melifaro).
Add batched update support for the fib algo.
Thu, Apr 29, 9:18 AM
melifaro committed R10:a07e7856e4cd: fib algo: do not reallocate datapath index for datapath ptr update. (authored by melifaro).
fib algo: do not reallocate datapath index for datapath ptr update.
Thu, Apr 29, 9:18 AM
melifaro committed R10:c971873acef4: Implement better rebuild-delay fib algo policy. (authored by melifaro).
Implement better rebuild-delay fib algo policy.
Thu, Apr 29, 9:18 AM
melifaro committed R10:b77bee7642ae: Appease -Wsign-compare in radix.c (authored by melifaro).
Appease -Wsign-compare in radix.c
Thu, Apr 29, 9:18 AM
melifaro committed R10:c1ce6196d289: Allow to specify debugnet fib in sysctl/tunable. (authored by melifaro).
Allow to specify debugnet fib in sysctl/tunable.
Thu, Apr 29, 9:18 AM
melifaro committed R10:3d851bd03698: Always use inp fib in the inp_lookup_mcast_ifp(). (authored by melifaro).
Always use inp fib in the inp_lookup_mcast_ifp().
Thu, Apr 29, 9:18 AM

Wed, Apr 28

melifaro committed R10:41ce0e34ea42: [fib algo] Update fib_gen counter under FIB_MOD_LOCK. (authored by melifaro).
[fib algo] Update fib_gen counter under FIB_MOD_LOCK.
Wed, Apr 28, 8:24 PM
melifaro added a comment to D29821: Introduce DXR IPv4 LPM as a fib_algo module..

kldload dxr
sysctl net.route.algo should list dxr
sysctl net.route.algo.inet.algo=dxr should forcibly select it

Wed, Apr 28, 3:10 PM
melifaro closed D29971: Add rib_walk_from() wrapper for selective rib tree traversal.
Wed, Apr 28, 8:17 AM
melifaro committed R10:f9668e42b44f: Add rib_walk_from() wrapper for selective rib tree traversal. (authored by melifaro).
Add rib_walk_from() wrapper for selective rib tree traversal.
Wed, Apr 28, 8:17 AM

Tue, Apr 27

melifaro abandoned D29899: Add rib_lookup_prefix_locked() and rib_walk_from_locked() public wrappers..
Tue, Apr 27, 10:19 PM
melifaro closed D29969: [fib algo] Delay algo init during fib growth phase to allow to reliably use rib KPI.
Tue, Apr 27, 10:11 PM
melifaro committed R10:8a0d57baecf7: [fib algo] Delay algo init at fib growth to to allow to reliably use rib KPI. (authored by melifaro).
[fib algo] Delay algo init at fib growth to to allow to reliably use rib KPI.
Tue, Apr 27, 10:11 PM
melifaro accepted D28705: Fix ifa refcount leak in ifa_ifwithnet().
Tue, Apr 27, 8:32 PM
melifaro committed R10:fbe149eef7d8: Fix rtsock sockaddr alignment. (authored by melifaro).
Fix rtsock sockaddr alignment.
Tue, Apr 27, 8:20 PM
melifaro committed R10:439d087d0b55: [fib algo] always commit static routes synchronously. (authored by melifaro).
[fib algo] always commit static routes synchronously.
Tue, Apr 27, 8:34 AM
melifaro added a comment to D28434: Add FIB_ALGO to GENERIC on amd64/arm64..

Ack. Interesting, local test run worked. Will take a look in the evening.

Should be better with 439d087d0b55.

Tue, Apr 27, 8:34 AM
melifaro committed R10:25682e6a495f: Fix rtsock sockaddr alignment. (authored by melifaro).
Fix rtsock sockaddr alignment.
Tue, Apr 27, 8:34 AM
melifaro added a comment to D28434: Add FIB_ALGO to GENERIC on amd64/arm64..

It's yet another problem related to type definitions and CTF, causing dtrace to bail. In this case, struct rib_head has a conditionally defined member, rnh_gen_rib. FIB_ALGO is defined only when opt_route.h is included, so unless everything that includes route.h also includes opt_route.h, we end up with different definitions for struct rib_head depending on whether opt_route.h is included. I can see two solutions: move FIB_ALGO to opt_global.h so that FIB_ALGO is consistently defined, or make the definition of rnh_gen_fib unconditional. I prefer the second solution since out-of-tree modules could be compiled without FIB_ALGO defined.

Option 2 landed as bc5ef45aec3fa8acf2dd3408cebd207317543a8b. Thank you!

I misread a bit, the problematic definition is in route_var.h, not route.h, and so is not so widely included in the kernel. Indeed, some files in sys/net/route fail to include opt_route.h. It may be sufficient to just fix those, as a third solution.

Tue, Apr 27, 8:14 AM
melifaro committed R10:bc5ef45aec3f: Fix drace CTF for the rib_head. (authored by melifaro).
Fix drace CTF for the rib_head.
Tue, Apr 27, 8:01 AM

Mon, Apr 26

melifaro accepted D29989: pf tests: Test automatically generated tables.
Mon, Apr 26, 11:57 AM
melifaro committed R10:d2f68847a3ea: [fib algo] Do not print algo attach/detach message on boot (authored by melifaro).
[fib algo] Do not print algo attach/detach message on boot
Mon, Apr 26, 9:14 AM
melifaro committed R10:317387218363: Make gcc happy by initializing error in rib_handle_ifaddr_info(). (authored by melifaro).
Make gcc happy by initializing error in rib_handle_ifaddr_info().
Mon, Apr 26, 9:14 AM
melifaro committed R10:fe04896da3fb: Improve debugging output on routing tests failure. (authored by melifaro).
Improve debugging output on routing tests failure.
Mon, Apr 26, 9:14 AM
melifaro committed R10:6f1e5d9169a9: Relax rtsock message restrictions. (authored by melifaro).
Relax rtsock message restrictions.
Mon, Apr 26, 9:13 AM
melifaro committed R10:98a3c20696f8: Improve error reporting in rtsock.c (authored by melifaro).
Improve error reporting in rtsock.c
Mon, Apr 26, 9:13 AM
melifaro committed R10:98ea411989e5: Fix typo in rtsock_common.h (authored by melifaro).
Fix typo in rtsock_common.h
Mon, Apr 26, 9:13 AM
melifaro committed R10:45645b05b887: Fib algo: extend KPI by allowing algo to set datapath pointers. (authored by melifaro).
Fib algo: extend KPI by allowing algo to set datapath pointers.
Mon, Apr 26, 9:12 AM
melifaro added a comment to D28434: Add FIB_ALGO to GENERIC on amd64/arm64..

Ack. Interesting, local test run worked. Will take a look in the evening.

Mon, Apr 26, 8:58 AM

Sun, Apr 25

melifaro committed R10:7d222ce3c10b: Fix NOINET[6],!VIMAGE builds after FIB_ALGO addition to GENERIC (authored by melifaro).
Fix NOINET[6],!VIMAGE builds after FIB_ALGO addition to GENERIC
Sun, Apr 25, 7:54 PM
melifaro added inline comments to D29971: Add rib_walk_from() wrapper for selective rib tree traversal.
Sun, Apr 25, 3:28 PM
melifaro requested review of D29971: Add rib_walk_from() wrapper for selective rib tree traversal.
Sun, Apr 25, 12:00 PM
melifaro committed R10:67372fb3e06e: Fix NOINET[6] build after enabling FIB_ALGO in GENERIC. (authored by melifaro).
Fix NOINET[6] build after enabling FIB_ALGO in GENERIC.
Sun, Apr 25, 11:30 AM
melifaro retitled D29969: [fib algo] Delay algo init during fib growth phase to allow to reliably use rib KPI from [fib algo] Delay algo init during fib growth phase to allow rt_tables_get_rnh_ptr() to always work. to [fib algo] Delay algo init during fib growth phase to allow to reliably use rib KPI.
Sun, Apr 25, 11:18 AM
melifaro retitled D29969: [fib algo] Delay algo init during fib growth phase to allow to reliably use rib KPI from Delay algo init. to [fib algo] Delay algo init during fib growth phase to allow rt_tables_get_rnh_ptr() to always work..
Sun, Apr 25, 11:16 AM
melifaro updated the summary of D29969: [fib algo] Delay algo init during fib growth phase to allow to reliably use rib KPI.
Sun, Apr 25, 11:15 AM
melifaro requested review of D29969: [fib algo] Delay algo init during fib growth phase to allow to reliably use rib KPI.
Sun, Apr 25, 10:31 AM
melifaro committed R10:c23385612da5: [fib algo] Do not print algo attach/detach message on boot (authored by melifaro).
[fib algo] Do not print algo attach/detach message on boot
Sun, Apr 25, 8:58 AM
melifaro committed R10:a81e2e7890c2: Make gcc happy by initializing error in rib_handle_ifaddr_info(). (authored by melifaro).
Make gcc happy by initializing error in rib_handle_ifaddr_info().
Sun, Apr 25, 8:45 AM

Sat, Apr 24

melifaro closed D28434: Add FIB_ALGO to GENERIC on amd64/arm64..
Sat, Apr 24, 11:26 PM
melifaro committed R10:6993187a8c30: Add FIB_ALGO to GENERIC on amd64/arm64. (authored by melifaro).
Add FIB_ALGO to GENERIC on amd64/arm64.
Sat, Apr 24, 11:25 PM
melifaro committed R10:5d1403a79a3e: [rtsock] Enforce netmask/RTF_HOST consistency. (authored by melifaro).
[rtsock] Enforce netmask/RTF_HOST consistency.
Sat, Apr 24, 11:04 PM
melifaro closed D29958: [rtsock] Enforce netmask/RTF_HOST consistency.
Sat, Apr 24, 11:04 PM
melifaro committed R10:bddae5c8a64d: Improve debugging output on routing tests failure. (authored by melifaro).
Improve debugging output on routing tests failure.
Sat, Apr 24, 11:04 PM
melifaro closed D29957: Improve debugging output on routing tests failure.
Sat, Apr 24, 11:04 PM

Fri, Apr 23

melifaro added inline comments to D29957: Improve debugging output on routing tests failure.
Fri, Apr 23, 11:11 PM
melifaro accepted D29519: Add missing sockaddr length and family validation to various protocols.
Fri, Apr 23, 10:49 PM
melifaro updated the summary of D29958: [rtsock] Enforce netmask/RTF_HOST consistency.
Fri, Apr 23, 10:00 PM
melifaro requested review of D29958: [rtsock] Enforce netmask/RTF_HOST consistency.
Fri, Apr 23, 9:54 PM
melifaro added a reviewer for D29957: Improve debugging output on routing tests failure: network.
Fri, Apr 23, 9:37 PM
melifaro retitled D29957: Improve debugging output on routing tests failure from Summary: Improve debugging output on routing tests failure to Improve debugging output on routing tests failure.
Fri, Apr 23, 9:37 PM
melifaro updated the diff for D29957: Improve debugging output on routing tests failure.

.

Fri, Apr 23, 9:35 PM
melifaro requested review of D29957: Improve debugging output on routing tests failure.
Fri, Apr 23, 9:35 PM
melifaro added a comment to D29519: Add missing sockaddr length and family validation to various protocols.

I have a general question about compatibility.
Recently I landed a similar change (D28668) in the rtsock space. It turned out that (older) applications do a lot of weird things: some send the length less than expected (recall sockaddr_in has a weird sin_zero field), some send zero-length, etc.
I'm pretty sure that some applications will break in some weird ways - just because we didn't have these checks in place before.
What's our position here? Do we want to let the apps break and insisting on fixing the code, or we consider guarding these checks under, for example #ifndef COMPAT_FREEBSD12?

Fri, Apr 23, 8:44 PM
melifaro accepted D29944: Correctly skip rtsock_l3 test when if_epair is not available.
Fri, Apr 23, 10:27 AM

Thu, Apr 22

melifaro added a comment to D29900: Fix vtnet TCP lro panic.

For the record: I have no context here and this may not be the best fix (e.g. it may be better to just fill at least the ifp pointer during RX ring init), so committing as a bandaid to fix the panic on boot.

Thu, Apr 22, 8:11 AM
melifaro closed D29900: Fix vtnet TCP lro panic.
Thu, Apr 22, 8:00 AM
melifaro committed R10:4044af03a4e9: Fix vtnet TCP lro panic (authored by melifaro).
Fix vtnet TCP lro panic
Thu, Apr 22, 8:00 AM

Wed, Apr 21

melifaro updated the summary of D29900: Fix vtnet TCP lro panic.
Wed, Apr 21, 10:55 PM
melifaro requested review of D29900: Fix vtnet TCP lro panic.
Wed, Apr 21, 10:51 PM
melifaro retitled D29899: Add rib_lookup_prefix_locked() and rib_walk_from_locked() public wrappers. from Add xx to Add rib_lookup_prefix_locked() and rib_walk_from_locked() public wrappers..
Wed, Apr 21, 10:49 PM
melifaro requested review of D29899: Add rib_lookup_prefix_locked() and rib_walk_from_locked() public wrappers..
Wed, Apr 21, 10:47 PM
melifaro added a comment to D28886: Update rtsock_l3 test after 2fe5a79425c79f7b828acd91da66d97230925fc8.

@melifaro should I split the change to rtm_add_v4_no_rtf_host_failure into a separate review?

Sorry for taking that long! No, that's totally fine!

Just to confirm, rtm_add_v4_no_rtf_host_failure is actually supposed to succeed now?

Yes

Wed, Apr 21, 9:26 AM
melifaro accepted D28886: Update rtsock_l3 test after 2fe5a79425c79f7b828acd91da66d97230925fc8.
Wed, Apr 21, 8:05 AM
melifaro added a comment to D28886: Update rtsock_l3 test after 2fe5a79425c79f7b828acd91da66d97230925fc8.

@melifaro should I split the change to rtm_add_v4_no_rtf_host_failure into a separate review?

Sorry for taking that long!
So far no tests should be failing except rtm_get_v4_hostbits_failure and rtm_add_v4_no_rtf_host_failure.
If you have cycles to split the rename change into a separate review - that would be awesome. If you don't, I'm happy to do it myself.

Wed, Apr 21, 8:02 AM

Tue, Apr 20

melifaro added a comment to D28434: Add FIB_ALGO to GENERIC on amd64/arm64..

Going to commit this on Saturday, April 24

Tue, Apr 20, 10:43 PM
melifaro closed D29812: Fix rib generation count for fib algo..
Tue, Apr 20, 10:42 PM
melifaro committed R10:33cb3cb2e321: Fix rib generation count for fib algo. (authored by melifaro).
Fix rib generation count for fib algo.
Tue, Apr 20, 10:42 PM
melifaro added inline comments to D29812: Fix rib generation count for fib algo..
Tue, Apr 20, 10:18 PM
melifaro updated the diff for D29812: Fix rib generation count for fib algo..

Reflect donner@ comments.

Tue, Apr 20, 10:12 PM
melifaro closed D29826: Relax rtsock message restrictions.
Tue, Apr 20, 9:35 PM
melifaro committed R10:b31fbebeb3d5: Relax rtsock message restrictions. (authored by melifaro).
Relax rtsock message restrictions.
Tue, Apr 20, 9:35 PM
melifaro updated the test plan for D29826: Relax rtsock message restrictions.
Tue, Apr 20, 9:14 PM
melifaro updated the test plan for D29826: Relax rtsock message restrictions.
Tue, Apr 20, 9:02 PM
melifaro abandoned D23051: Allow address lookups in rn_match()..
Tue, Apr 20, 8:07 AM
melifaro added inline comments to D29812: Fix rib generation count for fib algo..
Tue, Apr 20, 8:03 AM

Mon, Apr 19

melifaro updated the diff for D29592: Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output()..

.

Mon, Apr 19, 9:56 PM
melifaro added inline comments to D29592: Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output()..
Mon, Apr 19, 9:44 PM