Page MenuHomeFreeBSD
Feed Advanced Search

Today

melifaro accepted D37807: Mechanically convert if_stge(4) to DrvAPI.
Tue, Feb 7, 10:59 AM
melifaro added inline comments to D38410: bridge: Try to make the GRAB_OUR_PACKETS macro a bit more readable.
Tue, Feb 7, 10:57 AM

Yesterday

melifaro added a comment to D37923: testing: handling non-root users with VNETs in pytests..

I'm going to commit this change tomorrow, February 7.
It's always possible to change the implementation later if so desired.

Mon, Feb 6, 5:41 PM

Fri, Feb 3

melifaro added inline comments to D38364: inpcb: Split in_pcblookup_hash_locked() and clean up a bit.
Fri, Feb 3, 5:18 PM
melifaro added inline comments to D38364: inpcb: Split in_pcblookup_hash_locked() and clean up a bit.
Fri, Feb 3, 4:08 PM
melifaro added inline comments to D38364: inpcb: Split in_pcblookup_hash_locked() and clean up a bit.
Fri, Feb 3, 3:33 PM

Thu, Feb 2

melifaro added a comment to D38348: IfAPI: Add iterator to loop over all interfaces.

if_foreach_ifp ?

Thu, Feb 2, 9:36 PM

Wed, Feb 1

melifaro accepted D38348: IfAPI: Add iterator to loop over all interfaces.
Wed, Feb 1, 10:35 PM
melifaro added reviewers for D38347: linux: attach netlink on i386.: dchagin, Linux Emulation.
Wed, Feb 1, 8:36 PM
melifaro requested review of D38347: linux: attach netlink on i386..
Wed, Feb 1, 8:36 PM

Tue, Jan 31

melifaro added a comment to D38202: IfAPI: Add some more accessors.

Do you have by chance any plans on merging accessors to 13/ to ease other merges?

Tue, Jan 31, 6:40 PM
melifaro committed rGe80699a809a0: netlink: add NETLINK to GENERIC. (authored by melifaro).
netlink: add NETLINK to GENERIC.
Tue, Jan 31, 2:26 PM
melifaro updated the diff for D38283: netlink: return optional metadata with the operation result..

Fix python code formatting.

Tue, Jan 31, 1:40 PM

Mon, Jan 30

melifaro added a reviewer for D38283: netlink: return optional metadata with the operation result.: manpages.
Mon, Jan 30, 6:41 PM
melifaro updated the summary of D38283: netlink: return optional metadata with the operation result..
Mon, Jan 30, 6:41 PM
melifaro requested review of D38283: netlink: return optional metadata with the operation result..
Mon, Jan 30, 6:40 PM
melifaro committed rG6eaaed42943b: netlink: add UPDATING entry on linux_common(4) reliance on netlink. (authored by melifaro).
netlink: add UPDATING entry on linux_common(4) reliance on netlink.
Mon, Jan 30, 3:14 PM
melifaro committed rGee49c5d33d93: carp: turn net.inet.carp.allow into a RW tunable (authored by lytboris_gmail.com).
carp: turn net.inet.carp.allow into a RW tunable
Mon, Jan 30, 11:34 AM
melifaro committed rG7fc9cfa57ccd: netlink: add "netlink" to the list of kernel features (authored by melifaro).
netlink: add "netlink" to the list of kernel features
Mon, Jan 30, 11:34 AM
melifaro closed D38167: Turn net.inet.carp.allow into a RW tunable.
Mon, Jan 30, 11:34 AM

Sun, Jan 29

melifaro accepted D38167: Turn net.inet.carp.allow into a RW tunable.

Works on -HEAD for me.
I'm going to commit it tomorrow, on Jan 30 if there are no objections.

Sun, Jan 29, 4:54 PM
melifaro committed rG15dbf5a24169: netstat: export weight for single-path routes. (authored by melifaro).
netstat: export weight for single-path routes.
Sun, Jan 29, 4:37 PM
melifaro committed rG3ebccb20d564: netlink: allow path weight manipulations for single-path routes. (authored by melifaro).
netlink: allow path weight manipulations for single-path routes.
Sun, Jan 29, 4:05 PM

Sat, Jan 28

melifaro committed rG95b47ba62994: netlink: export nextop group kernel index when dumping multipath route. (authored by melifaro).
netlink: export nextop group kernel index when dumping multipath route.
Sat, Jan 28, 3:40 PM

Fri, Jan 27

melifaro committed rG79111aa26f8b: netstat: fix format string on 32-bit archs (authored by melifaro).
netstat: fix format string on 32-bit archs
Fri, Jan 27, 5:46 PM
melifaro committed rG68636dcb6fde: netstat: make netstat -rn use netlink instead of rtsock (authored by melifaro).
netstat: make netstat -rn use netlink instead of rtsock
Fri, Jan 27, 3:36 PM
melifaro closed D36529: netstat: make netstat -rn use netlink instead of rtsock.
Fri, Jan 27, 3:36 PM
melifaro added inline comments to D38203: IfAPI: Add l2com accessor for firewire..
Fri, Jan 27, 2:41 PM
melifaro accepted D38203: IfAPI: Add l2com accessor for firewire..
Fri, Jan 27, 9:47 AM
melifaro committed rG6f996120e374: ipfw: Add missing 'va' code point name (authored by jlduran_gmail.com).
ipfw: Add missing 'va' code point name
Fri, Jan 27, 9:42 AM
melifaro committed rG84c7aaf0de12: netlink: add netlink to GENERIC@amd64 (authored by melifaro).
netlink: add netlink to GENERIC@amd64
Fri, Jan 27, 9:10 AM

Thu, Jan 26

melifaro committed rGefbf827ae461: netlink: allow netlink to be build in the kernel (authored by melifaro).
netlink: allow netlink to be build in the kernel
Thu, Jan 26, 4:15 PM
melifaro committed rGcbd59dcec727: netlink: fix standalone module build (authored by glebius).
netlink: fix standalone module build
Thu, Jan 26, 3:43 PM
melifaro committed rGc1c40c8627a0: linuxolator: add netlink support (authored by melifaro).
linuxolator: add netlink support
Thu, Jan 26, 3:43 PM
melifaro accepted D38213: netlink: Zero-initialize writer structures allocated on the stack.

Ack, that's a good one!
My initial approach was to perform zero in the -> init() functions (e.g. nlmsg_get_ns_<mbuf|lbuf|buf>), preferably via explicit field initialisation. Apparently the latter one has failed.
ATM I'm leaning towards doing the explicit bzero() in all init functions, but need to think a bit more about it.
To unblock the fix, let's require the explicit writer initialisation for now.

Thu, Jan 26, 3:25 PM
melifaro added a comment to D37923: testing: handling non-root users with VNETs in pytests..

It also means that an unprivileged user won't be able to simply type "kyua test ..." and expect the unprivileged test cases to work.

I'll retry everything tomorrow, but in this regard, things are working as expected.
Unprivileged users:

  • Can run unprivileged test cases
  • root test cases are skipped
  • VNET test cases are skipped entirely (because an unprivileged user cannot create jails)

What is not working for me, is:

class TestVnetSimple(SingleVnetTestTemplate):
    @pytest.mark.parametrize(
        "user_tuple",
        [
            pytest.param(
                ["kldload if_epair", "module already loaded or in kernel"],
                marks=pytest.mark.require_user("root"),
                id="root",
            ),
            pytest.param(
                ["kldload if_epair", "Operation not permitted"],
                marks=pytest.mark.require_user("unprivileged"),
                id="unprivileged",
            ),
        ],
    )
    def test_parametrize_require_user(self, user_tuple):
        command, output = user_tuple
        assert output in subprocess.getoutput(command)

Specifically the test_parametrize_require_user[root] parameter. It gets an Operation not permitted error, as if unprivileged.
If you s/SingleVnetTestTemplate/BaseTest everything works as expected.

Thank you for testing & catching the issue!
I'll check this case and update the diff.

Thu, Jan 26, 3:01 PM
melifaro added inline comments to D38202: IfAPI: Add some more accessors.
Thu, Jan 26, 2:19 PM

Wed, Jan 25

melifaro accepted D38201: IfAPI: Hide the in6m_lookup_locked() implementation..
Wed, Jan 25, 9:41 PM
melifaro added inline comments to D38202: IfAPI: Add some more accessors.
Wed, Jan 25, 9:37 PM
melifaro accepted D38200: IfAPI: Explicitly include <net/if_private.h> in netstack.
Wed, Jan 25, 9:32 PM
melifaro added a comment to D38053: WIP: ping: Add atf-python tests.
  1. In the meantime the kernel delayed object reclamation model issue is fixed, maybe adapt 80fc25025ffcb0d369fc0b6d4d272ad6fd3f53c3 ?

Committed in 20ea7f26e413 .

Wed, Jan 25, 4:36 PM · Python
melifaro committed rG20ea7f26e413: pytest: delete interfaces from inside the jail. (authored by melifaro).
pytest: delete interfaces from inside the jail.
Wed, Jan 25, 4:35 PM
melifaro added a comment to D38053: WIP: ping: Add atf-python tests.
  1. An atf_get_srcdir-equivalent to eventually read files relative to the source directory, however I think the idea is to disassociate from ATF later on.

This one slipped through the cracks, thanks for reminding! Will add in a day or two.

I thought of passing it via wrapper initially, but ended up with a bit more natural way - getting it from pytest itself.
I committed an example here.

Wed, Jan 25, 2:00 PM · Python
melifaro committed rG864ea9abfb98: pytest: add an example test fetching test directory and ATF vars. (authored by melifaro).
pytest: add an example test fetching test directory and ATF vars.
Wed, Jan 25, 1:57 PM
melifaro accepted D38188: rtalloc.9: remove obsolete man page.

Thanks for cleaning that up!
I have the new manpages as WIP, but currently focused on the netlink. Will probably come up with something within a month or so.

Wed, Jan 25, 12:11 PM
melifaro accepted D38187: PCBGROUP.9: remove obsolete man page.
Wed, Jan 25, 12:09 PM

Tue, Jan 24

melifaro committed rG9fcc6175008c: man: fix socket.2 merge from a16f805f820e (authored by melifaro).
man: fix socket.2 merge from a16f805f820e
Tue, Jan 24, 9:48 PM
melifaro committed rG99e4ea083c57: netlink: connect netlink(4), rtnetlink(4), genetlinl(4) to build (authored by lwhsu).
netlink: connect netlink(4), rtnetlink(4), genetlinl(4) to build
Tue, Jan 24, 9:48 PM

Mon, Jan 23

melifaro committed rGb2e826efd6c4: netlink: fix OOB write when creating attribute bitmask. (authored by melifaro).
netlink: fix OOB write when creating attribute bitmask.
Mon, Jan 23, 10:21 PM
melifaro committed rGeb310021a4f6: netlink: add snl(3) manpage to the build (authored by melifaro).
netlink: add snl(3) manpage to the build
Mon, Jan 23, 10:21 PM
melifaro committed rG1ce626b94897: netlink: fix typo in netlink(4) (authored by melifaro).
netlink: fix typo in netlink(4)
Mon, Jan 23, 10:21 PM
melifaro committed rG16ae7b665c7e: nhop: hash ifnet pointer instead of if_index (authored by glebius).
nhop: hash ifnet pointer instead of if_index
Mon, Jan 23, 10:16 PM
melifaro committed rG40c711523e3a: net: add if_allocdescr() to permit updating iface description from the kernel (authored by melifaro).
net: add if_allocdescr() to permit updating iface description from the kernel
Mon, Jan 23, 10:16 PM
melifaro committed rG0edb2cd13d89: if_clone: rework cloning KPI (authored by melifaro).
if_clone: rework cloning KPI
Mon, Jan 23, 10:16 PM
melifaro committed rGedf966085e44: netlink: allow creating sockets with SOCK_DGRAM. (authored by melifaro).
netlink: allow creating sockets with SOCK_DGRAM.
Mon, Jan 23, 10:16 PM
melifaro committed rGa9dcee4334b2: ifp: add if_setdescr() / if_freedesrt() methods (authored by melifaro).
ifp: add if_setdescr() / if_freedesrt() methods
Mon, Jan 23, 10:16 PM
melifaro committed rG92d8e0f13657: netlink: fix compatibility with older netlink applications. (authored by melifaro).
netlink: fix compatibility with older netlink applications.
Mon, Jan 23, 10:16 PM
melifaro committed rG74115922268c: netlink: improve RTM_GETADDR handling. (authored by melifaro).
netlink: improve RTM_GETADDR handling.
Mon, Jan 23, 10:16 PM
melifaro committed rGe121eaf737dd: netlink: Use NET_EPOCH_[CALL|WAIT] macros (authored by zlei).
netlink: Use NET_EPOCH_[CALL|WAIT] macros
Mon, Jan 23, 10:16 PM
melifaro committed rG176e0427b208: testing: add python test examples (authored by melifaro).
testing: add python test examples
Mon, Jan 23, 10:16 PM
melifaro committed rGa16f805f820e: man: add Netlink reference to socket(2) (authored by melifaro).
man: add Netlink reference to socket(2)
Mon, Jan 23, 10:16 PM
melifaro committed rG982fe5803470: testing: fix skipping netlink tests if netlink module is not loaded. (authored by melifaro).
testing: fix skipping netlink tests if netlink module is not loaded.
Mon, Jan 23, 10:16 PM
melifaro committed rG17e6123e6c93: netlink: fix ifaddr reporting. (authored by melifaro).
netlink: fix ifaddr reporting.
Mon, Jan 23, 10:16 PM
melifaro committed rG2419f06beb88: testing: improve python vnet wrapper. (authored by melifaro).
testing: improve python vnet wrapper.
Mon, Jan 23, 10:16 PM
melifaro committed rG8db26a13caf4: testing: allow custom test cleanup handlers in pytest (authored by melifaro).
testing: allow custom test cleanup handlers in pytest
Mon, Jan 23, 10:16 PM
melifaro committed rGf8175ea00f84: netlink: fix test-includes broken by f2c8381fce9b (authored by melifaro).
netlink: fix test-includes broken by f2c8381fce9b
Mon, Jan 23, 10:15 PM
melifaro committed rGb309249b7fd8: netlink: add snl(3) - simple netlink library (authored by melifaro).
netlink: add snl(3) - simple netlink library
Mon, Jan 23, 10:15 PM
melifaro committed rG6e4e97103113: netlink: make snl(3) headers self-contained. (authored by melifaro).
netlink: make snl(3) headers self-contained.
Mon, Jan 23, 10:15 PM
melifaro committed rGda988f405229: netlink: unregister groups along with family (authored by bapt).
netlink: unregister groups along with family
Mon, Jan 23, 10:15 PM
melifaro committed rGdb476bbc226a: netlink: improve interface handling (authored by melifaro).
netlink: improve interface handling
Mon, Jan 23, 10:15 PM
melifaro committed rGe46b64f4ebd4: netlink: fix netlink_snl_route.h header includes (authored by melifaro).
netlink: fix netlink_snl_route.h header includes
Mon, Jan 23, 10:15 PM
melifaro committed rG65f065ec7131: netlink: connect netlink tests to the build (authored by melifaro).
netlink: connect netlink tests to the build
Mon, Jan 23, 10:15 PM
melifaro committed rGa9ed45a93769: netlink: fix non-multipath build (authored by melifaro).
netlink: fix non-multipath build
Mon, Jan 23, 10:15 PM
melifaro committed rG5713f31ca0d9: netlink: store user-provided rtm_protocol (authored by melifaro).
netlink: store user-provided rtm_protocol
Mon, Jan 23, 10:15 PM
melifaro committed rGdfc6db8e18b6: netlink: add interface notification on link status / flags change. (authored by melifaro).
netlink: add interface notification on link status / flags change.
Mon, Jan 23, 10:15 PM
melifaro committed rG02b958b19535: netlink: add netlink user documentation. (authored by melifaro).
netlink: add netlink user documentation.
Mon, Jan 23, 10:15 PM
melifaro committed rGa6b537f6b945: netlink: suppress sending NLMSG_ERROR if NLMSG_DONE is already sent (authored by melifaro).
netlink: suppress sending NLMSG_ERROR if NLMSG_DONE is already sent
Mon, Jan 23, 10:15 PM
melifaro committed rG286b49d4ea3a: netlink: allow more than 64 groups per netlink socket. (authored by melifaro).
netlink: allow more than 64 groups per netlink socket.
Mon, Jan 23, 10:15 PM
melifaro committed rG7e49b54014b4: netlink: remove private netlink_var.h header from the non-netlink core files. (authored by melifaro).
netlink: remove private netlink_var.h header from the non-netlink core files.
Mon, Jan 23, 10:15 PM
melifaro committed rGd9211c8c7846: netlink: fix CTRL_CMD_GETFAMILY lookup/dumps. (authored by melifaro).
netlink: fix CTRL_CMD_GETFAMILY lookup/dumps.
Mon, Jan 23, 10:15 PM
melifaro committed rGc33cc82152c5: netlink: fix genetlink CTRL_ATTR_MCAST_GRP_MAX define. (authored by melifaro).
netlink: fix genetlink CTRL_ATTR_MCAST_GRP_MAX define.
Mon, Jan 23, 10:15 PM
melifaro committed rG476f69f0e597: netlink: fix NLMSG_SPACE() macro. (authored by melifaro).
netlink: fix NLMSG_SPACE() macro.
Mon, Jan 23, 10:15 PM
melifaro committed rGc18674d6313c: netlink: fix generic netlink privilege check. (authored by melifaro).
netlink: fix generic netlink privilege check.
Mon, Jan 23, 10:14 PM
melifaro committed rG6e5d41dc8f16: netlink: use (void) for function definitions with no arguments (authored by emaste).
netlink: use (void) for function definitions with no arguments
Mon, Jan 23, 10:14 PM
melifaro committed rG77ba029133bd: netlink: make it working without INET6 (authored by glebius).
netlink: make it working without INET6
Mon, Jan 23, 10:14 PM
melifaro committed rGfc65965e0184: Fix kernel build after fcb3f813f379f544f9cd2a10d18045588da0e132 . (authored by hselasky).
Fix kernel build after fcb3f813f379f544f9cd2a10d18045588da0e132 .
Mon, Jan 23, 10:14 PM
melifaro committed rG81174329b65e: netlink: Fix build without VIMAGE (authored by jkim).
netlink: Fix build without VIMAGE
Mon, Jan 23, 10:13 PM
melifaro committed rGafbff46b9bc2: netlink: fix non-default builds (no INET, INET6, ROUTE_MPATH). (authored by melifaro).
netlink: fix non-default builds (no INET, INET6, ROUTE_MPATH).
Mon, Jan 23, 10:13 PM
melifaro committed rG265a6220a3e3: netlink: fix build without INVARIANTS (authored by melifaro).
netlink: fix build without INVARIANTS
Mon, Jan 23, 10:13 PM
melifaro committed rG21f82ec32e11: netlink: fix format strings on 32-bit platforms (authored by melifaro).
netlink: fix format strings on 32-bit platforms
Mon, Jan 23, 10:13 PM
melifaro committed rG91d6657dbf9e: netlink: fix debugging on 32-bit platforms (authored by melifaro).
netlink: fix debugging on 32-bit platforms
Mon, Jan 23, 10:12 PM
melifaro committed rG655fe04370ad: netlink: make test-includes happy by hiding most of the header (authored by melifaro).
netlink: make test-includes happy by hiding most of the header
Mon, Jan 23, 10:12 PM
melifaro committed rG6bbfbaa6ae46: netlink: add netlink support (authored by melifaro).
netlink: add netlink support
Mon, Jan 23, 10:12 PM
melifaro added inline comments to D38167: Turn net.inet.carp.allow into a RW tunable.
Mon, Jan 23, 12:06 PM
melifaro added a reverting change for rG81a72d997e22: tcp: virtualise net.inet.tcp.msl sysctl.: rGddd3818317b5: Revert "tcp: virtualise net.inet.tcp.msl sysctl.".
Mon, Jan 23, 11:39 AM
melifaro committed rGddd3818317b5: Revert "tcp: virtualise net.inet.tcp.msl sysctl." (authored by melifaro).
Revert "tcp: virtualise net.inet.tcp.msl sysctl."
Mon, Jan 23, 11:39 AM
melifaro added a reverting change for D33270: tcp: virtualise net.inet.tcp.msl sysctl.: rGddd3818317b5: Revert "tcp: virtualise net.inet.tcp.msl sysctl.".
Mon, Jan 23, 11:38 AM
melifaro committed rG13a18f25560d: domains: allow pre-defined domains to be unloaded (authored by melifaro).
domains: allow pre-defined domains to be unloaded
Mon, Jan 23, 11:37 AM

Sun, Jan 22

melifaro committed rG30dd227cff75: netinet6: honor blackhole/unreach routes in the non-fastforwading code. (authored by melifaro).
netinet6: honor blackhole/unreach routes in the non-fastforwading code.
Sun, Jan 22, 6:51 PM
melifaro closed D38164: netinet6: honor blackhole/unreach routes in the non-fastforwading code..
Sun, Jan 22, 6:51 PM