Details
Details
- Reviewers
markj zlei - Group Reviewers
network - Commits
- rGbb06a80cf60b: netinet[6]: make in[6]_control use ucred instead of td.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Not directly related to the patch, but: nl_pru_attach() does not count its ucred reference, i.e., it does not use crhold() when copying the socket's reference. However, nl_pru_detach() uses a deferred free and does not set nl_cred = NULL before returning to sodealloc(), which releases the ucred reference, so there is a window where netlink holds a dangling ucred reference.