Page MenuHomeFreeBSD

netinet[6]: make in[6]_control use ucred instead of td
ClosedPublic

Authored by melifaro on Jun 29 2023, 7:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 10:48 PM
Unknown Object (File)
Thu, Dec 5, 3:53 AM
Unknown Object (File)
Nov 27 2024, 1:17 PM
Unknown Object (File)
Nov 17 2024, 5:31 AM
Unknown Object (File)
Nov 8 2024, 6:07 AM
Unknown Object (File)
Sep 23 2024, 8:49 PM
Unknown Object (File)
Sep 10 2024, 1:22 PM
Unknown Object (File)
Sep 2 2024, 6:21 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added a subscriber: markj.

Not directly related to the patch, but: nl_pru_attach() does not count its ucred reference, i.e., it does not use crhold() when copying the socket's reference. However, nl_pru_detach() uses a deferred free and does not set nl_cred = NULL before returning to sodealloc(), which releases the ucred reference, so there is a window where netlink holds a dangling ucred reference.

This revision is now accepted and ready to land.Jun 29 2023, 2:40 PM
zlei added a subscriber: zlei.

I'm not familiar with the netlink part, others look good to me.