Differential D41903

ndp: cope with unresolved neighbours
ClosedPublic
Actions

Authored by kp on Sep 18 2023, 5:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 8 2025, 1:50 AM

	Unknown Object (File)
	Jan 18 2025, 3:20 AM

	Unknown Object (File)
	Jan 16 2025, 3:28 PM

	Unknown Object (File)
	Jan 16 2025, 3:17 PM

	Unknown Object (File)
	Jan 16 2025, 3:14 PM

	Unknown Object (File)
	Jan 14 2025, 8:08 AM

	Unknown Object (File)
	Jan 10 2025, 2:07 PM

	Unknown Object (File)
	Jan 9 2025, 8:42 PM

View All 40 Files

Subscribers

Details

Reviewers

Group Reviewers

pfsense
network

Commits

rGa9326cd7656b: ndp: cope with unresolved neighbours
rG100bed131d76: ndp: cope with unresolved neighbours
rGb57df6fbcc48: ndp: cope with unresolved neighbours

Summary

If we've not (yet) resolved a neighbour nda_lladdr will be NULL, and
NLA_DATA_LEN(neigh->nda_lladdr) will dereference a NULL pointer.

Avoid that by checking nda_lladdr first, and only dereferencing if it's
not NULL.

Test case:
ping6 -c 1 <non-existant neighbour>
ndp -a

MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 18 2023, 5:03 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2023, 5:03 PM

kp requested review of this revision.Sep 18 2023, 5:03 PM

Harbormaster completed remote builds in B53631: Diff 127507.Sep 18 2023, 5:04 PM

melifaro accepted this revision.Sep 18 2023, 6:09 PM

This revision is now accepted and ready to land.Sep 18 2023, 6:09 PM

Closed by commit rGb57df6fbcc48: ndp: cope with unresolved neighbours (authored by kp). · Explain WhySep 18 2023, 6:13 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGb57df6fbcc48: ndp: cope with unresolved neighbours.

kp added a commit: rG100bed131d76: ndp: cope with unresolved neighbours.Sep 21 2023, 11:10 AM

kp added a commit: rGa9326cd7656b: ndp: cope with unresolved neighbours.Sep 21 2023, 12:00 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ndp/

7 lines

Diff 127510

usr.sbin/ndp/ndp_netlink.c

	Show First 20 Lines • Show All 622 Lines • ▼ Show 20 Lines		.quad MAIR_ATTR(MAIR_DEVICE_nGnRnE, 0) \| \
	MAIR_ATTR(MAIR_NORMAL_WT, 3)			MAIR_ATTR(MAIR_NORMAL_WT, 3)
	tcr:			tcr:
	.quad (TCR_TxSZ(64 - VIRT_BITS) \| TCR_ASID_16 \| TCR_TG1_4K \| \			.quad (TCR_TxSZ(64 - VIRT_BITS) \| TCR_ASID_16 \| TCR_TG1_4K \| \
	TCR_CACHE_ATTRS \| TCR_SMP_ATTRS)			TCR_CACHE_ATTRS \| TCR_SMP_ATTRS)
	sctlr_set:			sctlr_set:
	/* Bits to set */			/* Bits to set */
	.quad (SCTLR_LSMAOE \| SCTLR_nTLSMD \| SCTLR_UCI \| SCTLR_SPAN \| \			.quad (SCTLR_LSMAOE \| SCTLR_nTLSMD \| SCTLR_UCI \| SCTLR_SPAN \| \
	SCTLR_nTWE \| SCTLR_nTWI \| SCTLR_UCT \| SCTLR_DZE \| \			SCTLR_nTWE \| SCTLR_nTWI \| SCTLR_UCT \| SCTLR_DZE \| \
	SCTLR_I \| SCTLR_SED \| SCTLR_SA0 \| SCTLR_SA \| SCTLR_C \| SCTLR_M)			SCTLR_I \| SCTLR_SED \| SCTLR_SA0 \| SCTLR_SA \| SCTLR_C \| \
				SCTLR_M \| SCTLR_CP15BEN)
	sctlr_clear:			sctlr_clear:
	/* Bits to clear */			/* Bits to clear */
	.quad (SCTLR_EE \| SCTLR_EOE \| SCTLR_IESB \| SCTLR_WXN \| SCTLR_UMA \| \			.quad (SCTLR_EE \| SCTLR_EOE \| SCTLR_IESB \| SCTLR_WXN \| SCTLR_UMA \| \
	SCTLR_ITD \| SCTLR_THEE \| SCTLR_CP15BEN \| SCTLR_A)			SCTLR_ITD \| SCTLR_THEE \| SCTLR_A)

	.globl abort			.globl abort
	abort:			abort:
	b abort			b abort

	//.section .init_pagetable			//.section .init_pagetable
	.align 12 /* 4KiB aligned */			.align 12 /* 4KiB aligned */
	/*			/*
	▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines