Page MenuHomeFreeBSD

ndp: cope with unresolved neighbours
ClosedPublic

Authored by kp on Sep 18 2023, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 12:22 PM
Unknown Object (File)
Sep 20 2024, 12:58 PM
Unknown Object (File)
Sep 10 2024, 4:30 PM
Unknown Object (File)
Sep 4 2024, 1:11 PM
Unknown Object (File)
Aug 15 2024, 1:26 PM
Unknown Object (File)
Aug 15 2024, 1:25 PM
Unknown Object (File)
Aug 9 2024, 1:32 AM
Unknown Object (File)
Aug 7 2024, 1:56 AM
Subscribers

Details

Summary

If we've not (yet) resolved a neighbour nda_lladdr will be NULL, and
NLA_DATA_LEN(neigh->nda_lladdr) will dereference a NULL pointer.

Avoid that by checking nda_lladdr first, and only dereferencing if it's
not NULL.

Test case:
ping6 -c 1 <non-existant neighbour>
ndp -a

MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53631
Build 50522: arc lint + arc unit