Page MenuHomeFreeBSD

Make temp option for ndp work
Needs ReviewPublic

Authored by lytboris_gmail.com on Mar 23 2025, 8:20 AM.
Referenced Files
Unknown Object (File)
Thu, Oct 9, 8:46 PM
Unknown Object (File)
Thu, Oct 2, 10:25 AM
Unknown Object (File)
Wed, Oct 1, 4:55 AM
Unknown Object (File)
Tue, Sep 30, 9:27 PM
Unknown Object (File)
Tue, Sep 30, 8:35 AM
Unknown Object (File)
Sep 11 2025, 1:06 PM
Unknown Object (File)
Sep 9 2025, 5:26 PM
Unknown Object (File)
Sep 6 2025, 3:34 PM

Details

Reviewers
melifaro
glebius
Summary

Both ways to create an artificial NDP record are broken: a call via rtsock sets wrong timeout, a netlink code does not check opts.expire_time value at all.

Patch addresses both issues.

Test Plan
  1. add 2001:DB8::/64 to an interface
  2. run ndp -s 2001:DB8::c001 11:22:33:44:55:66 temp
  3. check ndp -an | fgrep 2001:DB8::c001 to have < 20 minutes timeout
  4. rebuild ndp with -DWITHOUT_NETLINK=1 and repeat steps 1-3

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Thank you for working on this! Can we add tests here?

Are the tests that hard to add, or perhaps can it be proceeded with further without them?

Are the tests that hard to add, or perhaps can it be proceeded with further without them?

I will try to add them this or the next week, it takes a while to get familiar with test suite.