Make temp option for ndp work

[lytboris_gmail.com]

Summary

Both ways to create an artificial NDP record are broken: a call via rtsock sets wrong timeout, a netlink code does not check opts.expire_time value at all.

Patch addresses both issues.

Test Plan

1. add 2001:DB8::/64 to an interface
2. run ndp -s 2001:DB8::c001 11:22:33:44:55:66 temp
3. check ndp -an | fgrep 2001:DB8::c001 to have < 20 minutes timeout
4. rebuild ndp with -DWITHOUT_NETLINK=1 and repeat steps 1-3

[melifaro]

Thank you for working on this! Can we add tests here?

[zarychtam_plan-b.pwste.edu.pl]

Thank you for this fix. Works fine with Netlink.

[zarychtam_plan-b.pwste.edu.pl]

Are the tests that hard to add, or perhaps can it be proceeded with further without them?

[lytboris_gmail.com]

In D49459#1213490, @zarychtam_plan-b.pwste.edu.pl wrote:

Are the tests that hard to add, or perhaps can it be proceeded with further without them?

I will try to add them this or the next week, it takes a while to get familiar with test suite.

[lytboris_gmail.com]

Test for temp record is included into https://reviews.freebsd.org/D53299

[glebius]

usr.sbin/ndp/ndp.c

960

IMHO the comment isn't really needed. It just reiterates what we see in the code. If you don't like idea of using uptime for that purpose you'd better make a longer XXX comment that would elaborate on why using uptime is not the best idea.

usr.sbin/ndp/ndp_netlink.c

484–495

507

Please declare int off; at the beginning of the block.

P.S. IMHO, the entire API construct of adding a nested attribute should be a bit easier. Just comment into the air, not asking for anything here :)