netlink: descend into nested parsers when verifying
ClosedPublic
Actions

Authored by kp on Oct 16 2023, 12:07 PM.

Tags

None

Referenced Files

	F174708787: D42222.id128896.diff
	Mon, Oct 5, 9:25 AM

	Unknown Object (File)
	Thu, Oct 1, 5:35 PM

	Unknown Object (File)
	Thu, Sep 17, 7:44 PM

	Unknown Object (File)
	Wed, Sep 9, 8:08 AM

	Unknown Object (File)
	Sun, Sep 6, 8:52 PM

	Unknown Object (File)
	Sep 5 2026, 11:27 PM

	Unknown Object (File)
	Sep 3 2026, 11:36 PM

	Unknown Object (File)
	Sep 3 2026, 2:26 PM

View All Files

Subscribers

glebius

imp

Details

Reviewers

melifaro

Group Reviewers

network
pfsense

Commits

rGfad5734995e3: netlink: descend into nested parsers when verifying

Summary

When we verify that the attributes are correctly sorted we should also
try to verify the nested attribute parsers.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 16 2023, 12:07 PM

Herald added subscribers: glebius, imp. · View Herald TranscriptOct 16 2023, 12:07 PM

kp requested review of this revision.Oct 16 2023, 12:07 PM

Harbormaster completed remote builds in B54001: Diff 128822.Oct 16 2023, 12:07 PM

kp added a parent revision: D42221: netlink: add attr parser utility functions.Oct 16 2023, 12:07 PM

kp added a child revision: D42223: netlink: cope with growing requests.

melifaro accepted this revision.Oct 16 2023, 3:19 PM

This revision is now accepted and ready to land.Oct 16 2023, 3:19 PM

Closed by commit rGfad5734995e3: netlink: descend into nested parsers when verifying (authored by kp). · Explain WhyOct 17 2023, 7:38 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGfad5734995e3: netlink: descend into nested parsers when verifying.

Revision Contents
Changeset List

Path

Size

sys/

netlink/

netlink_message_parser.h

8 lines

Diff 128896

View Options

sys/netlink/netlink_message_parser.h

netlink: descend into nested parsers when verifyingClosedPublicActions