Page MenuHomeFreeBSD

ethernet: Reduce a runtime ntohs() in fast path
Needs ReviewPublic

Authored by zlei on Oct 28 2023, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 17, 5:00 PM
Unknown Object (File)
Sep 1 2025, 1:15 PM
Unknown Object (File)
Aug 26 2025, 8:20 PM
Unknown Object (File)
Aug 26 2025, 11:21 AM
Unknown Object (File)
Aug 20 2025, 4:29 PM
Unknown Object (File)
Aug 16 2025, 3:13 AM
Unknown Object (File)
Aug 15 2025, 6:43 AM
Unknown Object (File)
Aug 6 2025, 12:39 PM

Details

Reviewers
None
Group Reviewers
network
Summary

For untagged traffic, we always hit the check for ether_type.

No functional change intended.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Oct 28 2023, 7:13 PM
zlei added inline comments.
sys/net/if_ethersubr.c
633

An extra space to improve readability.

I’d rather avoid doing that. ntohs is fast and branchless, so I’d vote for optimizing for readability here (unless there is a measurable performance gain)

I’d rather avoid doing that.
ntohs is fast and branchless,

True indeed.

so I’d vote for optimizing for readability here (unless there is a measurable performance gain)

No measurable performance gain.

I’d rather avoid doing that. ntohs is fast and branchless, so I’d vote for optimizing for readability here (unless there is a measurable performance gain)

Agrreed.