Feed Advanced Search

Tue, Apr 24

ae added a reviewer for D15050: Add a SPD cache to speed up lookups: network.
Tue, Apr 24, 2:13 PM · network

Mon, Apr 23

ae committed rS332886: icmp6_reflect() sends ICMPv6 message with new IPv6 header. So, it is.
icmp6_reflect() sends ICMPv6 message with new IPv6 header. So, it is
Mon, Apr 23, 12:20 PM

Fri, Apr 20

ae added inline comments to D15050: Add a SPD cache to speed up lookups.
Fri, Apr 20, 3:41 PM · network
ae added inline comments to D15050: Add a SPD cache to speed up lookups.
Fri, Apr 20, 1:33 PM · network
ae closed D15083: Use pointer to fake bpf_if structure after bpfdetach().
Fri, Apr 20, 9:58 AM
ae committed rS332812: Add dead_bpf_if structure, that should be used as fake bpf_if.
Add dead_bpf_if structure, that should be used as fake bpf_if
Fri, Apr 20, 9:57 AM
ae committed rS332811: MFC r332467:.
MFC r332467:
Fri, Apr 20, 9:54 AM
ae committed rS332810: MFC r332475:.
MFC r332475:
Fri, Apr 20, 9:49 AM

Thu, Apr 19

ae committed rS332768: MFC r332459:.
MFC r332459:
Thu, Apr 19, 10:17 AM
ae committed rS332767: MFC r332457:.
MFC r332457:
Thu, Apr 19, 10:15 AM
ae committed rS332766: MFC r332456:.
MFC r332456:
Thu, Apr 19, 10:13 AM
ae committed rS332765: MFC r316825:.
MFC r316825:
Thu, Apr 19, 10:11 AM
ae committed rS332764: MFC r332451:.
MFC r332451:
Thu, Apr 19, 10:08 AM
ae committed rS332763: MFC r332449:.
MFC r332449:
Thu, Apr 19, 10:07 AM
ae committed rS332762: MFC r332448:.
MFC r332448:
Thu, Apr 19, 10:05 AM

Tue, Apr 17

ae added a comment to D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.

Maybe better solution is just provide 64-bit counters for all interfaces? It seems net-snmpd does so.

Tue, Apr 17, 1:40 PM
ae added a comment to D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.
In D15112#318277, @bz wrote:

Other question: why do we not set baudrate on the virtual interfaces?

Tue, Apr 17, 1:39 PM
ae created D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.
Tue, Apr 17, 1:11 PM

Mon, Apr 16

ae created D15086: Bring in some last changes in NAT64 implementation.
Mon, Apr 16, 12:25 PM
ae added reviewers for D15083: Use pointer to fake bpf_if structure after bpfdetach(): network, glebius.
Mon, Apr 16, 10:56 AM
ae created D15083: Use pointer to fake bpf_if structure after bpfdetach().
Mon, Apr 16, 10:49 AM

Fri, Apr 13

ae committed rS332475: Add check that mbuf had not multicast layer2 address..
Add check that mbuf had not multicast layer2 address.
Fri, Apr 13, 4:14 PM
ae committed rS332467: To avoid possible deadlock do not acquire JQUEUE_LOCK before callout_drain..
To avoid possible deadlock do not acquire JQUEUE_LOCK before callout_drain.
Fri, Apr 13, 10:03 AM

Thu, Apr 12

ae abandoned D14931: Migrate NAT64 to FIB KPI.
Thu, Apr 12, 9:39 PM
ae abandoned D14933: Fix returned value from NAT64LSN EA handler .
Thu, Apr 12, 9:39 PM
ae committed rS332459: Fix integer types mismatch for flags field in nat64stl_cfg structure..
Fix integer types mismatch for flags field in nat64stl_cfg structure.
Thu, Apr 12, 9:30 PM
ae committed rS332457: Use cfg->nomatch_verdict as return value from NAT64LSN handler when.
Use cfg->nomatch_verdict as return value from NAT64LSN handler when
Thu, Apr 12, 9:13 PM
ae committed rS332456: Migrate NAT64 to FIB KPI..
Migrate NAT64 to FIB KPI.
Thu, Apr 12, 9:05 PM
ae committed rS332451: Fix indenting in ipv6.c file, use tabs instead of mixing tabs and spaces..
Fix indenting in ipv6.c file, use tabs instead of mixing tabs and spaces.
Thu, Apr 12, 8:05 PM
ae committed rS332449: Remove printing of "not" keyword from print_ip6() function..
Remove printing of "not" keyword from print_ip6() function.
Thu, Apr 12, 7:44 PM
ae committed rS332448: Remove printing of "not" keyword from print_ip() function..
Remove printing of "not" keyword from print_ip() function.
Thu, Apr 12, 7:34 PM
ae added a comment to D15050: Add a SPD cache to speed up lookups.

Can you provide some numbers what benefits you have with this patch?

Thu, Apr 12, 6:08 PM · network

Wed, Apr 11

ae added inline comments to D15040: Add eventhandler for PCP network interface changes.
Wed, Apr 11, 11:05 AM
ae added inline comments to D15040: Add eventhandler for PCP network interface changes.
Wed, Apr 11, 11:04 AM
ae accepted D15040: Add eventhandler for PCP network interface changes.
Wed, Apr 11, 10:45 AM
ae committed rS332401: MFC r328988,r328989:.
MFC r328988,r328989:
Wed, Apr 11, 10:36 AM
ae committed rS332400: MFC r331668:.
MFC r331668:
Wed, Apr 11, 10:25 AM
ae added a comment to D15040: Add eventhandler for PCP network interface changes.

Maybe it would be enough to just introduce new IFNET_EVENT_PCP type for ifnet_event?

Wed, Apr 11, 9:54 AM

Mon, Apr 2

ae added a reviewer for D14933: Fix returned value from NAT64LSN EA handler : melifaro.
Mon, Apr 2, 3:43 PM
ae created D14933: Fix returned value from NAT64LSN EA handler .
Mon, Apr 2, 3:43 PM
ae created D14931: Migrate NAT64 to FIB KPI.
Mon, Apr 2, 1:16 PM

Wed, Mar 28

ae committed rS331668: Rework ipfw rules parsing and printing code..
Rework ipfw rules parsing and printing code.
Wed, Mar 28, 12:44 PM

Mar 26 2018

ae committed rS331542: MFC r331203:.
MFC r331203:
Mar 26 2018, 7:54 AM

Mar 25 2018

ae committed rS331527: MFC r330781:.
MFC r330781:
Mar 25 2018, 3:51 AM
ae committed rS331526: MFC r330779:.
MFC r330779:
Mar 25 2018, 3:45 AM
ae committed rS331525: MFC r330771:.
MFC r330771:
Mar 25 2018, 3:37 AM

Mar 22 2018

ae accepted D10943: Static analysis: Improve DAD deletion code.
Mar 22 2018, 11:17 AM

Mar 21 2018

ae accepted D13715: netpfil: Introduce PFIL_FWD flag.

Looks good to me.

Mar 21 2018, 10:38 AM · network

Mar 19 2018

ae accepted D14622: handle locking and memory safety for IPV6_PATHMTU in ip6_ctloutput().
Mar 19 2018, 10:55 AM
ae committed rS331203: Remove note that `fwd tablearg` is supported only by IPv4. IPv6 is.
Remove note that `fwd tablearg` is supported only by IPv4. IPv6 is
Mar 19 2018, 10:50 AM
ae committed rS331202: MFC r330792:.
MFC r330792:
Mar 19 2018, 9:54 AM
ae committed rS331201: MFC r330792:.
MFC r330792:
Mar 19 2018, 9:52 AM

Mar 16 2018

ae accepted D14702: Allow to specify PCP on packets not belonging to any VLAN..

This looks good to me.

Mar 16 2018, 11:12 AM
ae added inline comments to D14702: Allow to specify PCP on packets not belonging to any VLAN..
Mar 16 2018, 9:19 AM
ae added a reviewer for D14702: Allow to specify PCP on packets not belonging to any VLAN.: network.
Mar 16 2018, 8:26 AM

Mar 13 2018

ae committed rS330830: MFC r330537:.
MFC r330537:
Mar 13 2018, 8:47 AM
ae committed rS330829: MFC r330536:.
MFC r330536:
Mar 13 2018, 8:45 AM

Mar 12 2018

ae committed rS330792: Do not try to reassemble IPv6 fragments in "reass" rule..
Do not try to reassemble IPv6 fragments in "reass" rule.
Mar 12 2018, 9:41 AM

Mar 11 2018

ae committed rS330781: Update pfkey_open() function to set socket's write buffer size to.
Update pfkey_open() function to set socket's write buffer size to
Mar 11 2018, 7:26 PM
ae committed rS330779: Rework key_sendup_mbuf() a bit:.
Rework key_sendup_mbuf() a bit:
Mar 11 2018, 7:14 PM
ae committed rS330777: Add KASSERT to check that proper targed was used..
Add KASSERT to check that proper targed was used.
Mar 11 2018, 6:46 PM
ae committed rS330775: Replace panic() with KASSERTs..
Replace panic() with KASSERTs.
Mar 11 2018, 6:38 PM
ae committed rS330772: Check that we have PF_KEY sockets before iterating over all RAW sockets..
Check that we have PF_KEY sockets before iterating over all RAW sockets.
Mar 11 2018, 6:11 PM
ae committed rS330771: Remove obsoleted and unused key_sendup() function..
Remove obsoleted and unused key_sendup() function.
Mar 11 2018, 6:04 PM

Mar 9 2018

ae added a comment to D14623: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().

Also, both setsockopt() have the check

if (!error)
         INP_WUNLOCK(in6p);

but both getsockopt() have not it.

Mar 9 2018, 7:03 AM
ae requested changes to D14623: fix locking within tcp_ipsec_pcbctl() to match ipsec4_pcbctl(), ipsec4_pcbctl().

Why you need INP_WLOCK() for getsockopt()? Also ipsec_get_pcbpolicy() requieres INP_WLOCK(), and IPv4 version uses WLOCK, but IPv6 version uses RLOCK.

Mar 9 2018, 6:59 AM

Mar 6 2018

ae closed D14594: Define several ether types in linux/if_ether.h.
Mar 6 2018, 12:58 PM
ae committed rS330537: Add mapping for several ethernet types used by Linux to FreeBSD.
Add mapping for several ethernet types used by Linux to FreeBSD
Mar 6 2018, 12:58 PM
ae accepted D14585: Make getnameinfo(3) salen requirement less strict.
Mar 6 2018, 12:51 PM
ae closed D14593: Define ethernet type 0x88A8 as ETHERTYPE_QINQ.
Mar 6 2018, 12:02 PM
ae committed rS330536: Define ethernet type 0x88A8 as ETHERTYPE_QINQ..
Define ethernet type 0x88A8 as ETHERTYPE_QINQ.
Mar 6 2018, 12:02 PM
ae added reviewers for D14594: Define several ether types in linux/if_ether.h: network, hselasky, markj.
Mar 6 2018, 10:19 AM
ae created D14594: Define several ether types in linux/if_ether.h.
Mar 6 2018, 10:18 AM
ae created D14593: Define ethernet type 0x88A8 as ETHERTYPE_QINQ.
Mar 6 2018, 10:06 AM

Mar 5 2018

ae added inline comments to D14585: Make getnameinfo(3) salen requirement less strict.
Mar 5 2018, 5:28 PM

Feb 26 2018

ae committed rS330017: MFC r329563:.
MFC r329563:
Feb 26 2018, 12:01 PM

Feb 24 2018

ae committed rS329907: MFC r329561:.
MFC r329561:
Feb 24 2018, 1:04 PM

Feb 19 2018

ae committed rS329563: Remove unused variables and sysctl declaration..
Remove unused variables and sysctl declaration.
Feb 19 2018, 12:21 PM
ae committed rS329561: Check packet length to do not make out of bounds access. Also save ah_nxt.
Check packet length to do not make out of bounds access. Also save ah_nxt
Feb 19 2018, 11:14 AM
ae committed rS329559: MFC r328541:.
MFC r328541:
Feb 19 2018, 10:34 AM
ae committed rS329558: MFC r328540:.
MFC r328540:
Feb 19 2018, 10:30 AM

Feb 18 2018

ae added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..

Ready to do a bench: Does "our patches" means is this review or another patch ?

Feb 18 2018, 11:52 AM
ae committed rS329518: MFC r329101:.
MFC r329101:
Feb 18 2018, 11:37 AM

Feb 16 2018

ae added a comment to D14385: Wrap a vlan's parent's if_output in a separate function..

You can't just state it has "significant performance penalties" by looking at the code. Consider also that the path if_output takes isn't as direct as you might think anyway. When a vlan's if_output gets called you end up back in ether_output_frame. That ends up calling the interface's if_transmit, which puts you back in vlan_transmit. So the old path would have been:

Feb 16 2018, 8:53 AM
ae added a reviewer for D14385: Wrap a vlan's parent's if_output in a separate function.: olivier_cochard.me.
Feb 16 2018, 8:52 AM

Feb 14 2018

ae added a comment to D12685: Make ipfw dynamic states lockless on fast path.
In D12685#301251, @will wrote:

I admit I haven't looked at this very carefully, but: how do these dynamic states get freed? From dyn_expire_states:
To my untrained (and quickly reviewing) eye, it looks like these lists get cleared only in ipfw_dyn_uninit, here:

Feb 14 2018, 9:43 PM

Feb 13 2018

ae added a comment to D14291: Allow route change requests to not specify the gateway..

How it supposed to work for RADIX_MPATH case? I know RADIX_MPATH is currently broken, but anyway...

Feb 13 2018, 9:53 AM

Feb 12 2018

ae committed rS329158: MFC r328876:.
MFC r328876:
Feb 12 2018, 1:53 PM
ae committed rS329157: MFC r328876:.
MFC r328876:
Feb 12 2018, 12:42 PM

Feb 10 2018

ae committed rS329101: Reinitialize IP header length after checksum calculation. It is used.
Reinitialize IP header length after checksum calculation. It is used
Feb 10 2018, 10:13 AM

Feb 9 2018

ae added a comment to D14257: Update the MTU in affected routes when IPv6 RA changes the MTU.

Invoking of rt_updatemtu() looks right to me. But I don't like how rt_updatemtu() works.
Recently we found that in6_mtutimo() on systems with many IPv6 routes produces noticeable delay for packets processing.
It holds RIB_WLOCK while all routes are processed, and thus normal packets processing is blocked on RIB_RLOCK for this time.
Also in6_mtutimo looks like dead code, that is doing nothing useful.

Feb 9 2018, 9:36 AM

Feb 8 2018

Herald added a reviewer for D11725: Add optional TCP logging on sonewconn failures.: transport.

It would be good have some progress with this review.

Feb 8 2018, 11:52 AM

Feb 7 2018

ae accepted D14254: ICMPv6: fix redirects containing global addresses.
Feb 7 2018, 10:40 PM
ae added a comment to D14254: ICMPv6: fix redirects containing global addresses.

The description looks confusing to me. As I understand, the problem is that fib6_lookup_nh_basic() returns next hop address without embedded scope zone id, so when it is IPv6 link-local address, the IN6_ARE_ADDR_EQUAL() comparison will fail due to src6 has this zone id embedded in.

Feb 7 2018, 9:19 PM
ae committed rS328989: Remove duplicate #include <netinet/ip_var.h>..
Remove duplicate #include <netinet/ip_var.h>.
Feb 7 2018, 7:12 PM
ae committed rS328988: Rework ipfw dynamic states implementation to be lockless on fast path..
Rework ipfw dynamic states implementation to be lockless on fast path.
Feb 7 2018, 7:00 PM
ae closed D12685: Make ipfw dynamic states lockless on fast path.
Feb 7 2018, 7:00 PM
ae added a comment to D12685: Make ipfw dynamic states lockless on fast path.

I'll try to change the related code to use ck_pr_xxx_32 operations, it seems all platforms support them.

Feb 7 2018, 10:38 AM
ae added a comment to D12685: Make ipfw dynamic states lockless on fast path.

I tried to build universe and it is failed to build on sparc64 and powerpc. At least not all CK's primitives are defined for these platforms.

Feb 7 2018, 9:47 AM
ae committed rS328968: MFC r328326:.
MFC r328326:
Feb 7 2018, 9:28 AM