Tue, Apr 24
Mon, Apr 23
Fri, Apr 20
Thu, Apr 19
Tue, Apr 17
Maybe better solution is just provide 64-bit counters for all interfaces? It seems net-snmpd does so.
Mon, Apr 16
Fri, Apr 13
Thu, Apr 12
Can you provide some numbers what benefits you have with this patch?
Wed, Apr 11
Maybe it would be enough to just introduce new IFNET_EVENT_PCP type for ifnet_event?
Mon, Apr 2
Wed, Mar 28
Mar 26 2018
Mar 25 2018
Mar 22 2018
Mar 21 2018
Looks good to me.
Mar 19 2018
Mar 16 2018
This looks good to me.
Mar 13 2018
Mar 12 2018
Mar 11 2018
Mar 9 2018
Also, both setsockopt() have the check
if (!error) INP_WUNLOCK(in6p);
but both getsockopt() have not it.
Why you need INP_WLOCK() for getsockopt()? Also ipsec_get_pcbpolicy() requieres INP_WLOCK(), and IPv4 version uses WLOCK, but IPv6 version uses RLOCK.
Mar 6 2018
Mar 5 2018
Feb 26 2018
Feb 24 2018
Feb 19 2018
Feb 18 2018
Ready to do a bench: Does "our patches" means is this review or another patch ?
Feb 16 2018
You can't just state it has "significant performance penalties" by looking at the code. Consider also that the path if_output takes isn't as direct as you might think anyway. When a vlan's if_output gets called you end up back in ether_output_frame. That ends up calling the interface's if_transmit, which puts you back in vlan_transmit. So the old path would have been:
Feb 14 2018
I admit I haven't looked at this very carefully, but: how do these dynamic states get freed? From dyn_expire_states:
To my untrained (and quickly reviewing) eye, it looks like these lists get cleared only in ipfw_dyn_uninit, here:
Feb 13 2018
How it supposed to work for RADIX_MPATH case? I know RADIX_MPATH is currently broken, but anyway...
Feb 12 2018
Feb 10 2018
Feb 9 2018
Invoking of rt_updatemtu() looks right to me. But I don't like how rt_updatemtu() works.
Recently we found that in6_mtutimo() on systems with many IPv6 routes produces noticeable delay for packets processing.
It holds RIB_WLOCK while all routes are processed, and thus normal packets processing is blocked on RIB_RLOCK for this time.
Also in6_mtutimo looks like dead code, that is doing nothing useful.
Feb 8 2018
It would be good have some progress with this review.
Feb 7 2018
The description looks confusing to me. As I understand, the problem is that fib6_lookup_nh_basic() returns next hop address without embedded scope zone id, so when it is IPv6 link-local address, the IN6_ARE_ADDR_EQUAL() comparison will fail due to src6 has this zone id embedded in.
I'll try to change the related code to use ck_pr_xxx_32 operations, it seems all platforms support them.
I tried to build universe and it is failed to build on sparc64 and powerpc. At least not all CK's primitives are defined for these platforms.